Commit 1ce792f7 authored by Andrea Galbusera's avatar Andrea Galbusera

Pass keyword args explicitly

Cascading namespace setting database migration helper called
add_columns() without double splat yet triggering:

warning: Using the last argument as keyword parameters is deprecated;
maybe ** should be added to the call

This led to failures in specs that involved a migration that used the
helper.
parent c9d4a405
......@@ -31,10 +31,10 @@ module Gitlab
namespace_options = options.merge(null: true, default: nil)
add_column(:namespace_settings, setting_name, type, namespace_options)
add_column(:namespace_settings, setting_name, type, **namespace_options)
add_column(:namespace_settings, lock_column_name, :boolean, default: false, null: false)
add_column(:application_settings, setting_name, type, options)
add_column(:application_settings, setting_name, type, **options)
add_column(:application_settings, lock_column_name, :boolean, default: false, null: false)
end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment