Merge branch 'sh-check-features-table-gitaly' into 'master'

Fix rake gitlab:setup failing on new installs

Closes #212759

See merge request gitlab-org/gitlab!28270

changelogs/unreleased/sh-check-features-table-gitaly.yml

+---
+title: Fix rake gitlab:setup failing on new installs
+merge_request: 28270
+author:
+type: fixed

lib/feature/gitaly.rb

@@ -14,6 +14,9 @@ class Feature
       end
 
       def server_feature_flags
+        # We need to check that both the DB connection and table exists
+        return {} unless ::Gitlab::Database.cached_table_exists?(FlipperFeature.table_name)
+
         Feature.persisted_names
           .select { |f| f.start_with?(PREFIX) }
           .map do |f|

spec/lib/feature/gitaly_spec.rb

@@ -32,5 +32,15 @@ describe Feature::Gitaly do
 
     it { is_expected.to be_a(Hash) }
     it { is_expected.to eq("gitaly-feature-mep-mep" => "true") }
+
+    context 'when table does not exist' do
+      before do
+        allow(::Gitlab::Database).to receive(:cached_table_exists?).and_return(false)
+      end
+
+      it 'returns an empty Hash' do
+        expect(subject).to eq({})
+      end
+    end
   end
 end