Merge branch 'eb-reduce-refresh-stale-window' into 'master'

Reduce refresh stale window to 2 hours

See merge request gitlab-org/gitlab!84295

app/models/projects/build_artifacts_size_refresh.rb

@@ -4,7 +4,7 @@ module Projects
   class BuildArtifactsSizeRefresh < ApplicationRecord
     include BulkInsertSafe
 
-    STALE_WINDOW = 3.days
+    STALE_WINDOW = 2.hours
 
     self.table_name = 'project_build_artifacts_size_refreshes'
 

spec/models/projects/build_artifacts_size_refresh_spec.rb

@@ -14,13 +14,13 @@ RSpec.describe Projects::BuildArtifactsSizeRefresh, type: :model do
   end
 
   describe 'scopes' do
-    let_it_be(:refresh_1) { create(:project_build_artifacts_size_refresh, :running, updated_at: 4.days.ago) }
-    let_it_be(:refresh_2) { create(:project_build_artifacts_size_refresh, :running, updated_at: 2.days.ago) }
+    let_it_be(:refresh_1) { create(:project_build_artifacts_size_refresh, :running, updated_at: (described_class::STALE_WINDOW + 1.second).ago) }
+    let_it_be(:refresh_2) { create(:project_build_artifacts_size_refresh, :running, updated_at: 1.hour.ago) }
     let_it_be(:refresh_3) { create(:project_build_artifacts_size_refresh, :pending) }
     let_it_be(:refresh_4) { create(:project_build_artifacts_size_refresh, :created) }
 
     describe 'stale' do
-      it 'returns records in running state and has not been updated for more than 3 days' do
+      it 'returns records in running state and has not been updated for more than 2 hours' do
         expect(described_class.stale).to eq([refresh_1])
       end
     end