Commit 1ed71f63 authored by Adam Hegyi's avatar Adam Hegyi

Merge branch 'docs-ensure-cops-are-not-disabled' into 'master'

Add DB guideline about not disabling cops

See merge request gitlab-org/gitlab!28681
parents 97cf5659 125c7799
......@@ -80,6 +80,7 @@ the following preparations into account.
- Add the output of the migration(s) to the MR description.
- Add tests for the migration in `spec/migrations` if necessary. See [Testing Rails migrations at GitLab](testing_guide/testing_migrations_guide.md) for more details.
- When [high-traffic](https://gitlab.com/gitlab-org/gitlab/-/blob/master/rubocop/migration_helpers.rb#L12) tables are involved in the migration, use the [`with_lock_retries`](migration_style_guide.md#retry-mechanism-when-acquiring-database-locks) helper method. Review the relevant [examples in our documentation](migration_style_guide.md#examples) for use cases and solutions.
- Ensure RuboCop checks are not disabled unless there's a valid reason to.
#### Preparation when adding or modifying queries
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment