Merge branch '3965-fix-order-dependency-in-specs' into 'master'

Fix a spec to avoid writing to prometheus

Closes #3965

See merge request gitlab-org/gitlab-ee!3324

spec/workers/geo/metrics_update_worker_spec.rb

@@ -22,7 +22,9 @@ RSpec.describe Geo::MetricsUpdateWorker, :geo do
 
     it 'executes when Prometheus metrics are enabled' do
       allow(Gitlab::Metrics).to receive(:prometheus_metrics_enabled?).and_return(true)
-      expect(Geo::MetricsUpdateService).to receive(:new).and_call_original
+
+      service = double(:service, execute: true)
+      expect(Geo::MetricsUpdateService).to receive(:new).and_return(service)
 
       subject.perform
     end