Merge branch 'sh-geo-node-status-only-secondary' into 'master'

Only set status variables if Geo node is a secondary

See merge request gitlab-org/gitlab-ee!2903

app/models/geo_node_status.rb

@@ -15,7 +15,9 @@ class GeoNodeStatus
   end
 
   def db_replication_lag
-    @db_replication_lag ||= Gitlab::Geo::HealthCheck.db_replication_lag
+    return @db_replication_lag if defined?(@db_replication_lag)
+
+    @db_replication_lag = Gitlab::Geo::HealthCheck.db_replication_lag if Gitlab::Geo.secondary?
   end
 
   def db_replication_lag=(value)
@@ -39,7 +41,9 @@ class GeoNodeStatus
   end
 
   def cursor_last_event_id
-    @cursor_last_event_id ||= cursor_last_processed&.event_id
+    return @cursor_last_event_id if defined?(@cursor_last_event_id)
+
+    @cursor_last_event_id = cursor_last_processed&.event_id if Gitlab::Geo.secondary?
   end
 
   def cursor_last_event_id=(value)

spec/models/geo_node_status_spec.rb

@@ -104,6 +104,13 @@ describe GeoNodeStatus do
 
       expect(subject.db_replication_lag).to eq(1000)
     end
+
+    it "doesn't attempt to set replication lag if primary" do
+      expect(Gitlab::Geo::HealthCheck).not_to receive(:db_replication_lag)
+      expect(Gitlab::Geo).to receive(:secondary?).and_return(false)
+
+      expect(subject.db_replication_lag).to eq(nil)
+    end
   end
 
   describe '#lfs_objects_synced_in_percentage' do
@@ -196,6 +203,14 @@ describe GeoNodeStatus do
 
       expect(subject.cursor_last_event_id).to eq(event.event_id)
     end
+
+    it "doesn't attempt to retrieve cursor if primary" do
+      create(:geo_event_log_state)
+      expect(Gitlab::Geo).to receive(:secondary?).exactly(2).times.and_return(false)
+
+      expect(subject.cursor_last_event_date).to eq(nil)
+      expect(subject.cursor_last_event_id).to eq(nil)
+    end
   end
 
   context 'when no values are available' do