Merge branch 'bvl-fix-push-rule-without-branch' into 'master'

Fix when pushing without a branch name

Closes #3393

See merge request !2879

lib/gitlab/checks/change_access.rb

@@ -177,7 +177,7 @@ module Gitlab
 
       def branch_name_allowed_by_push_rule?(push_rule)
         return true unless push_rule
-        return true if @branch_name.empty?
+        return true if @branch_name.blank?
 
         push_rule.branch_name_allowed?(@branch_name)
       end

spec/lib/gitlab/checks/change_access_spec.rb

@@ -249,6 +249,14 @@ describe Gitlab::Checks::ChangeAccess do
           expect { subject }.to raise_error(Gitlab::GitAccess::UnauthorizedError, "Branch name does not follow the pattern '^(w*)$'")
         end
 
+        context 'when the ref is not a branch ref' do
+          let(:ref) { 'a/ref/thats/not/abranch' }
+
+          it 'allows the creation' do
+            expect { subject }.not_to raise_error
+          end
+        end
+
         context 'when no commits are present' do
           before do
             allow(project.repository).to receive(:new_commits) { [] }