Commit 2108f134 authored by Stan Hu's avatar Stan Hu

Enable include_lfs_blobs_in_archive feature flag by default

This has been enabled on GitLab.com for over a week. There were hundreds
of thousands of `/internal/lfs` of API calls made from the new Gitaly
LFS smudge filter with no apparent errors. Project archives are cached
via a CDN on GitLab.com, and for self-managed hosts Workhorse also has a
local disk cache, so that mitigates any extra network traffic generated
by larger archives.

Relates to https://gitlab.com/gitlab-org/gitlab/-/issues/268409
parent e70f863d
---
name: include_lfs_blobs_in_archive
introduced_by_url: '44116'
rollout_issue_url:
introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/44116
rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/268409
type: development
group: group::source code
default_enabled: false
default_enabled: true
......@@ -302,7 +302,7 @@ module Gitlab
private :archive_file_path
def archive_version_path
return '' unless Feature.enabled?(:include_lfs_blobs_in_archive)
return '' unless Feature.enabled?(:include_lfs_blobs_in_archive, default_enabled: true)
'@v2'
end
......
......@@ -270,7 +270,7 @@ module Gitlab
prefix: metadata['ArchivePrefix'],
format: format,
path: path.presence || "",
include_lfs_blobs: Feature.enabled?(:include_lfs_blobs_in_archive)
include_lfs_blobs: Feature.enabled?(:include_lfs_blobs_in_archive, default_enabled: true)
).to_proto
)
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment