Merge branch 'rspec-empty-line-after-letitbe-ee-spec-helpers' into 'master'

Fix RSpec/EmptyLineAfterFinalLetItBe for ee/spec/helpers

See merge request gitlab-org/gitlab!58383

.rubocop_manual_todo.yml

@@ -394,15 +394,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
     - ee/spec/features/markdown/metrics_spec.rb
     - ee/spec/features/registrations/group_invites_during_signup_flow_spec.rb
     - ee/spec/features/subscriptions_spec.rb
-    - ee/spec/helpers/ee/graph_helper_spec.rb
-    - ee/spec/helpers/ee/issues_helper_spec.rb
-    - ee/spec/helpers/ee/projects/incidents_helper_spec.rb
-    - ee/spec/helpers/ee/projects/security/api_fuzzing_configuration_helper_spec.rb
-    - ee/spec/helpers/ee/projects/security/configuration_helper_spec.rb
-    - ee/spec/helpers/ee/projects/security/sast_configuration_helper_spec.rb
-    - ee/spec/helpers/ee/trial_helper_spec.rb
-    - ee/spec/helpers/ee/user_callouts_helper_spec.rb
-    - ee/spec/helpers/vulnerabilities_helper_spec.rb
     - ee/spec/lib/ee/api/entities/user_with_admin_spec.rb
     - ee/spec/lib/ee/api/entities/vulnerability_spec.rb
     - ee/spec/lib/ee/event_filter_spec.rb

ee/changelogs/unreleased/rspec-empty-lines-after-letitbe-ee-spec-helpers.yml

+---
+title: Fix RSpec/EmptyLineAfterFinalLetItBe rubocop offenses in ee/spec/helpers
+merge_request: 58383
+author: Abdul Wadood @abdulwd
+type: other

ee/spec/helpers/ee/graph_helper_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe EE::GraphHelper do
   let_it_be(:current_user) { create(:user) }
+
   let(:project) { create(:project, :private) }
   let(:is_feature_licensed) { true }
   let(:is_user_authorized) { true }

ee/spec/helpers/ee/issues_helper_spec.rb

@@ -47,6 +47,7 @@ RSpec.describe EE::IssuesHelper do
   describe '#issue_in_subepic?' do
     let_it_be(:epic) { create(:epic) }
     let_it_be(:epic_issue) { create(:epic_issue, epic: epic) }
+
     let(:issue) { build_stubbed(:issue, epic_issue: epic_issue) }
     let(:new_issue) { build_stubbed(:issue) }
 

ee/spec/helpers/ee/projects/incidents_helper_spec.rb

@@ -6,6 +6,7 @@ RSpec.describe Projects::IncidentsHelper do
   include Gitlab::Routing.url_helpers
 
   let_it_be_with_refind(:project) { create(:project) }
+
   let(:project_path) { project.full_path }
   let(:new_issue_path) { new_project_issue_path(project) }
   let(:issue_path) { project_issues_path(project) }

ee/spec/helpers/ee/projects/security/api_fuzzing_configuration_helper_spec.rb

@@ -5,6 +5,7 @@ require 'spec_helper'
 RSpec.describe Projects::Security::ApiFuzzingConfigurationHelper do
   let_it_be(:project) { create(:project) }
   let_it_be(:user) { create(:user) }
+
   let(:security_configuration_path) { project_security_configuration_path(project) }
   let(:full_path) { project.full_path }
   let(:api_fuzzing_documentation_path) { help_page_path('user/application_security/api_fuzzing/index') }

ee/spec/helpers/ee/projects/security/configuration_helper_spec.rb

@@ -6,6 +6,7 @@ RSpec.describe EE::Projects::Security::ConfigurationHelper do
   include ActionView::Helpers::UrlHelper
 
   let_it_be(:project) { create(:project) }
+
   let(:current_user) { create(:user) }
 
   subject { helper.security_upgrade_path }

ee/spec/helpers/ee/projects/security/sast_configuration_helper_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe Projects::Security::SastConfigurationHelper do
   let_it_be(:project) { create(:project) }
+
   let(:project_path) { project.full_path }
   let(:docs_path) { help_page_path('user/application_security/sast/index', anchor: 'configuration') }
   let(:analyzers_docs_path) { help_page_path('user/application_security/sast/analyzers') }

ee/spec/helpers/ee/trial_helper_spec.rb

@@ -121,6 +121,7 @@ RSpec.describe EE::TrialHelper do
 
   describe '#show_trial_namespace_select?' do
     let_it_be(:have_group_namespace) { false }
+
     before do
       allow(helper).to receive(:any_trial_group_namespaces?).and_return(have_group_namespace)
     end

ee/spec/helpers/ee/user_callouts_helper_spec.rb

@@ -135,6 +135,7 @@ RSpec.describe EE::UserCalloutsHelper do
   describe '#render_dashboard_ultimate_trial' do
     let_it_be(:namespace) { create(:namespace) }
     let_it_be(:ultimate_plan) { create(:ultimate_plan) }
+
     let(:user) { namespace.owner }
 
     where(:any_namespace_without_trial?, :show_ultimate_trial?, :user_default_dashboard?, :has_no_trial_or_paid_plan?, :should_render?) do

ee/spec/helpers/vulnerabilities_helper_spec.rb

@@ -7,6 +7,7 @@ RSpec.describe VulnerabilitiesHelper do
   let_it_be(:project) { create(:project, :repository, :public) }
   let_it_be(:pipeline) { create(:ci_pipeline, :success, project: project) }
   let_it_be(:finding) { create(:vulnerabilities_finding, pipelines: [pipeline], project: project, severity: :high) }
+
   let(:vulnerability) { create(:vulnerability, title: "My vulnerability", project: project, findings: [finding]) }
 
   before do