Add latest changes from gitlab-org/gitlab@master

app/assets/javascripts/pages/projects/shared/permissions/components/settings_panel.vue

 <script>
+import { GlSprintf, GlLink } from '@gitlab/ui';
+
 import settingsMixin from 'ee_else_ce/pages/projects/shared/permissions/mixins/settings_pannel_mixin';
 import { s__ } from '~/locale';
 import projectFeatureSetting from './project_feature_setting.vue';
@@ -19,6 +21,8 @@ export default {
     projectFeatureSetting,
     projectFeatureToggle,
     projectSettingRow,
+    GlSprintf,
+    GlLink,
   },
   mixins: [settingsMixin],
 
@@ -67,6 +71,16 @@ export default {
       required: false,
       default: '',
     },
+    lfsObjectsExist: {
+      type: Boolean,
+      required: false,
+      default: false,
+    },
+    lfsObjectsRemovalHelpPath: {
+      type: String,
+      required: false,
+      default: '',
+    },
     registryHelpPath: {
       type: String,
       required: false,
@@ -377,6 +391,23 @@ export default {
             :disabled-input="!repositoryEnabled"
             name="project[lfs_enabled]"
           />
+          <p v-if="!lfsEnabled && lfsObjectsExist">
+            <gl-sprintf
+              :message="
+                s__(
+                  'ProjectSettings|LFS objects from this repository are still available to forks. %{linkStart}How do I remove them?%{linkEnd}',
+                )
+              "
+            >
+              <template #link="{ content }">
+                <span class="d-block">
+                  <gl-link :href="lfsObjectsRemovalHelpPath" target="_blank">
+                    {{ content }}
+                  </gl-link>
+                </span>
+              </template>
+            </gl-sprintf>
+          </p>
         </project-setting-row>
         <project-setting-row
           v-if="packagesAvailable"

app/finders/releases_finder.rb

@@ -9,7 +9,8 @@ class ReleasesFinder
   def execute(preload: true)
     return Release.none unless Ability.allowed?(@current_user, :read_release, @project)
 
-    releases = @project.releases
+    # See https://gitlab.com/gitlab-org/gitlab/-/issues/211988
+    releases = @project.releases.where.not(tag: nil) # rubocop:disable CodeReuse/ActiveRecord
     releases = releases.preloaded if preload
     releases.sorted
   end

app/helpers/projects_helper.rb

@@ -603,6 +603,8 @@ module ProjectsHelper
       registryHelpPath: help_page_path('user/packages/container_registry/index'),
       lfsAvailable: Gitlab.config.lfs.enabled,
       lfsHelpPath: help_page_path('workflow/lfs/manage_large_binaries_with_git_lfs'),
+      lfsObjectsExist: project.lfs_objects.exists?,
+      lfsObjectsRemovalHelpPath: help_page_path('administration/lfs/manage_large_binaries_with_git_lfs', anchor: 'removing-objects-from-lfs'),
       pagesAvailable: Gitlab.config.pages.enabled,
       pagesAccessControlEnabled: Gitlab.config.pages.access_control,
       pagesAccessControlForced: ::Gitlab::Pages.access_control_is_forced?,

app/models/concerns/has_repository.rb

@@ -15,6 +15,15 @@ module HasRepository
 
   delegate :base_dir, :disk_path, to: :storage
 
+  class_methods do
+    def pick_repository_storage
+      # We need to ensure application settings are fresh when we pick
+      # a repository storage to use.
+      Gitlab::CurrentSettings.expire_current_application_settings
+      Gitlab::CurrentSettings.pick_repository_storage
+    end
+  end
+
   def valid_repo?
     repository.exists?
   rescue

app/models/project.rb

@@ -67,10 +67,7 @@ class Project < ApplicationRecord
   default_value_for :resolve_outdated_diff_discussions, false
   default_value_for :container_registry_enabled, gitlab_config_features.container_registry
   default_value_for(:repository_storage) do
-    # We need to ensure application settings are fresh when we pick
-    # a repository storage to use.
-    Gitlab::CurrentSettings.expire_current_application_settings
-    Gitlab::CurrentSettings.pick_repository_storage
+    pick_repository_storage
   end
 
   default_value_for(:shared_runners_enabled) { Gitlab::CurrentSettings.shared_runners_enabled }

app/models/snippet.rb

@@ -288,8 +288,7 @@ class Snippet < ApplicationRecord
   end
 
   def repository_storage
-    snippet_repository&.shard_name ||
-      Gitlab::CurrentSettings.pick_repository_storage
+    snippet_repository&.shard_name || self.class.pick_repository_storage
   end
 
   def create_repository

app/services/ci/create_job_artifacts_service.rb

@@ -77,6 +77,7 @@ module Ci
       track_exception(error, job, params)
       error(error.message, :service_unavailable)
     rescue => error
+      track_exception(error, job, params)
       error(error.message, :bad_request)
     end
 

changelogs/unreleased/211394-releases-page-in-not-loading-on-pagination.yml

+---
+title: Filter out Releases with missing tags
+merge_request: 27716
+author:
+type: fixed

changelogs/unreleased/add-missing-track-exception-call.yml

+---
+title: Add missing track_exception() call to Ci::CreateJobArtifactsService
+merge_request: 27954
+author:
+type: other

changelogs/unreleased/fj-ensure-freshness-snippet-creation.yml

+---
+title: Ensure freshness of settings with snippet creation
+merge_request: 27897
+author:
+type: changed

changelogs/unreleased/improve-lfs-toggle-message.yml

+---
+title: Show object access warning when disabling repo LFS
+merge_request: 26696
+author:
+type: other

changelogs/unreleased/nicolasdular-add-max-namepsace-storage-limit-column.yml

+---
+title: Add namespace_storage_size_limit to application settings
+merge_request: 27786
+author:
+type: added

db/migrate/20200324115359_add_namespace_storage_size_limit_to_application_settings.rb

+# frozen_string_literal: true
+
+class AddNamespaceStorageSizeLimitToApplicationSettings < ActiveRecord::Migration[6.0]
+  include Gitlab::Database::MigrationHelpers
+
+  DOWNTIME = false
+  disable_ddl_transaction!
+
+  def up
+    add_column_with_default :application_settings, :namespace_storage_size_limit, :bigint, default: 0
+  end
+
+  def down
+    remove_column :application_settings, :namespace_storage_size_limit
+  end
+end

db/structure.sql

@@ -395,7 +395,8 @@ CREATE TABLE public.application_settings (
     prevent_merge_requests_committers_approval boolean DEFAULT false NOT NULL,
     email_restrictions_enabled boolean DEFAULT false NOT NULL,
     email_restrictions text,
-    npm_package_requests_forwarding boolean DEFAULT true NOT NULL
+    npm_package_requests_forwarding boolean DEFAULT true NOT NULL,
+    namespace_storage_size_limit bigint DEFAULT 0 NOT NULL
 );
 
 CREATE SEQUENCE public.application_settings_id_seq
@@ -12750,5 +12751,6 @@ INSERT INTO "schema_migrations" (version) VALUES
 ('20200319123041'),
 ('20200319203901'),
 ('20200323075043'),
-('20200323122201');
+('20200323122201'),
+('20200324115359');
 

doc/administration/geo/replication/configuration.md

@@ -314,6 +314,19 @@ It is important to note that selective synchronization:
      Selective synchronization restrictions are implemented on the **secondary** nodes,
      not the **primary** node.
 
+### Git operations on unreplicated respositories
+
+> [Introduced](https://gitlab.com/groups/gitlab-org/-/epics/2562) in GitLab 12.10.
+
+Git clone, pull, and push operations over HTTP(S) are supported for repositories that
+exist on the **primary** node but not on **secondary** nodes. This situation can occur
+when:
+
+- Selective synchronization does not include the project attached to the repository.
+- The repository is actively being replicated but has not completed yet.
+
+SSH [support is planned](https://gitlab.com/groups/gitlab-org/-/epics/2562).
+
 ## Upgrading Geo
 
 See the [updating the Geo nodes document](updating_the_geo_nodes.md).

doc/administration/geo/replication/index.md

@@ -244,6 +244,7 @@ CAUTION: **Caution:**
 This list of limitations only reflects the latest version of GitLab. If you are using an older version, extra limitations may be in place.
 
 - Pushing directly to a **secondary** node redirects (for HTTP) or proxies (for SSH) the request to the **primary** node instead of [handling it directly](https://gitlab.com/gitlab-org/gitlab/issues/1381), except when using Git over HTTP with credentials embedded within the URI. For example, `https://user:password@secondary.tld`.
+- Cloning, pulling, or pushing repositories that exist on the **primary** node but not on the **secondary** nodes where [selective synchronization](configuration.md#selective-synchronization) does not include the project is not supported over SSH [but support is planned](https://gitlab.com/groups/gitlab-org/-/epics/2562). HTTP(S) is supported.
 - The **primary** node has to be online for OAuth login to happen. Existing sessions and Git are not affected.
 - The installation takes multiple manual steps that together can take about an hour depending on circumstances. We are working on improving this experience. See [Omnibus GitLab issue #2978](https://gitlab.com/gitlab-org/omnibus-gitlab/issues/2978) for details.
 - Real-time updates of issues/merge requests (for example, via long polling) doesn't work on the **secondary** node.

doc/administration/lfs/manage_large_binaries_with_git_lfs.md

@@ -93,6 +93,13 @@ git lfs fetch origin master
 
 Read the documentation on how to [migrate an existing Git repo with Git LFS](../../topics/git/migrate_to_git_lfs/index.md).
 
+### Removing objects from LFS
+
+To remove objects from LFS:
+
+1. Use [BFG-Cleaner](../../user/project/repository/reducing_the_repo_size_using_git.md#using-the-bfg-repo-cleaner) or [filter-branch](../../user/project/repository/reducing_the_repo_size_using_git.md#using-git-filter-branch) to remove the objects from the repository.
+1. Delete the relevant LFS lines for the objects you have removed from your `.gitattributes` file and commit those changes.
+
 ## File Locking
 
 > [Introduced](https://gitlab.com/gitlab-org/gitlab-foss/issues/35856) in GitLab 10.5.

doc/api/group_import_export.md

@@ -94,3 +94,5 @@ Note the following:
   to allow project imports into the desired group structure.
 - Imported groups are given a `private` visibility level, unless imported into a parent group.
 - If imported into a parent group, subgroups will inherit a similar level of visibility, unless otherwise restricted.
+- To preserve the member list and their respective permissions on imported groups,
+  review the users in these groups. Make sure these users exist before importing the desired groups.

doc/development/contributing/issue_workflow.md

@@ -14,7 +14,7 @@ see fit.
 
 ## Issue triaging
 
-Our issue triage policies are [described in our handbook](https://about.gitlab.com/handbook/engineering/issue-triage/).
+Our issue triage policies are [described in our handbook](https://about.gitlab.com/handbook/engineering/quality/issue-triage/).
 You are very welcome to help the GitLab team triage issues.
 We also organize [issue bash events](https://gitlab.com/gitlab-org/gitlab-foss/issues/17815)
 once every quarter.

doc/development/database_review.md

@@ -45,13 +45,6 @@ A database **reviewer**'s role is to:
   reassign MR to the database **maintainer** suggested by Reviewer
   Roulette.
 
-#### When there are no database maintainers available
-
-Currently we have a [critical shortage of database maintainers](https://gitlab.com/gitlab-org/gitlab/issues/29717). Until we are able to increase the number of database maintainers to support the volume of reviews, we have implemented this temporary solution. If the database **reviewer** cannot find an available database **maintainer** then:
-
-1. Assign the MR for a second review by a **database trainee maintainer** for further review.
-1. Once satisfied with the review process and if the database **maintainer** is still not available, skip the database maintainer approval step and assign the merge request to a backend maintainer for final review and approval.
-
 A database **maintainer**'s role is to:
 
 - Perform the final database review on the MR.

doc/development/documentation/styleguide.md

@@ -972,6 +972,7 @@ The following are examples of source Markdown for menu items with their publishe
 1. Go to **{book}** **Wiki**
 1. Go to **{snippet}** **Snippets**
 1. Go to **{users}** **Members**
+1. Select the **More actions** **{ellipsis_v}** icon  > **Hide stage**
 ```
 
 1. Go to **{home}** **Project overview > Details**
@@ -986,6 +987,7 @@ The following are examples of source Markdown for menu items with their publishe
 1. Go to **{book}** **Wiki**
 1. Go to **{snippet}** **Snippets**
 1. Go to **{users}** **Members**
+1. Select the **More actions** **{ellipsis_v}** icon > **Hide stage**
 
 ## Alert boxes
 
@@ -1364,17 +1366,18 @@ NOTE: **Note:**
 The [Product Manager for the relevant group](https://about.gitlab.com/handbook/product/categories/#devops-stages)
 must review and approve the addition or removal of any mentions of using feature flags before the doc change is merged.
 
-The following is sample text for adding feature flag documentation for a feature:
+The following is sample text for adding feature flag documentation for a feature that is
+off by default:
 
 ````md
-### Disabling the feature
+### Enabling the feature
 
-This feature comes with the `:feature_flag` feature flag enabled by default. However, in some cases
-this feature is incompatible with old configuration. To turn off the feature while configuration is
-migrated, ask a GitLab administrator with Rails console access to run the following command:
+This feature comes with the `:feature_flag` feature flag disabled by default. In some cases,
+this feature is incompatible with an old configuration. To turn on the feature,
+ask a GitLab administrator with Rails console access to run the following command:
 
 ```ruby
-Feature.disable(:feature_flag)
+Feature.enable(:feature_flag)
 ```
 ````
 

doc/topics/git/index.md

@@ -85,6 +85,7 @@ The following relate to Git Large File Storage:
 
 - [Getting Started with Git LFS](https://about.gitlab.com/blog/2017/01/30/getting-started-with-git-lfs-tutorial/)
 - [Migrate an existing Git repo with Git LFS](migrate_to_git_lfs/index.md)
+- [Removing objects from LFS](../../administration/lfs/manage_large_binaries_with_git_lfs.md#removing-objects-from-lfs)
 - [GitLab Git LFS user documentation](../../administration/lfs/manage_large_binaries_with_git_lfs.md)
 - [GitLab Git LFS admin documentation](../../administration/lfs/lfs_administration.md)
 - [git-annex to Git-LFS migration guide](../../administration/lfs/migrate_from_git_annex_to_git_lfs.md)

lib/gitlab/database/batch_count.rb

@@ -32,8 +32,8 @@ module Gitlab
       MAX_ALLOWED_LOOPS = 10_000
       SLEEP_TIME_IN_SECONDS = 0.01 # 10 msec sleep
       # Each query should take <<500ms https://gitlab.com/gitlab-org/gitlab/-/merge_requests/22705
-      DEFAULT_DISTINCT_BATCH_SIZE = 100_000
-      DEFAULT_BATCH_SIZE = 10_000
+      DEFAULT_DISTINCT_BATCH_SIZE = 10_000
+      DEFAULT_BATCH_SIZE = 100_000
 
       def initialize(relation, column: nil)
         @relation = relation
@@ -51,7 +51,7 @@ module Gitlab
         raise "The mode #{mode.inspect} is not supported" unless [:itself, :distinct].include?(mode)
 
         # non-distinct have better performance
-        batch_size ||= mode == :distinct ? DEFAULT_BATCH_SIZE : DEFAULT_DISTINCT_BATCH_SIZE
+        batch_size ||= mode == :distinct ? DEFAULT_DISTINCT_BATCH_SIZE : DEFAULT_BATCH_SIZE
 
         start = @relation.minimum(@column) || 0
         finish = @relation.maximum(@column) || 0

locale/gitlab.pot

@@ -15552,6 +15552,9 @@ msgstr ""
 msgid "ProjectSettings|Issues"
 msgstr ""
 
+msgid "ProjectSettings|LFS objects from this repository are still available to forks. %{linkStart}How do I remove them?%{linkEnd}"
+msgstr ""
+
 msgid "ProjectSettings|Learn more about badges."
 msgstr ""
 

spec/finders/releases_finder_spec.rb

@@ -52,6 +52,18 @@ describe ReleasesFinder do
           subject
         end
       end
+
+      # See https://gitlab.com/gitlab-org/gitlab/-/merge_requests/27716
+      context 'when tag is nil' do
+        before do
+          v1_0_0.update_column(:tag, nil)
+        end
+
+        it 'ignores rows with a nil tag' do
+          expect(subject.size).to eq(1)
+          expect(subject).to eq([v1_1_0])
+        end
+      end
     end
   end
 end

spec/frontend/pages/projects/shared/permissions/components/settings_panel_spec.js

-import { shallowMount } from '@vue/test-utils';
+import { shallowMount, mount } from '@vue/test-utils';
 
 import settingsPanel from '~/pages/projects/shared/permissions/components/settings_panel.vue';
 import {
@@ -32,6 +32,8 @@ const defaultProps = {
   registryHelpPath: '/help/user/packages/container_registry/index',
   lfsAvailable: true,
   lfsHelpPath: '/help/workflow/lfs/manage_large_binaries_with_git_lfs',
+  lfsObjectsExist: false,
+  lfsObjectsRemovalHelpPath: `/help/administration/lfs/manage_large_binaries_with_git_lfs#removing-objects-from-lfs`,
   pagesAvailable: true,
   pagesAccessControlEnabled: false,
   pagesAccessControlForced: false,
@@ -43,21 +45,25 @@ const defaultProps = {
 describe('Settings Panel', () => {
   let wrapper;
 
-  const mountComponent = customProps => {
-    const propsData = { ...defaultProps, ...customProps };
-    return shallowMount(settingsPanel, { propsData });
+  const mountComponent = (
+    { currentSettings = {}, ...customProps } = {},
+    mountFn = shallowMount,
+  ) => {
+    const propsData = {
+      ...defaultProps,
+      ...customProps,
+      currentSettings: { ...defaultProps.currentSettings, ...currentSettings },
+    };
+
+    return mountFn(settingsPanel, { propsData });
   };
 
   const overrideCurrentSettings = (currentSettingsProps, extraProps = {}) => {
-    return mountComponent({
-      ...extraProps,
-      currentSettings: {
-        ...defaultProps.currentSettings,
-        ...currentSettingsProps,
-      },
-    });
+    return mountComponent({ ...extraProps, currentSettings: currentSettingsProps });
   };
 
+  const findLFSSettingsMessage = () => wrapper.find({ ref: 'git-lfs-settings' }).find('p');
+
   beforeEach(() => {
     wrapper = mountComponent();
   });
@@ -333,6 +339,40 @@ describe('Settings Panel', () => {
 
       expect(wrapper.find('[name="project[lfs_enabled]"]').props().disabledInput).toEqual(true);
     });
+
+    describe.each`
+      lfsObjectsExist | lfsEnabled | isShown
+      ${true}         | ${true}    | ${false}
+      ${true}         | ${false}   | ${true}
+      ${false}        | ${true}    | ${false}
+      ${false}        | ${false}   | ${false}
+    `(
+      'with (lfsObjectsExist = $lfsObjectsExist, lfsEnabled = $lfsEnabled)',
+      ({ lfsObjectsExist, lfsEnabled, isShown }) => {
+        beforeEach(() => {
+          wrapper = mountComponent({ lfsObjectsExist, currentSettings: { lfsEnabled } }, mount);
+        });
+
+        if (isShown) {
+          it('shows warning message', () => {
+            const message = findLFSSettingsMessage();
+            const link = message.find('a');
+
+            expect(message.text()).toContain(
+              'LFS objects from this repository are still available to forks',
+            );
+            expect(link.text()).toEqual('How do I remove them?');
+            expect(link.attributes('href')).toEqual(
+              '/help/administration/lfs/manage_large_binaries_with_git_lfs#removing-objects-from-lfs',
+            );
+          });
+        } else {
+          it('does not show warning message', () => {
+            expect(findLFSSettingsMessage().exists()).toEqual(false);
+          });
+        }
+      },
+    );
   });
 
   describe('Packages', () => {

spec/models/project_spec.rb

@@ -1391,35 +1391,14 @@ describe Project do
   context 'repository storage by default' do
     let(:project) { build(:project) }
 
-    before do
-      storages = {
-        'default' => Gitlab::GitalyClient::StorageSettings.new('path' => 'tmp/tests/repositories'),
-        'picked'  => Gitlab::GitalyClient::StorageSettings.new('path' => 'tmp/tests/repositories')
-      }
-      allow(Gitlab.config.repositories).to receive(:storages).and_return(storages)
-    end
-
     it 'picks storage from ApplicationSetting' do
-      expect_any_instance_of(ApplicationSetting).to receive(:pick_repository_storage).and_return('picked')
+      expect_next_instance_of(ApplicationSetting) do |instance|
+        expect(instance).to receive(:pick_repository_storage).and_return('picked')
+      end
+      expect(described_class).to receive(:pick_repository_storage).and_call_original
 
       expect(project.repository_storage).to eq('picked')
     end
-
-    it 'picks from the latest available storage', :request_store do
-      stub_env('IN_MEMORY_APPLICATION_SETTINGS', 'false')
-      Gitlab::CurrentSettings.current_application_settings
-
-      settings = ApplicationSetting.last
-      settings.repository_storages = %w(picked)
-      settings.save!
-
-      expect(Gitlab::CurrentSettings.repository_storages).to eq(%w(default))
-
-      project
-
-      expect(project.repository.storage).to eq('picked')
-      expect(Gitlab::CurrentSettings.repository_storages).to eq(%w(picked))
-    end
   end
 
   context 'shared runners by default' do

spec/models/snippet_spec.rb

@@ -655,10 +655,18 @@ describe Snippet do
   describe '#repository_storage' do
     let(:snippet) { create(:snippet) }
 
-    it 'returns default repository storage' do
-      expect(Gitlab::CurrentSettings).to receive(:pick_repository_storage)
+    subject { snippet.repository_storage }
 
-      snippet.repository_storage
+    before do
+      expect_next_instance_of(ApplicationSetting) do |instance|
+        expect(instance).to receive(:pick_repository_storage).and_return('picked')
+      end
+    end
+
+    it 'returns repository storage from ApplicationSetting' do
+      expect(described_class).to receive(:pick_repository_storage).and_call_original
+
+      expect(subject).to eq 'picked'
     end
 
     context 'when snippet_project is already created' do
@@ -669,9 +677,7 @@ describe Snippet do
       end
 
       it 'returns repository_storage from snippet_project' do
-        expect(Gitlab::CurrentSettings).not_to receive(:pick_repository_storage)
-
-        expect(snippet.repository_storage).to eq 'foo'
+        expect(subject).to eq 'foo'
       end
     end
   end

spec/support/shared_examples/models/concerns/has_repository_shared_examples.rb

@@ -168,4 +168,37 @@ RSpec.shared_examples 'model with repository' do
     it { is_expected.to respond_to(:base_dir) }
     it { is_expected.to respond_to(:disk_path) }
   end
+
+  describe '.pick_repository_storage' do
+    subject { described_class.pick_repository_storage }
+
+    before do
+      storages = {
+        'default' => Gitlab::GitalyClient::StorageSettings.new('path' => 'tmp/tests/repositories'),
+        'picked'  => Gitlab::GitalyClient::StorageSettings.new('path' => 'tmp/tests/repositories')
+      }
+      allow(Gitlab.config.repositories).to receive(:storages).and_return(storages)
+    end
+
+    it 'picks storage from ApplicationSetting' do
+      expect_next_instance_of(ApplicationSetting) do |instance|
+        expect(instance).to receive(:pick_repository_storage).and_return('picked')
+      end
+
+      expect(subject).to eq('picked')
+    end
+
+    it 'picks from the latest available storage', :request_store do
+      stub_env('IN_MEMORY_APPLICATION_SETTINGS', 'false')
+      Gitlab::CurrentSettings.current_application_settings
+
+      settings = ApplicationSetting.last
+      settings.repository_storages = %w(picked)
+      settings.save!
+
+      expect(Gitlab::CurrentSettings.repository_storages).to eq(%w(default))
+      expect(subject).to eq('picked')
+      expect(Gitlab::CurrentSettings.repository_storages).to eq(%w(picked))
+    end
+  end
 end