Commit 27318298 authored by Achilleas Pipinellis's avatar Achilleas Pipinellis

Merge branch 'mk/add-releasing-the-replication-feature-docs' into 'master'

Geo docs: Add "Releasing the feature" section to Self-Service Framework

See merge request gitlab-org/gitlab!43249
parents 8a084bf2 21c88edc
...@@ -91,8 +91,6 @@ module Geo ...@@ -91,8 +91,6 @@ module Geo
::Packages::PackageFile ::Packages::PackageFile
end end
# Change this to `true` to release replication of this model. Then remove
# this override in the next release.
# The feature flag follows the format `geo_#{replicable_name}_replication`, # The feature flag follows the format `geo_#{replicable_name}_replication`,
# so here it would be `geo_package_file_replication` # so here it would be `geo_package_file_replication`
def self.replication_enabled_by_default? def self.replication_enabled_by_default?
...@@ -220,8 +218,6 @@ For example, to add support for files referenced by a `Widget` model with a ...@@ -220,8 +218,6 @@ For example, to add support for files referenced by a `Widget` model with a
model_record.file model_record.file
end end
# Change this to `true` to release replication of this model. Then remove
# this override in the next release.
# The feature flag follows the format `geo_#{replicable_name}_replication`, # The feature flag follows the format `geo_#{replicable_name}_replication`,
# so here it would be `geo_widget_replication` # so here it would be `geo_widget_replication`
def self.replication_enabled_by_default? def self.replication_enabled_by_default?
...@@ -693,3 +689,33 @@ To do: This should be done as part of ...@@ -693,3 +689,33 @@ To do: This should be done as part of
Widget sync and verification data (aggregate and individual) should now be Widget sync and verification data (aggregate and individual) should now be
available in the Admin UI! available in the Admin UI!
#### Releasing the feature
1. In `ee/app/replicators/geo/widget_replicator.rb`, delete the `self.replication_enabled_by_default?` method:
```ruby
module Geo
class WidgetReplicator < Gitlab::Geo::Replicator
...
# REMOVE THIS METHOD
def self.replication_enabled_by_default?
false
end
# REMOVE THIS METHOD
...
end
end
```
1. In `ee/app/graphql/types/geo/geo_node_type.rb`, remove the `feature_flag` option for the released type:
```ruby
field :widget_registries, ::Types::Geo::WidgetRegistryType.connection_type,
null: true,
resolver: ::Resolvers::Geo::WidgetRegistriesResolver,
description: 'Find widget registries on this Geo node',
feature_flag: :geo_widget_replication # REMOVE THIS LINE
```
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment