Merge branch '270065-bs4-optimization-nav-milestones' into 'master'

Remove duplicated BS display properties from Nav and Milestones

See merge request gitlab-org/gitlab!47129

app/views/layouts/nav/_dashboard.html.haml

@@ -71,11 +71,11 @@
 
   - if Feature.enabled?(:user_mode_in_session)
     - if header_link?(:admin_mode)
-      = nav_link(controller: 'admin/sessions', html_options: { class: "d-none d-lg-block d-xl-block"}) do
+      = nav_link(controller: 'admin/sessions', html_options: { class: "d-none d-lg-block"}) do
         = link_to destroy_admin_session_path, method: :post, title: _('Leave Admin Mode'), aria: { label: _('Leave Admin Mode') }, data: { toggle: 'tooltip', placement: 'bottom', container: 'body' } do
           = sprite_icon('lock-open', size: 18)
     - elsif current_user.admin?
-      = nav_link(controller: 'admin/sessions', html_options: { class: "d-none d-lg-block d-xl-block"}) do
+      = nav_link(controller: 'admin/sessions', html_options: { class: "d-none d-lg-block"}) do
         = link_to new_admin_session_path, title: _('Enter Admin Mode'), aria: { label: _('Enter Admin Mode') }, data: { toggle: 'tooltip', placement: 'bottom', container: 'body' } do
           = sprite_icon('lock', size: 18)
 

app/views/shared/milestones/_labels_tab.html.haml

@@ -7,7 +7,7 @@
       %span.prepend-description-left
         = markdown_field(label, :description)
 
-      .float-right.d-none.d-lg-block.d-xl-block
+      .float-right.d-none.d-lg-block
         = link_to milestones_issues_path(options.merge(state: 'opened')), class: 'btn gl-button btn-default-tertiary btn-action' do
           - pluralize milestone_issues_by_label_count(@milestone, label, state: :opened), _('open issue')
         = link_to milestones_issues_path(options.merge(state: 'closed')), class: 'btn gl-button btn-default-tertiary btn-action' do