Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
292efa53
Commit
292efa53
authored
May 25, 2021
by
Luke Duncalfe
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove unused Integration#external_wiki? method
parent
692580fe
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
0 additions
and
18 deletions
+0
-18
app/models/integration.rb
app/models/integration.rb
+0
-4
spec/models/integration_spec.rb
spec/models/integration_spec.rb
+0
-14
No files found.
app/models/integration.rb
View file @
292efa53
...
@@ -480,10 +480,6 @@ class Integration < ApplicationRecord
...
@@ -480,10 +480,6 @@ class Integration < ApplicationRecord
ProjectServiceWorker
.
perform_async
(
id
,
data
)
ProjectServiceWorker
.
perform_async
(
id
,
data
)
end
end
def
external_wiki?
type
==
'ExternalWikiService'
&&
active?
end
# override if needed
# override if needed
def
supports_data_fields?
def
supports_data_fields?
false
false
...
...
spec/models/integration_spec.rb
View file @
292efa53
...
@@ -896,20 +896,6 @@ RSpec.describe Integration do
...
@@ -896,20 +896,6 @@ RSpec.describe Integration do
end
end
end
end
describe
'#external_wiki?'
do
where
(
:type
,
:active
,
:result
)
do
'ExternalWikiService'
|
true
|
true
'ExternalWikiService'
|
false
|
false
'SlackService'
|
true
|
false
end
with_them
do
it
'returns the right result'
do
expect
(
create
(
:service
,
type:
type
,
active:
active
).
external_wiki?
).
to
eq
(
result
)
end
end
end
describe
'.available_services_names'
do
describe
'.available_services_names'
do
it
'calls the right methods'
do
it
'calls the right methods'
do
expect
(
described_class
).
to
receive
(
:services_names
).
and_call_original
expect
(
described_class
).
to
receive
(
:services_names
).
and_call_original
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment