Commit 295fcdf3 authored by Martin Wortschack's avatar Martin Wortschack

Project settings: Replace fa-chevron-down with SVG

parent c2957bce
<script> <script>
import { GlIcon } from '@gitlab/ui';
import projectFeatureToggle from '~/vue_shared/components/toggle_button.vue'; import projectFeatureToggle from '~/vue_shared/components/toggle_button.vue';
import { featureAccessLevelNone } from '../constants'; import { featureAccessLevelNone } from '../constants';
export default { export default {
components: { components: {
GlIcon,
projectFeatureToggle, projectFeatureToggle,
}, },
model: { model: {
prop: 'value', prop: 'value',
event: 'change', event: 'change',
}, },
props: { props: {
name: { name: {
type: String, type: String,
...@@ -34,7 +34,6 @@ export default { ...@@ -34,7 +34,6 @@ export default {
default: false, default: false,
}, },
}, },
computed: { computed: {
featureEnabled() { featureEnabled() {
return this.value !== 0; return this.value !== 0;
...@@ -51,7 +50,6 @@ export default { ...@@ -51,7 +50,6 @@ export default {
return this.disabledInput || !this.featureEnabled || this.displayOptions.length < 2; return this.disabledInput || !this.featureEnabled || this.displayOptions.length < 2;
}, },
}, },
methods: { methods: {
toggleFeature(featureEnabled) { toggleFeature(featureEnabled) {
if (featureEnabled === false || this.options.length < 1) { if (featureEnabled === false || this.options.length < 1) {
...@@ -96,7 +94,11 @@ export default { ...@@ -96,7 +94,11 @@ export default {
{{ optionName }} {{ optionName }}
</option> </option>
</select> </select>
<i aria-hidden="true" class="fa fa-chevron-down"> </i> <gl-icon
name="chevron-down"
aria-hidden="true"
class="gl-absolute gl-top-3 gl-right-3 gl-text-gray-500"
/>
</div> </div>
</div> </div>
</template> </template>
<script> <script>
import { GlSprintf, GlLink, GlFormCheckbox } from '@gitlab/ui'; import { GlIcon, GlSprintf, GlLink, GlFormCheckbox } from '@gitlab/ui';
import settingsMixin from 'ee_else_ce/pages/projects/shared/permissions/mixins/settings_pannel_mixin'; import settingsMixin from 'ee_else_ce/pages/projects/shared/permissions/mixins/settings_pannel_mixin';
import { s__ } from '~/locale'; import { s__ } from '~/locale';
...@@ -22,6 +22,7 @@ export default { ...@@ -22,6 +22,7 @@ export default {
projectFeatureSetting, projectFeatureSetting,
projectFeatureToggle, projectFeatureToggle,
projectSettingRow, projectSettingRow,
GlIcon,
GlSprintf, GlSprintf,
GlLink, GlLink,
GlFormCheckbox, GlFormCheckbox,
...@@ -325,7 +326,12 @@ export default { ...@@ -325,7 +326,12 @@ export default {
>{{ s__('ProjectSettings|Public') }}</option >{{ s__('ProjectSettings|Public') }}</option
> >
</select> </select>
<i aria-hidden="true" data-hidden="true" class="fa fa-chevron-down"></i> <gl-icon
name="chevron-down"
aria-hidden="true"
data-hidden="true"
class="gl-absolute gl-top-3 gl-right-3 gl-text-gray-500"
/>
</div> </div>
</div> </div>
<span class="form-text text-muted">{{ visibilityLevelDescription }}</span> <span class="form-text text-muted">{{ visibilityLevelDescription }}</span>
...@@ -540,7 +546,12 @@ export default { ...@@ -540,7 +546,12 @@ export default {
>{{ featureAccessLevelEveryone[1] }}</option >{{ featureAccessLevelEveryone[1] }}</option
> >
</select> </select>
<i aria-hidden="true" data-hidden="true" class="fa fa-chevron-down"></i> <gl-icon
name="chevron-down"
aria-hidden="true"
data-hidden="true"
class="gl-absolute gl-top-3 gl-right-3 gl-text-gray-500"
/>
</div> </div>
</div> </div>
</project-setting-row> </project-setting-row>
......
---
title: Replace fa-chevron-down with GitLab SVG in project visibility settings
merge_request: 45021
author:
type: changed
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment