Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
2a2f934e
Commit
2a2f934e
authored
Apr 06, 2022
by
Angelo Gulina
Committed by
Luke Duncalfe
Apr 06, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add a dev FF for payment validation
The payment validation will be performed via CustomersDot API.
parent
2ad63f89
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
18 additions
and
0 deletions
+18
-0
config/feature_flags/development/use_api_for_payment_validation.yml
...ture_flags/development/use_api_for_payment_validation.yml
+8
-0
ee/app/controllers/ee/projects/pipelines_controller.rb
ee/app/controllers/ee/projects/pipelines_controller.rb
+1
-0
ee/spec/features/projects/pipelines/pipeline_spec.rb
ee/spec/features/projects/pipelines/pipeline_spec.rb
+9
-0
No files found.
config/feature_flags/development/use_api_for_payment_validation.yml
0 → 100644
View file @
2a2f934e
---
name
:
use_api_for_payment_validation
introduced_by_url
:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/84292
rollout_issue_url
:
https://gitlab.com/gitlab-org/gitlab/-/issues/357282
milestone
:
'
14.10'
type
:
development
group
:
group::purchase
default_enabled
:
false
ee/app/controllers/ee/projects/pipelines_controller.rb
View file @
2a2f934e
...
...
@@ -14,6 +14,7 @@ module EE
push_frontend_feature_flag
(
:secure_vulnerability_training
,
project
,
default_enabled: :yaml
)
push_frontend_feature_flag
(
:vulnerability_report_pagination
,
current_user
,
default_enabled: :yaml
)
push_frontend_feature_flag
(
:vulnerability_report_page_size_selector
,
default_enabled: :yaml
)
push_frontend_feature_flag
(
:use_api_for_payment_validation
,
project
,
default_enabled: :yaml
)
end
feature_category
:license_compliance
,
[
:licenses
]
...
...
ee/spec/features/projects/pipelines/pipeline_spec.rb
View file @
2a2f934e
...
...
@@ -332,6 +332,7 @@ RSpec.describe 'Pipeline', :js do
before
do
allow
(
Gitlab
).
to
receive
(
:com?
)
{
true
}
stub_feature_flags
(
account_verification_payment_form_refresh:
false
)
create
(
:gitlab_subscription
,
:active_trial
,
namespace:
namespace
,
hosted_plan:
ultimate_plan
)
end
...
...
@@ -349,6 +350,14 @@ RSpec.describe 'Pipeline', :js do
visit
current_path
expect
(
page
).
not_to
have_selector
(
"#credit-card-verification-modal"
)
end
context
'with payment validation via api feature flag'
do
it
'pushes use_api_for_payment_validation feature flag'
do
visit
project_pipeline_validate_account_path
(
project
,
pipeline
)
expect
(
page
).
to
have_pushed_frontend_feature_flags
(
useApiForPaymentValidation:
true
)
end
end
end
private
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment