Maintainer review changes

* Rename computed props
* Migrate to gl ui styles
* Avoid translation string for constant

ee/app/assets/javascripts/vulnerabilities/components/details.vue

@@ -65,13 +65,13 @@ export default {
         msg => msg.name === SUPPORTING_MESSAGE_TYPES.RECORDED,
       )?.response;
     },
-    getConstructedRequest() {
+    constructedRequest() {
       return this.constructRequest(this.vulnerability.request);
     },
-    getConstructedResponse() {
+    constructedResponse() {
       return this.constructResponse(this.vulnerability.response);
     },
-    getConstructedRecordedResponse() {
+    constructedRecordedResponse() {
       return this.constructResponse(this.recordedMessage);
     },
     requestData() {
@@ -82,7 +82,7 @@ export default {
       return [
         {
           label: __('%{labelStart}Sent request:%{labelEnd} %{headers}'),
-          content: this.getConstructedRequest,
+          content: this.constructedRequest,
           isCode: true,
         },
       ].filter(x => x.content);
@@ -95,7 +95,7 @@ export default {
       return [
         {
           label: __('%{labelStart}Actual response:%{labelEnd} %{headers}'),
-          content: this.getConstructedResponse,
+          content: this.constructedResponse,
           isCode: true,
         },
       ].filter(x => x.content);
@@ -108,7 +108,7 @@ export default {
       return [
         {
           label: __('%{labelStart}Unmodified response:%{labelEnd} %{headers}'),
-          content: this.getConstructedRecordedResponse,
+          content: this.constructedRecordedResponse,
           isCode: true,
         },
       ].filter(x => x.content);
@@ -297,7 +297,7 @@ export default {
           :key="`${index}:${label}`"
           :sprintf-message="label"
         >
-          <code-block v-if="isCode" class="mt-1" :code="content" max-height="225px" />
+          <code-block v-if="isCode" class="gl-mt-2" :code="content" max-height="225px" />
           <template v-else>
             {{ content }}
           </template>
@@ -327,7 +327,7 @@ export default {
                 )
               "
             />
-            <code-block v-if="isCode" class="mt-1" :code="content" max-height="225px" />
+            <code-block v-if="isCode" class="gl-mt-2" :code="content" max-height="225px" />
             <template v-else>
               {{ content }}
             </template>
@@ -356,7 +356,7 @@ export default {
                 )
               "
             />
-            <code-block v-if="isCode" class="mt-1" :code="content" max-height="225px" />
+            <code-block v-if="isCode" class="gl-mt-2" :code="content" max-height="225px" />
             <template v-else>
               {{ content }}
             </template>
@@ -368,8 +368,8 @@ export default {
     <template v-if="assertion">
       <h3>{{ s__('Vulnerability|Additional Info') }}</h3>
       <ul>
-        <detail-item :sprintf-message="__('%{labelStart}Assert:%{labelEnd} %{assertion}')"
-          >{{ assertion }}
+        <detail-item :sprintf-message="__('%{labelStart}Assert:%{labelEnd} %{assertion}')">
+          {{ assertion }}
         </detail-item>
       </ul>
     </template>

ee/app/assets/javascripts/vulnerabilities/constants.js

@@ -67,5 +67,6 @@ export const REGEXES = {
 };
 
 export const SUPPORTING_MESSAGE_TYPES = {
-  RECORDED: s__('VulnerabilityManagement|Recorded'),
+  // eslint-disable-next-line @gitlab/require-i18n-strings
+  RECORDED: 'Recorded',
 };

locale/gitlab.pot

@@ -29646,9 +29646,6 @@ msgstr ""
 msgid "VulnerabilityManagement|Needs triage"
 msgstr ""
 
-msgid "VulnerabilityManagement|Recorded"
-msgstr ""
-
 msgid "VulnerabilityManagement|Something went wrong while trying to delete the comment. Please try again later."
 msgstr ""