Commit 2d48fc0e authored by Heinrich Lee Yu's avatar Heinrich Lee Yu

Rearrange code for readability

parent 085f3500
...@@ -192,22 +192,6 @@ class IssuableFinder ...@@ -192,22 +192,6 @@ class IssuableFinder
params[:milestone_title].present? params[:milestone_title].present?
end end
def filter_by_no_milestone?
[FILTER_NONE, Milestone::None.title].include?(params[:milestone_title].to_s.downcase)
end
def filter_by_any_milestone?
[FILTER_ANY, Milestone::Any.title].include?(params[:milestone_title].to_s.downcase)
end
def filter_by_upcoming_milestone?
params[:milestone_title] == Milestone::Upcoming.name
end
def filter_by_started_milestone?
params[:milestone_title] == Milestone::Started.name
end
def milestones def milestones
return @milestones if defined?(@milestones) return @milestones if defined?(@milestones)
...@@ -465,6 +449,24 @@ class IssuableFinder ...@@ -465,6 +449,24 @@ class IssuableFinder
end end
# rubocop: enable CodeReuse/ActiveRecord # rubocop: enable CodeReuse/ActiveRecord
def filter_by_no_milestone?
# Accepts `No Milestone` for compatibility
params[:milestone_title].to_s.downcase == FILTER_NONE || params[:milestone_title] == Milestone::None.title
end
def filter_by_any_milestone?
# Accepts `Any Milestone` for compatibility
params[:milestone_title].to_s.downcase == FILTER_ANY || params[:milestone_title] == Milestone::Any.title
end
def filter_by_upcoming_milestone?
params[:milestone_title] == Milestone::Upcoming.name
end
def filter_by_started_milestone?
params[:milestone_title] == Milestone::Started.name
end
def by_label(items) def by_label(items)
return items unless labels? return items unless labels?
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment