Merge branch 'issue#325836-fix-empty-line-after-let-it-be-gitlab-git' into 'master'

Fix EmptyLineAfterFinalLetItBe offenses in spec/lib/gitlab/git

See merge request gitlab-org/gitlab!58254

.rubocop_manual_todo.yml

@@ -679,12 +679,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
     - spec/lib/gitlab/data_builder/wiki_page_spec.rb
     - spec/lib/gitlab/deploy_key_access_spec.rb
     - spec/lib/gitlab/email/handler/service_desk_handler_spec.rb
-    - spec/lib/gitlab/git/lfs_changes_spec.rb
-    - spec/lib/gitlab/git/merge_base_spec.rb
-    - spec/lib/gitlab/git/push_spec.rb
-    - spec/lib/gitlab/git_access_design_spec.rb
-    - spec/lib/gitlab/git_access_project_spec.rb
-    - spec/lib/gitlab/git_access_wiki_spec.rb
     - spec/lib/gitlab/gitaly_client/operation_service_spec.rb
     - spec/lib/gitlab/gl_repository/repo_type_spec.rb
     - spec/lib/gitlab/group_search_results_spec.rb

changelogs/unreleased/issue-325836-fix-empty-line-after-let-it-be-gitlab-git.yml

+---
+title: Fix EmptyLineAfterFinalLetItBe offenses in spec/lib/gitlab/git
+merge_request: 58254
+author: Huzaifa Iftikhar @huzaifaiftikhar
+type: fixed

spec/lib/gitlab/git/lfs_changes_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe Gitlab::Git::LfsChanges do
   let_it_be(:project) { create(:project, :repository) }
+
   let(:newrev) { '54fcc214b94e78d7a41a9a8fe6d87a5e59500e51' }
   let(:blob_object_id) { '0c304a93cb8430108629bbbcaa27db3343299bc0' }
 

spec/lib/gitlab/git/merge_base_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe Gitlab::Git::MergeBase do
   let_it_be(:project) { create(:project, :repository) }
+
   let(:repository) { project.repository }
 
   subject(:merge_base) { described_class.new(repository, refs) }

spec/lib/gitlab/git/push_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe Gitlab::Git::Push do
   let_it_be(:project) { create(:project, :repository) }
+
   let(:oldrev) { project.commit('HEAD~2').id }
   let(:newrev) { project.commit.id }
   let(:ref) { 'refs/heads/some-branch' }

spec/lib/gitlab/git_access_design_spec.rb

@@ -6,6 +6,7 @@ RSpec.describe Gitlab::GitAccessDesign do
 
   let_it_be(:project) { create(:project) }
   let_it_be(:user) { project.owner }
+
   let(:protocol) { 'web' }
   let(:actor) { user }
 

spec/lib/gitlab/git_access_project_spec.rb

@@ -5,6 +5,7 @@ require 'spec_helper'
 RSpec.describe Gitlab::GitAccessProject do
   let_it_be(:user) { create(:user) }
   let_it_be(:project) { create(:project, :repository) }
+
   let(:container) { project }
   let(:actor) { user }
   let(:project_path) { project.path }

spec/lib/gitlab/git_access_wiki_spec.rb

@@ -6,6 +6,7 @@ RSpec.describe Gitlab::GitAccessWiki do
   let_it_be(:user) { create(:user) }
   let_it_be(:project) { create(:project, :wiki_repo) }
   let_it_be(:wiki) { create(:project_wiki, project: project) }
+
   let(:changes) { ['6f6d7e7ed 570e7b2ab refs/heads/master'] }
   let(:authentication_abilities) { %i[read_project download_code push_code] }
   let(:redirected_path) { nil }