Merge branch '19165-explore-projects-default-to-all' into 'master'

Make Explore Projects default to All

Closes #19165

See merge request gitlab-org/gitlab!23811

app/views/explore/projects/_nav.html.haml

 .top-area
   %ul.nav-links.nav.nav-tabs
-    = nav_link(page: [trending_explore_projects_path, explore_root_path]) do
-      = link_to trending_explore_projects_path do
-        = _('Trending')
+    = nav_link(page: [explore_projects_path, explore_root_path]) do
+      = link_to explore_projects_path do
+        = _('All')
     = nav_link(page: starred_explore_projects_path) do
       = link_to starred_explore_projects_path do
         = _('Most stars')
-    = nav_link(page: explore_projects_path) do
-      = link_to explore_projects_path do
-        = _('All')
+    = nav_link(page: trending_explore_projects_path) do
+      = link_to trending_explore_projects_path do
+        = _('Trending')
 
   .nav-controls
     - unless current_user

changelogs/unreleased/19165-explore-projects-default-to-all.yml

+---
+title: Make Explore Projects default to All
+merge_request: 23811
+author:
+type: changed

config/routes/explore.rb

@@ -8,7 +8,7 @@ namespace :explore do
 
   resources :groups, only: [:index]
   resources :snippets, only: [:index]
-  root to: 'projects#trending'
+  root to: 'projects#index'
 end
 
 # Compatibility with old routing

spec/features/dashboard/shortcuts_spec.rb

@@ -51,7 +51,7 @@ describe 'Dashboard shortcuts', :js do
       find('body').send_keys([:shift, 'P'])
 
       find('.nothing-here-block')
-      expect(page).to have_content('Explore public groups to find projects to contribute to.')
+      expect(page).to have_content("This user doesn't have any personal projects")
     end
   end