Merge branch 'cablett-13984-add-type-to-resolvers' into 'master'

Add type and type tests to GraphQL resolvers

See merge request gitlab-org/gitlab!46539

app/graphql/resolvers/alert_management/integrations_resolver.rb

@@ -5,6 +5,8 @@ module Resolvers
     class IntegrationsResolver < BaseResolver
       alias_method :project, :synchronized_object
 
+      type Types::AlertManagement::IntegrationType.connection_type, null: true
+
       def resolve(**args)
         return [] unless Feature.enabled?(:multiple_http_integrations, project)
 

app/graphql/resolvers/base_resolver.rb

@@ -8,32 +8,81 @@ module Resolvers
 
     argument_class ::Types::BaseArgument
 
-    def self.single
-      @single ||= Class.new(self) do
-        def ready?(**args)
-          ready, early_return = super
-          [ready, select_result(early_return)]
-        end
+    def self.singular_type
+      return unless type
 
-        def resolve(**args)
-          select_result(super)
-        end
+      unwrapped = type.unwrap
+
+      %i[node_type relay_node_type of_type itself].reduce(nil) do |t, m|
+        t || unwrapped.try(m)
+      end
+    end
 
-        def single?
-          true
+    def self.when_single(&block)
+      as_single << block
+
+      # Have we been called after defining the single version of this resolver?
+      if @single.present?
+        @single.instance_exec(&block)
+      end
+    end
+
+    def self.as_single
+      @as_single ||= []
+    end
+
+    def self.single_definition_blocks
+      ancestors.flat_map { |klass| klass.try(:as_single) || [] }
+    end
+
+    def self.single
+      @single ||= begin
+        parent = self
+        klass = Class.new(self) do
+          type parent.singular_type, null: true
+
+          def ready?(**args)
+            ready, early_return = super
+            [ready, select_result(early_return)]
+          end
+
+          def resolve(**args)
+            select_result(super)
+          end
+
+          def single?
+            true
+          end
+
+          def select_result(results)
+            results&.first
+          end
+
+          define_singleton_method :to_s do
+            "#{parent}.single"
+          end
         end
 
-        def select_result(results)
-          results&.first
+        single_definition_blocks.each do |definition|
+          klass.instance_exec(&definition)
         end
+
+        klass
       end
     end
 
     def self.last
+      parent = self
       @last ||= Class.new(self.single) do
+        type parent.singular_type, null: true
+
         def select_result(results)
           results&.last
         end
+
+        define_singleton_method :to_s do
+          "#{parent}.last"
+        end
       end
     end
 
@@ -68,14 +117,13 @@ module Resolvers
       end
     end
 
+    # TODO: remove! This should never be necessary
+    # Remove as part of https://gitlab.com/gitlab-org/gitlab/-/issues/13984,
+    # since once we use that authorization approach, the object is guaranteed to
+    # be synchronized before any field.
     def synchronized_object
       strong_memoize(:synchronized_object) do
-        case object
-        when BatchLoader::GraphQL
-          object.sync
-        else
-          object
-        end
+        ::Gitlab::Graphql::Lazy.force(object)
       end
     end
 

app/graphql/resolvers/design_management/design_resolver.rb

@@ -3,6 +3,8 @@
 module Resolvers
   module DesignManagement
     class DesignResolver < BaseResolver
+      type ::Types::DesignManagement::DesignType, null: true
+
       argument :id, ::Types::GlobalIDType[::DesignManagement::Design],
                required: false,
                description: 'Find a design by its ID'

app/graphql/resolvers/design_management/designs_resolver.rb

@@ -6,6 +6,8 @@ module Resolvers
       DesignID = ::Types::GlobalIDType[::DesignManagement::Design]
       VersionID = ::Types::GlobalIDType[::DesignManagement::Version]
 
+      type ::Types::DesignManagement::DesignType.connection_type, null: true
+
       argument :ids, [DesignID],
                required: false,
                description: 'Filters designs by their ID'

app/graphql/resolvers/error_tracking/sentry_detailed_error_resolver.rb

@@ -3,6 +3,8 @@
 module Resolvers
   module ErrorTracking
     class SentryDetailedErrorResolver < BaseResolver
+      type Types::ErrorTracking::SentryDetailedErrorType, null: true
+
       argument :id, GraphQL::ID_TYPE,
                 required: true,
                 description: 'ID of the Sentry issue'

app/graphql/resolvers/error_tracking/sentry_error_collection_resolver.rb

@@ -3,6 +3,8 @@
 module Resolvers
   module ErrorTracking
     class SentryErrorCollectionResolver < BaseResolver
+      type Types::ErrorTracking::SentryErrorCollectionType, null: true
+
       def resolve(**args)
         project = object
 

app/graphql/resolvers/error_tracking/sentry_errors_resolver.rb

@@ -3,6 +3,8 @@
 module Resolvers
   module ErrorTracking
     class SentryErrorsResolver < BaseResolver
+      type Types::ErrorTracking::SentryErrorType.connection_type, null: true
+
       def resolve(**args)
         args[:cursor] = args.delete(:after)
         project = object.project

app/graphql/resolvers/group_members_resolver.rb

@@ -2,6 +2,8 @@
 
 module Resolvers
   class GroupMembersResolver < MembersResolver
+    type Types::GroupMemberType.connection_type, null: true
+
     authorize :read_group_member
 
     private

app/graphql/resolvers/issues_resolver.rb

@@ -12,7 +12,7 @@ module Resolvers
               required: false,
               default_value: 'created_desc'
 
-    type Types::IssueType, null: true
+    type Types::IssueType.connection_type, null: true
 
     NON_STABLE_CURSOR_SORTS = %i[priority_asc priority_desc
                                  label_priority_asc label_priority_desc

app/graphql/resolvers/project_pipeline_resolver.rb

@@ -2,6 +2,8 @@
 
 module Resolvers
   class ProjectPipelineResolver < BaseResolver
+    type ::Types::Ci::PipelineType, null: true
+
     alias_method :project, :object
 
     argument :iid, GraphQL::ID_TYPE,

app/graphql/resolvers/projects/jira_imports_resolver.rb

@@ -3,6 +3,8 @@
 module Resolvers
   module Projects
     class JiraImportsResolver < BaseResolver
+      type Types::JiraImportType.connection_type, null: true
+
       include Gitlab::Graphql::Authorize::AuthorizeResource
 
       alias_method :project, :object

app/graphql/resolvers/projects/jira_projects_resolver.rb

@@ -5,6 +5,8 @@ module Resolvers
     class JiraProjectsResolver < BaseResolver
       include Gitlab::Graphql::Authorize::AuthorizeResource
 
+      type Types::Projects::Services::JiraProjectType.connection_type, null: true
+
       argument :name,
                GraphQL::STRING_TYPE,
                required: false,

app/graphql/resolvers/projects/services_resolver.rb

@@ -5,6 +5,8 @@ module Resolvers
     class ServicesResolver < BaseResolver
       include Gitlab::Graphql::Authorize::AuthorizeResource
 
+      type Types::Projects::ServiceType.connection_type, null: true
+
       argument :active,
                GraphQL::BOOLEAN_TYPE,
                required: false,

app/graphql/resolvers/snippets/blobs_resolver.rb

@@ -5,6 +5,8 @@ module Resolvers
     class BlobsResolver < BaseResolver
       include Gitlab::Graphql::Authorize::AuthorizeResource
 
+      type Types::Snippets::BlobType.connection_type, null: true
+
       alias_method :snippet, :object
 
       argument :paths, [GraphQL::STRING_TYPE],

app/graphql/resolvers/todo_resolver.rb

@@ -2,7 +2,7 @@
 
 module Resolvers
   class TodoResolver < BaseResolver
-    type Types::TodoType, null: true
+    type Types::TodoType.connection_type, null: true
 
     alias_method :target, :object
 

app/graphql/resolvers/tree_resolver.rb

@@ -2,6 +2,8 @@
 
 module Resolvers
   class TreeResolver < BaseResolver
+    type Types::Tree::TreeType, null: true
+
     argument :path, GraphQL::STRING_TYPE,
               required: false,
               default_value: '',

app/graphql/resolvers/users_resolver.rb

@@ -4,6 +4,7 @@ module Resolvers
   class UsersResolver < BaseResolver
     include Gitlab::Graphql::Authorize::AuthorizeResource
 
+    type Types::UserType.connection_type, null: true
     description 'Find Users'
 
     argument :ids, [GraphQL::ID_TYPE],

ee/app/graphql/ee/types/project_type.rb

@@ -122,7 +122,7 @@ module EE
               ::Types::Clusters::AgentType,
               null: true,
               description: 'Find a single cluster agent by name',
-              resolver: ::Resolvers::Clusters::AgentResolver.single
+              resolver: ::Resolvers::Clusters::AgentsResolver.single
 
         field :cluster_agents,
               ::Types::Clusters::AgentType.connection_type,

ee/app/graphql/resolvers/clusters/agent_resolver.rb

-# frozen_string_literal: true
-
-module Resolvers
-  module Clusters
-    class AgentResolver < AgentsResolver
-      argument :name, GraphQL::STRING_TYPE,
-               required: true,
-               description: 'Name of the cluster agent'
-    end
-  end
-end

ee/app/graphql/resolvers/clusters/agents_resolver.rb

@@ -5,14 +5,22 @@ module Resolvers
     class AgentsResolver < BaseResolver
       include LooksAhead
 
-      type Types::Clusters::AgentType, null: true
+      type Types::Clusters::AgentType.connection_type, null: true
+
+      extras [:lookahead]
+
+      when_single do
+        argument :name, GraphQL::STRING_TYPE,
+            required: true,
+            description: 'Name of the cluster agent'
+      end
 
       alias_method :project, :object
 
       def resolve_with_lookahead(**args)
         apply_lookahead(
           ::Clusters::AgentsFinder
-            .new(project, context[:current_user], params: args)
+            .new(project, current_user, params: args)
             .execute
         )
       end

ee/app/graphql/resolvers/epic_issues_resolver.rb

@@ -2,7 +2,7 @@
 
 module Resolvers
   class EpicIssuesResolver < BaseResolver
-    type Types::EpicIssueType, null: true
+    type Types::EpicIssueType.connection_type, null: true
 
     alias_method :epic, :object
 

ee/app/graphql/resolvers/requirements_management/requirements_resolver.rb

@@ -5,6 +5,8 @@ module Resolvers
     class RequirementsResolver < BaseResolver
       include LooksAhead
 
+      type ::Types::RequirementsManagement::RequirementType.connection_type, null: true
+
       argument :iid, GraphQL::ID_TYPE,
                required: false,
                description: 'IID of the requirement, e.g., "1"'
@@ -29,8 +31,6 @@ module Resolvers
                required: false,
                description: 'Filter requirements by author username'
 
-      type Types::RequirementsManagement::RequirementType, null: true
-
       def resolve_with_lookahead(**args)
         # The project could have been loaded in batch by `BatchLoader`.
         # At this point we need the `id` of the project to query for issues, so

ee/app/graphql/resolvers/timelog_resolver.rb

@@ -4,6 +4,8 @@ module Resolvers
   class TimelogResolver < BaseResolver
     include LooksAhead
 
+    type ::Types::TimelogType.connection_type, null: false
+
     argument :start_date, Types::TimeType,
               required: false,
               description: 'List time logs within a date range where the logged date is equal to or after startDate'

ee/spec/graphql/resolvers/clusters/agent_resolver_spec.rb

-# frozen_string_literal: true
-
-require 'spec_helper'
-
-RSpec.describe Resolvers::Clusters::AgentResolver do
-  it { expect(described_class).to be < Resolvers::Clusters::AgentsResolver }
-
-  describe 'arguments' do
-    subject { described_class.arguments[argument] }
-
-    describe 'name' do
-      let(:argument) { 'name' }
-
-      it do
-        expect(subject).to be_present
-        expect(subject.type.to_s).to eq('String!')
-        expect(subject.description).to be_present
-      end
-    end
-  end
-end

ee/spec/graphql/resolvers/clusters/agents_resolver_spec.rb

@@ -5,10 +5,13 @@ require 'spec_helper'
 RSpec.describe Resolvers::Clusters::AgentsResolver do
   include GraphqlHelpers
 
-  it { expect(described_class).to be < LooksAhead }
+  specify do
+    expect(described_class).to have_nullable_graphql_type(Types::Clusters::AgentType.connection_type)
+  end
 
-  it { expect(described_class.type).to eq(Types::Clusters::AgentType) }
-  it { expect(described_class.null).to be_truthy }
+  specify do
+    expect(described_class.field_options).to include(extras: include(:lookahead))
+  end
 
   describe '#resolve' do
     let_it_be(:user) { create(:user) }
@@ -38,3 +41,33 @@ RSpec.describe Resolvers::Clusters::AgentsResolver do
     end
   end
 end
+
+RSpec.describe Resolvers::Clusters::AgentsResolver.single do
+  it { expect(described_class).to be < Resolvers::Clusters::AgentsResolver }
+
+  describe '.field_options' do
+    subject { described_class.field_options }
+
+    specify do
+      expect(subject).to include(
+        type: ::Types::Clusters::AgentType,
+        null: true,
+        extras: [:lookahead]
+      )
+    end
+  end
+
+  describe 'arguments' do
+    subject { described_class.arguments[argument] }
+
+    describe 'name' do
+      let(:argument) { 'name' }
+
+      it do
+        expect(subject).to be_present
+        expect(subject.type.to_s).to eq('String!')
+        expect(subject.description).to be_present
+      end
+    end
+  end
+end

ee/spec/graphql/resolvers/epic_issues_resolver_spec.rb

@@ -21,6 +21,10 @@ RSpec.describe Resolvers::EpicIssuesResolver do
   let_it_be(:epic_issue3) { create(:epic_issue, epic: epic2, issue: issue3, relative_position: 1) }
   let_it_be(:epic_issue4) { create(:epic_issue, epic: epic2, issue: issue4, relative_position: nil) }
 
+  specify do
+    expect(described_class).to have_nullable_graphql_type(Types::EpicIssueType.connection_type)
+  end
+
   before do
     group.add_developer(current_user)
     stub_licensed_features(epics: true)

ee/spec/graphql/resolvers/requirements_management/requirements_resolver_spec.rb

@@ -10,6 +10,10 @@ RSpec.describe Resolvers::RequirementsManagement::RequirementsResolver do
   let_it_be(:third_user) { create(:user) }
   let_it_be(:project) { create(:project) }
 
+  specify do
+    expect(described_class).to have_nullable_graphql_type(::Types::RequirementsManagement::RequirementType.connection_type)
+  end
+
   context 'with a project' do
     let_it_be(:requirement1) { create(:requirement, project: project, state: :opened, created_at: 5.hours.ago, title: 'it needs to do the thing', author: current_user) }
     let_it_be(:requirement2) { create(:requirement, project: project, state: :archived, created_at: 3.hours.ago, title: 'it needs to not break', author: other_user) }

ee/spec/graphql/resolvers/timelog_resolver_spec.rb

@@ -5,6 +5,10 @@ require 'spec_helper'
 RSpec.describe Resolvers::TimelogResolver do
   include GraphqlHelpers
 
+  specify do
+    expect(described_class).to have_non_null_graphql_type(::Types::TimelogType.connection_type)
+  end
+
   context "within a group" do
     let_it_be(:current_user) { create(:user) }
     let(:group)              { create(:group) }

spec/graphql/resolvers/alert_management/integrations_resolver_spec.rb

@@ -14,6 +14,10 @@ RSpec.describe Resolvers::AlertManagement::IntegrationsResolver do
 
   subject { sync(resolve_http_integrations) }
 
+  specify do
+    expect(described_class).to have_nullable_graphql_type(Types::AlertManagement::IntegrationType.connection_type)
+  end
+
   context 'user does not have permission' do
     it { is_expected.to be_empty }
   end

spec/graphql/resolvers/base_resolver_spec.rb

@@ -7,10 +7,13 @@ RSpec.describe Resolvers::BaseResolver do
 
   let(:resolver) do
     Class.new(described_class) do
-      def resolve(**args)
+      argument :test, ::GraphQL::INT_TYPE, required: false
+      type [::GraphQL::INT_TYPE], null: true
+
+      def resolve(test: 100)
         process(object)
 
-        [args, args]
+        [test, test]
       end
 
       def process(obj); end
@@ -19,17 +22,75 @@ RSpec.describe Resolvers::BaseResolver do
 
   let(:last_resolver) do
     Class.new(described_class) do
+      type [::GraphQL::INT_TYPE], null: true
+
       def resolve(**args)
         [1, 2]
       end
     end
   end
 
+  describe '.singular_type' do
+    subject { resolver.singular_type }
+
+    context 'for a connection of scalars' do
+      let(:resolver) do
+        Class.new(described_class) do
+          type ::GraphQL::INT_TYPE.connection_type, null: true
+        end
+      end
+
+      it { is_expected.to eq(::GraphQL::INT_TYPE) }
+    end
+
+    context 'for a connection of objects' do
+      let(:object) do
+        Class.new(::Types::BaseObject) do
+          graphql_name 'Foo'
+        end
+      end
+
+      let(:resolver) do
+        conn = object.connection_type
+
+        Class.new(described_class) do
+          type conn, null: true
+        end
+      end
+
+      it { is_expected.to eq(object) }
+    end
+
+    context 'for a list type' do
+      let(:resolver) do
+        Class.new(described_class) do
+          type [::GraphQL::STRING_TYPE], null: true
+        end
+      end
+
+      it { is_expected.to eq(::GraphQL::STRING_TYPE) }
+    end
+
+    context 'for a scalar type' do
+      let(:resolver) do
+        Class.new(described_class) do
+          type ::GraphQL::BOOLEAN_TYPE, null: true
+        end
+      end
+
+      it { is_expected.to eq(::GraphQL::BOOLEAN_TYPE) }
+    end
+  end
+
   describe '.single' do
     it 'returns a subclass from the resolver' do
       expect(resolver.single.superclass).to eq(resolver)
     end
 
+    it 'has the correct (singular) type' do
+      expect(resolver.single.type).to eq(::GraphQL::INT_TYPE)
+    end
+
     it 'returns the same subclass every time' do
       expect(resolver.single.object_id).to eq(resolver.single.object_id)
     end
@@ -37,15 +98,106 @@ RSpec.describe Resolvers::BaseResolver do
     it 'returns a resolver that gives the first result from the original resolver' do
       result = resolve(resolver.single, args: { test: 1 })
 
-      expect(result).to eq(test: 1)
+      expect(result).to eq(1)
+    end
+  end
+
+  describe '.when_single' do
+    let(:resolver) do
+      Class.new(described_class) do
+        type [::GraphQL::INT_TYPE], null: true
+
+        when_single do
+          argument :foo, ::GraphQL::INT_TYPE, required: true
+        end
+
+        def resolve(foo: 1)
+          [foo * foo] # rubocop: disable Lint/BinaryOperatorWithIdenticalOperands
+        end
+      end
+    end
+
+    it 'does not apply the block to the resolver' do
+      expect(resolver.field_options).to include(
+        arguments: be_empty
+      )
+      result = resolve(resolver)
+
+      expect(result).to eq([1])
+    end
+
+    it 'applies the block to the single version of the resolver' do
+      expect(resolver.single.field_options).to include(
+        arguments: match('foo' => an_instance_of(::Types::BaseArgument))
+      )
+      result = resolve(resolver.single, args: { foo: 7 })
+
+      expect(result).to eq(49)
+    end
+
+    context 'multiple when_single blocks' do
+      let(:resolver) do
+        Class.new(described_class) do
+          type [::GraphQL::INT_TYPE], null: true
+
+          when_single do
+            argument :foo, ::GraphQL::INT_TYPE, required: true
+          end
+
+          when_single do
+            argument :bar, ::GraphQL::INT_TYPE, required: true
+          end
+
+          def resolve(foo: 1, bar: 2)
+            [foo * bar]
+          end
+        end
+      end
+
+      it 'applies both blocks to the single version of the resolver' do
+        expect(resolver.single.field_options).to include(
+          arguments: match('foo' => ::Types::BaseArgument, 'bar' => ::Types::BaseArgument)
+        )
+        result = resolve(resolver.single, args: { foo: 7, bar: 5 })
+
+        expect(result).to eq(35)
+      end
+    end
+
+    context 'inheritance' do
+      let(:subclass) do
+        Class.new(resolver) do
+          when_single do
+            argument :inc, ::GraphQL::INT_TYPE, required: true
+          end
+
+          def resolve(foo:, inc:)
+            super(foo: foo + inc)
+          end
+        end
+      end
+
+      it 'applies both blocks to the single version of the resolver' do
+        expect(resolver.single.field_options).to include(
+          arguments: match('foo' => ::Types::BaseArgument)
+        )
+        expect(subclass.single.field_options).to include(
+          arguments: match('foo' => ::Types::BaseArgument, 'inc' => ::Types::BaseArgument)
+        )
+        result = resolve(subclass.single, args: { foo: 7, inc: 1 })
+
+        expect(result).to eq(64)
+      end
     end
   end
 
   context 'when the resolver returns early' do
     let(:resolver) do
       Class.new(described_class) do
+        type [::GraphQL::STRING_TYPE], null: true
+
         def ready?(**args)
-          [false, %w(early return)]
+          [false, %w[early return]]
         end
 
         def resolve(**args)
@@ -121,28 +273,4 @@ RSpec.describe Resolvers::BaseResolver do
       end
     end
   end
-
-  describe '#synchronized_object' do
-    let(:object) { double(foo: :the_foo) }
-
-    let(:resolver) do
-      Class.new(described_class) do
-        def resolve(**args)
-          [synchronized_object.foo]
-        end
-      end
-    end
-
-    it 'handles raw objects' do
-      expect(resolve(resolver, obj: object)).to contain_exactly(:the_foo)
-    end
-
-    it 'handles lazy objects' do
-      delayed = BatchLoader::GraphQL.for(1).batch do |_, loader|
-        loader.call(1, object)
-      end
-
-      expect(resolve(resolver, obj: delayed)).to contain_exactly(:the_foo)
-    end
-  end
 end

spec/graphql/resolvers/design_management/design_resolver_spec.rb

@@ -6,6 +6,10 @@ RSpec.describe Resolvers::DesignManagement::DesignResolver do
   include GraphqlHelpers
   include DesignManagementTestHelpers
 
+  specify do
+    expect(described_class).to have_nullable_graphql_type(::Types::DesignManagement::DesignType)
+  end
+
   before do
     enable_design_management
   end

spec/graphql/resolvers/design_management/designs_resolver_spec.rb

@@ -6,6 +6,10 @@ RSpec.describe Resolvers::DesignManagement::DesignsResolver do
   include GraphqlHelpers
   include DesignManagementTestHelpers
 
+  specify do
+    expect(described_class).to have_nullable_graphql_type(::Types::DesignManagement::DesignType.connection_type)
+  end
+
   before do
     enable_design_management
   end

spec/graphql/resolvers/echo_resolver_spec.rb

@@ -9,10 +9,7 @@ RSpec.describe Resolvers::EchoResolver do
   let(:text) { 'Message test' }
 
   specify do
-    expect(described_class.field_options).to include(
-      type: eq(::GraphQL::STRING_TYPE),
-      null: be_falsey
-    )
+    expect(described_class).to have_non_null_graphql_type(::GraphQL::STRING_TYPE)
   end
 
   describe '#resolve' do

spec/graphql/resolvers/error_tracking/sentry_detailed_error_resolver_spec.rb

@@ -10,6 +10,10 @@ RSpec.describe Resolvers::ErrorTracking::SentryDetailedErrorResolver do
 
   let(:issue_details_service) { spy('ErrorTracking::IssueDetailsService') }
 
+  specify do
+    expect(described_class).to have_nullable_graphql_type(Types::ErrorTracking::SentryDetailedErrorType)
+  end
+
   before do
     project.add_developer(current_user)
 

spec/graphql/resolvers/error_tracking/sentry_error_collection_resolver_spec.rb

@@ -10,6 +10,10 @@ RSpec.describe Resolvers::ErrorTracking::SentryErrorCollectionResolver do
 
   let(:list_issues_service) { spy('ErrorTracking::ListIssuesService') }
 
+  specify do
+    expect(described_class).to have_nullable_graphql_type(Types::ErrorTracking::SentryErrorCollectionType)
+  end
+
   before do
     project.add_developer(current_user)
 

spec/graphql/resolvers/error_tracking/sentry_errors_resolver_spec.rb

@@ -14,6 +14,10 @@ RSpec.describe Resolvers::ErrorTracking::SentryErrorsResolver do
   let(:issues) { nil }
   let(:pagination) { nil }
 
+  specify do
+    expect(described_class).to have_nullable_graphql_type(Types::ErrorTracking::SentryErrorType.connection_type)
+  end
+
   describe '#resolve' do
     context 'insufficient user permission' do
       let(:user) { create(:user) }

spec/graphql/resolvers/group_members_resolver_spec.rb

@@ -5,6 +5,10 @@ require 'spec_helper'
 RSpec.describe Resolvers::GroupMembersResolver do
   include GraphqlHelpers
 
+  specify do
+    expect(described_class).to have_nullable_graphql_type(Types::GroupMemberType.connection_type)
+  end
+
   it_behaves_like 'querying members with a group' do
     let_it_be(:resource_member) { create(:group_member, user: user_1, group: group_1) }
     let_it_be(:resource) { group_1 }

spec/graphql/resolvers/issues_resolver_spec.rb

@@ -20,6 +20,10 @@ RSpec.describe Resolvers::IssuesResolver do
   let_it_be(:label1)    { create(:label, project: project) }
   let_it_be(:label2)    { create(:label, project: project) }
 
+  specify do
+    expect(described_class).to have_nullable_graphql_type(Types::IssueType.connection_type)
+  end
+
   context "with a project" do
     before do
       project.add_developer(current_user)

spec/graphql/resolvers/project_pipeline_resolver_spec.rb

@@ -10,6 +10,10 @@ RSpec.describe Resolvers::ProjectPipelineResolver do
   let_it_be(:other_pipeline) { create(:ci_pipeline) }
   let(:current_user) { create(:user) }
 
+  specify do
+    expect(described_class).to have_nullable_graphql_type(::Types::Ci::PipelineType)
+  end
+
   def resolve_pipeline(project, args)
     resolve(described_class, obj: project, args: args, ctx: { current_user: current_user })
   end

spec/graphql/resolvers/projects/jira_imports_resolver_spec.rb

@@ -5,6 +5,10 @@ require 'spec_helper'
 RSpec.describe Resolvers::Projects::JiraImportsResolver do
   include GraphqlHelpers
 
+  specify do
+    expect(described_class).to have_nullable_graphql_type(Types::JiraImportType.connection_type)
+  end
+
   describe '#resolve' do
     let_it_be(:user) { create(:user) }
     let_it_be(:project, reload: true) { create(:project, :public) }

spec/graphql/resolvers/projects/jira_projects_resolver_spec.rb

@@ -5,6 +5,10 @@ require 'spec_helper'
 RSpec.describe Resolvers::Projects::JiraProjectsResolver do
   include GraphqlHelpers
 
+  specify do
+    expect(described_class).to have_nullable_graphql_type(Types::Projects::Services::JiraProjectType.connection_type)
+  end
+
   describe '#resolve' do
     let_it_be(:user) { create(:user) }
     let_it_be(:project) { create(:project) }

spec/graphql/resolvers/projects/services_resolver_spec.rb

@@ -5,6 +5,10 @@ require 'spec_helper'
 RSpec.describe Resolvers::Projects::ServicesResolver do
   include GraphqlHelpers
 
+  specify do
+    expect(described_class).to have_nullable_graphql_type(Types::Projects::ServiceType.connection_type)
+  end
+
   describe '#resolve' do
     let_it_be(:user) { create(:user) }
 

spec/graphql/resolvers/snippets/blobs_resolver_spec.rb

@@ -5,6 +5,10 @@ require 'spec_helper'
 RSpec.describe Resolvers::Snippets::BlobsResolver do
   include GraphqlHelpers
 
+  specify do
+    expect(described_class).to have_nullable_graphql_type(Types::Snippets::BlobType.connection_type)
+  end
+
   describe '#resolve' do
     let_it_be(:current_user) { create(:user) }
     let_it_be(:snippet) { create(:personal_snippet, :private, :repository, author: current_user) }

spec/graphql/resolvers/todo_resolver_spec.rb

@@ -5,6 +5,10 @@ require 'spec_helper'
 RSpec.describe Resolvers::TodoResolver do
   include GraphqlHelpers
 
+  specify do
+    expect(described_class).to have_nullable_graphql_type(Types::TodoType.connection_type)
+  end
+
   describe '#resolve' do
     let_it_be(:current_user) { create(:user) }
     let_it_be(:author1) { create(:user) }

spec/graphql/resolvers/tree_resolver_spec.rb

@@ -7,6 +7,10 @@ RSpec.describe Resolvers::TreeResolver do
 
   let(:repository) { create(:project, :repository).repository }
 
+  specify do
+    expect(described_class).to have_nullable_graphql_type(Types::Tree::TreeType)
+  end
+
   describe '#resolve' do
     it 'resolves to a tree' do
       result = resolve_repository({ ref: "master" })

spec/graphql/resolvers/users_resolver_spec.rb

@@ -8,6 +8,10 @@ RSpec.describe Resolvers::UsersResolver do
   let_it_be(:user1) { create(:user, name: "SomePerson") }
   let_it_be(:user2) { create(:user, username: "someone123784") }
 
+  specify do
+    expect(described_class).to have_nullable_graphql_type(Types::UserType.connection_type)
+  end
+
   describe '#resolve' do
     it 'raises an error when read_users_list is not authorized' do
       expect(Ability).to receive(:allowed?).with(nil, :read_users_list).and_return(false)

spec/support/matchers/graphql_matchers.rb

@@ -109,15 +109,82 @@ RSpec::Matchers.define :have_graphql_arguments do |*expected|
   end
 end
 
-RSpec::Matchers.define :have_graphql_type do |expected|
-  match do |field|
-    expect(field.type).to eq(expected)
+module GraphQLTypeHelpers
+  def message(object, expected, **opts)
+    non_null = expected.non_null? || (opts.key?(:null) && !opts[:null])
+
+    actual = object.type
+    actual_type = actual.unwrap.graphql_name
+    actual_type += '!' if actual.non_null?
+
+    expected_type = expected.unwrap.graphql_name
+    expected_type += '!' if non_null
+
+    "expected #{describe_object(object)} to have GraphQL type #{expected_type}, but got #{actual_type}"
+  end
+
+  def describe_object(object)
+    case object
+    when Types::BaseField
+      "#{describe_object(object.owner_type)}.#{object.graphql_name}"
+    when Types::BaseArgument
+      "#{describe_object(object.owner)}.#{object.graphql_name}"
+    when Class
+      object.try(:graphql_name) || object.name
+    else
+      object.to_s
+    end
+  end
+
+  def nullified(type, can_be_nil)
+    return type if can_be_nil.nil? # unknown!
+    return type if can_be_nil
+
+    type.to_non_null_type
+  end
+end
+
+RSpec::Matchers.define :have_graphql_type do |expected, opts = {}|
+  include GraphQLTypeHelpers
+
+  match do |object|
+    expect(object.type).to eq(nullified(expected, opts[:null]))
+  end
+
+  failure_message do |object|
+    message(object, expected, **opts)
+  end
+end
+
+RSpec::Matchers.define :have_nullable_graphql_type do |expected|
+  include GraphQLTypeHelpers
+
+  match do |object|
+    expect(object).to have_graphql_type(expected.unwrap, { null: true })
+  end
+
+  description do
+    "have nullable GraphQL type #{expected.graphql_name}"
+  end
+
+  failure_message do |object|
+    message(object, expected, null: true)
   end
 end
 
 RSpec::Matchers.define :have_non_null_graphql_type do |expected|
-  match do |field|
-    expect(field.type.to_graphql).to eq(!expected.to_graphql)
+  include GraphQLTypeHelpers
+
+  match do |object|
+    expect(object).to have_graphql_type(expected, { null: false })
+  end
+
+  description do
+    "have non-null GraphQL type #{expected.graphql_name}"
+  end
+
+  failure_message do |object|
+    message(object, expected, null: false)
   end
 end