Merge branch 'deprecated-delete-all-params' into 'master'

Fix deprecation: Passing conditions to delete_all is deprecated

See merge request gitlab-org/gitlab-ce!23817

changelogs/unreleased/deprecated-delete-all-params.yml

+---
+title: 'Fix deprecation: Passing conditions to delete_all is deprecated'
+merge_request: 23817
+author: Jasper Maes
+type: other

spec/models/merge_request_diff_spec.rb

@@ -105,7 +105,7 @@ describe MergeRequestDiff do
 
     context 'when the raw diffs are empty' do
       before do
-        MergeRequestDiffFile.delete_all(merge_request_diff_id: diff_with_commits.id)
+        MergeRequestDiffFile.where(merge_request_diff_id: diff_with_commits.id).delete_all
       end
 
       it 'returns an empty DiffCollection' do