Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
30f302d2
Commit
30f302d2
authored
Aug 22, 2019
by
Robert Schilling
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Don't check external authorization when disabling the service
parent
842b4d4a
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
7 additions
and
1 deletion
+7
-1
app/services/application_settings/update_service.rb
app/services/application_settings/update_service.rb
+2
-1
changelogs/unreleased/66443-unrecoverable-configuration-loop-in-external-auth-control.yml
...coverable-configuration-loop-in-external-auth-control.yml
+5
-0
No files found.
app/services/application_settings/update_service.rb
View file @
30f302d2
...
...
@@ -7,7 +7,8 @@ module ApplicationSettings
attr_reader
:params
,
:application_setting
def
execute
validate_classification_label
(
application_setting
,
:external_authorization_service_default_label
)
disable_ext_auth
=
params
[
:external_authorization_service_enabled
].
present?
&&
!
Gitlab
::
Utils
.
to_boolean
(
params
[
:external_authorization_service_enabled
])
validate_classification_label
(
application_setting
,
:external_authorization_service_default_label
)
unless
disable_ext_auth
if
application_setting
.
errors
.
any?
return
false
...
...
changelogs/unreleased/66443-unrecoverable-configuration-loop-in-external-auth-control.yml
0 → 100644
View file @
30f302d2
---
title
:
Don't check external authorization when disabling the service
merge_request
:
32102
author
:
Robert Schilling
type
:
fixed
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment