Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
31965622
Commit
31965622
authored
Oct 15, 2020
by
Anastasia McDonald
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Avoid flakiness by introducing more conditional waiting
See
https://gitlab.com/gitlab-org/gitlab/-/issues/267508
parent
4149a6d4
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
3 additions
and
0 deletions
+3
-0
qa/qa/page/component/snippet.rb
qa/qa/page/component/snippet.rb
+3
-0
No files found.
qa/qa/page/component/snippet.rb
View file @
31965622
...
...
@@ -170,6 +170,7 @@ module QA
def
add_comment
(
comment
)
fill_element
(
:note_field
,
comment
)
click_element
(
:comment_button
)
wait_until
(
reload:
false
)
{
has_element?
(
:note_author_content
)
}
end
def
has_comment_author?
(
author_username
)
...
...
@@ -194,6 +195,7 @@ module QA
click_element
(
:edit_comment_button
)
fill_element
(
:edit_note_field
,
comment
)
click_element
(
:save_comment_button
)
wait_until
(
reload:
false
)
{
has_element?
(
:note_author_content
)
}
end
def
delete_comment
(
comment
)
...
...
@@ -201,6 +203,7 @@ module QA
accept_alert
do
click_element
(
:delete_comment_button
)
end
wait_until
(
reload:
false
)
{
has_no_text?
(
comment
)
}
end
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment