Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
32d03bfe
Commit
32d03bfe
authored
Jun 24, 2020
by
Thiago Figueiró
Committed by
Marcia Ramos
Jun 24, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Automate code style reviews
parent
5c463a05
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
6 additions
and
3 deletions
+6
-3
doc/development/code_review.md
doc/development/code_review.md
+6
-3
No files found.
doc/development/code_review.md
View file @
32d03bfe
...
@@ -386,9 +386,12 @@ author.
...
@@ -386,9 +386,12 @@ author.
-
Learning how to find the right balance takes time; that is why we have
-
Learning how to find the right balance takes time; that is why we have
reviewers that become maintainers after some time spent on reviewing merge
reviewers that become maintainers after some time spent on reviewing merge
requests.
requests.
-
Finding bugs and improving code style is important, but thinking about good
-
Finding bugs is important, but thinking about good design is important as
design is important as well. Building abstractions and good design is what
well. Building abstractions and good design is what makes it possible to hide
makes it possible to hide complexity and makes future changes easier.
complexity and makes future changes easier.
-
Enforcing and improving
[
code style
](
contributing/style_guides.md
)
should be primarily done through
[
automation
](
https://about.gitlab.com/handbook/values/#cleanup-over-sign-off
)
instead of review comments.
-
Asking the author to change the design sometimes means the complete rewrite
-
Asking the author to change the design sometimes means the complete rewrite
of the contributed code. It's usually a good idea to ask another maintainer or
of the contributed code. It's usually a good idea to ask another maintainer or
reviewer before doing it, but have the courage to do it when you believe it is
reviewer before doing it, but have the courage to do it when you believe it is
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment