Merge branch 'ee-dispatcher-cycle-analytics' into 'master'

Remove cycle analytics bundle webpack entry point (EE)

See merge request gitlab-org/gitlab-ee!4756

app/assets/javascripts/cycle_analytics/cycle_analytics_bundle.js

@@ -14,10 +14,10 @@ import CycleAnalyticsStore from './cycle_analytics_store';
 
 Vue.use(Translate);
 
-$(() => {
+export default () => {
   const OVERVIEW_DIALOG_COOKIE = 'cycle_analytics_help_dismissed';
 
-  gl.cycleAnalyticsApp = new Vue({
+  new Vue({ // eslint-disable-line no-new
     el: '#cycle-analytics',
     name: 'CycleAnalytics',
     components: {
@@ -132,4 +132,4 @@ $(() => {
       },
     },
   });
-});
+};

app/assets/javascripts/pages/projects/cycle_analytics/show/index.js

+import initCycleAnalytics from '~/cycle_analytics/cycle_analytics_bundle';
+
+document.addEventListener('DOMContentLoaded', initCycleAnalytics);

app/views/projects/cycle_analytics/show.html.haml

@@ -2,7 +2,6 @@
 - page_title "Cycle Analytics"
 - content_for :page_specific_javascripts do
   = webpack_bundle_tag('common_vue')
-  = webpack_bundle_tag('cycle_analytics')
 
 #cycle-analytics{ class: container_class, "v-cloak" => "true", data: { request_path: project_cycle_analytics_path(@project) } }
   - if @cycle_analytics_no_data

config/webpack.config.js

@@ -49,7 +49,6 @@ function generateEntries() {
 
   const manualEntries = {
     balsamiq_viewer:      './blob/balsamiq_viewer.js',
-    cycle_analytics:      './cycle_analytics/cycle_analytics_bundle.js',
     environments:         './environments/environments_bundle.js',
     filtered_search:      './filtered_search/filtered_search_bundle.js',
     help:                 './help/help.js',
@@ -68,7 +67,6 @@ function generateEntries() {
     ui_development_kit:   './ui_development_kit.js',
     two_factor_auth:      './two_factor_auth.js',
 
-
     common:               './commons/index.js',
     common_vue:           './vue_shared/vue_resource_interceptor.js',
     locale:               './locale/index.js',
@@ -255,7 +253,6 @@ var config = {
       name: 'common_vue',
       chunks: [
         'boards',
-        'cycle_analytics',
         'deploy_keys',
         'environments',
         'filtered_search',