Commit 348d09b1 authored by Sean McGivern's avatar Sean McGivern

Merge branch 'vkarnes-add-ux-review' into 'master'

Add UX Review to Definition of Done

See merge request gitlab-org/gitlab!19879
parents 76f97a52 06448b8a
...@@ -69,7 +69,7 @@ request is as follows: ...@@ -69,7 +69,7 @@ request is as follows:
the issue(s) once the merge request is merged. the issue(s) once the merge request is merged.
1. If you're allowed to (Core team members, for example), set a relevant milestone 1. If you're allowed to (Core team members, for example), set a relevant milestone
and [labels](issue_workflow.md). and [labels](issue_workflow.md).
1. If the MR changes the UI, it should include *Before* and *After* screenshots. 1. If the MR changes the UI, you'll need approval from a Product Designer (UX), based on the appropriate [product category](https://about.gitlab.com/handbook/product/categories/). UI changes should use available components from the GitLab Design System, [Pajamas](https://design.gitlab.com/). The MR must include *Before* and *After* screenshots.
1. If the MR changes CSS classes, please include the list of affected pages, which 1. If the MR changes CSS classes, please include the list of affected pages, which
can be found by running `grep css-class ./app -R`. can be found by running `grep css-class ./app -R`.
1. Be prepared to answer questions and incorporate feedback into your MR with new 1. Be prepared to answer questions and incorporate feedback into your MR with new
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment