Merge branch 'cngo-fix-incorrect-usages-of-create-flash' into 'master'

Fix incorrect usages of createFlash

See merge request gitlab-org/gitlab!46883

app/assets/javascripts/issue_show/components/header_actions.vue

@@ -81,7 +81,7 @@ export default {
         })
         .then(({ data }) => {
           if (data.updateIssue.errors.length) {
-            createFlash(data.updateIssue.errors.join('. '));
+            createFlash({ message: data.updateIssue.errors.join('. ') });
             return;
           }
 
@@ -95,7 +95,7 @@ export default {
           // Dispatch event which updates open/close state, shared among the issue show page
           document.dispatchEvent(new CustomEvent('issuable_vue_app:change', payload));
         })
-        .catch(() => createFlash(__('Update failed. Please try again.')))
+        .catch(() => createFlash({ message: __('Update failed. Please try again.') }))
         .finally(() => {
           this.isUpdatingState = false;
         });

app/assets/javascripts/pages/projects/ci/lints/new/index.js

@@ -7,11 +7,11 @@ document.addEventListener('DOMContentLoaded', () => {
   if (gon?.features?.ciLintVue) {
     import(/* webpackChunkName: 'ciLintIndex' */ '~/ci_lint/index')
       .then(module => module.default())
-      .catch(() => createFlash(ERROR));
+      .catch(() => createFlash({ message: ERROR }));
   } else {
     import(/* webpackChunkName: 'ciLintEditor' */ '../ci_lint_editor')
       // eslint-disable-next-line new-cap
       .then(module => new module.default())
-      .catch(() => createFlash(ERROR));
+      .catch(() => createFlash({ message: ERROR }));
   }
 });

app/assets/javascripts/pages/projects/ci/lints/show/index.js

@@ -7,11 +7,11 @@ document.addEventListener('DOMContentLoaded', () => {
   if (gon?.features?.ciLintVue) {
     import(/* webpackChunkName: 'ciLintIndex' */ '~/ci_lint/index')
       .then(module => module.default())
-      .catch(() => createFlash(ERROR));
+      .catch(() => createFlash({ message: ERROR }));
   } else {
     import(/* webpackChunkName: 'ciLintEditor' */ '../ci_lint_editor')
       // eslint-disable-next-line new-cap
       .then(module => new module.default())
-      .catch(() => createFlash(ERROR));
+      .catch(() => createFlash({ message: ERROR }));
   }
 });

app/assets/javascripts/pages/projects/commit/show/index.js

@@ -40,7 +40,7 @@ document.addEventListener('DOMContentLoaded', () => {
         new Diff();
       })
       .catch(() => {
-        flash(__('An error occurred while retrieving diff files'));
+        flash({ message: __('An error occurred while retrieving diff files') });
       });
   } else {
     new Diff();

app/assets/javascripts/vue_shared/components/filtered_search_bar/tokens/milestone_token.vue

@@ -65,7 +65,7 @@ export default {
         .then(({ data }) => {
           this.milestones = data;
         })
-        .catch(() => createFlash(__('There was a problem fetching milestones.')))
+        .catch(() => createFlash({ message: __('There was a problem fetching milestones.') }))
         .finally(() => {
           this.loading = false;
         });

spec/frontend/vue_shared/components/filtered_search_bar/tokens/milestone_token_spec.js

@@ -120,7 +120,9 @@ describe('MilestoneToken', () => {
         wrapper.vm.fetchMilestoneBySearchTerm('foo');
 
         return waitForPromises().then(() => {
-          expect(createFlash).toHaveBeenCalledWith('There was a problem fetching milestones.');
+          expect(createFlash).toHaveBeenCalledWith({
+            message: 'There was a problem fetching milestones.',
+          });
         });
       });