Rename Gitlab::Importers module

In order to avoid confusion between Gitlab::Importers module and other
like named modules, this renamed it to Gitlab::DatabaseImporters.

db/fixtures/development/99_common_metrics.rb

 # frozen_string_literal: true
 
-::Gitlab::Importers::CommonMetrics::Importer.new.execute
+::Gitlab::DatabaseImporters::CommonMetrics::Importer.new.execute

db/fixtures/production/999_common_metrics.rb

 # frozen_string_literal: true
 
-::Gitlab::Importers::CommonMetrics::Importer.new.execute
+::Gitlab::DatabaseImporters::CommonMetrics::Importer.new.execute

db/migrate/20180831164910_import_common_metrics.rb

@@ -6,7 +6,7 @@ class ImportCommonMetrics < ActiveRecord::Migration[4.2]
   DOWNTIME = false
 
   def up
-    ::Gitlab::Importers::CommonMetrics::Importer.new.execute
+    ::Gitlab::DatabaseImporters::CommonMetrics::Importer.new.execute
   end
 
   def down

db/migrate/20181006004100_import_common_metrics_nginx_vts.rb

@@ -4,7 +4,7 @@ class ImportCommonMetricsNginxVts < ActiveRecord::Migration[5.0]
   DOWNTIME = false
 
   def up
-    ::Gitlab::Importers::CommonMetrics::Importer.new.execute
+    ::Gitlab::DatabaseImporters::CommonMetrics::Importer.new.execute
   end
 
   def down

db/migrate/20190326164045_import_common_metrics_knative.rb

@@ -6,7 +6,7 @@ class ImportCommonMetricsKnative < ActiveRecord::Migration[5.0]
   DOWNTIME = false
 
   def up
-    ::Gitlab::Importers::CommonMetrics::Importer.new.execute
+    ::Gitlab::DatabaseImporters::CommonMetrics::Importer.new.execute
   end
 
   def down

db/migrate/20190408163745_prometheus_knative05_fix.rb

@@ -9,7 +9,7 @@ class PrometheusKnative05Fix < ActiveRecord::Migration[5.0]
   DOWNTIME = false
 
   def up
-    ::Gitlab::Importers::CommonMetrics::Importer.new.execute
+    ::Gitlab::DatabaseImporters::CommonMetrics::Importer.new.execute
   end
 
   def down

doc/development/prometheus_metrics.md

@@ -36,7 +36,7 @@ class ImportCommonMetrics < ActiveRecord::Migration[4.2]
   DOWNTIME = false
 
   def up
-    ::Gitlab::Importers::CommonMetrics::Importer.new.execute
+    ::Gitlab::DatabaseImporters::CommonMetrics::Importer.new.execute
   end
 
   def down

ee/lib/ee/gitlab/importers/common_metrics/prometheus_metric_enums.rb → ee/lib/ee/gitlab/database_importers/common_metrics/prometheus_metric_enums.rb

@@ -2,7 +2,7 @@
 
 module EE
   module Gitlab
-    module Importers
+    module DatabaseImporters
       module CommonMetrics
         module PrometheusMetricEnums
           extend ActiveSupport::Concern

lib/gitlab/importers/common_metrics.rb → lib/gitlab/database_importers/common_metrics.rb

 # frozen_string_literal: true
 
 module Gitlab
-  module Importers
+  module DatabaseImporters
     module CommonMetrics
     end
   end
 end
 
-Gitlab::Importers::CommonMetrics.prepend(EE::Gitlab::Importers::CommonMetrics)
+Gitlab::DatabaseImporters::CommonMetrics.prepend(EE::Gitlab::DatabaseImporters::CommonMetrics)

lib/gitlab/importers/common_metrics/importer.rb → lib/gitlab/database_importers/common_metrics/importer.rb

 # frozen_string_literal: true
 
 module Gitlab
-  module Importers
+  module DatabaseImporters
     module CommonMetrics
       class Importer
         MissingQueryId = Class.new(StandardError)
@@ -58,14 +58,12 @@ module Gitlab
           yield(metric_details['id'], attributes)
         end
 
-        # rubocop: disable CodeReuse/ActiveRecord
         def find_or_build_metric!(id)
           raise MissingQueryId unless id
 
           CommonMetrics::PrometheusMetric.common.find_by(identifier: id) ||
             CommonMetrics::PrometheusMetric.new(common: true, identifier: id)
         end
-        # rubocop: enable CodeReuse/ActiveRecord
 
         def find_group_title_key(title)
           CommonMetrics::PrometheusMetricEnums.groups[find_group_title(title)]

lib/gitlab/importers/common_metrics/prometheus_metric.rb → lib/gitlab/database_importers/common_metrics/prometheus_metric.rb

 # frozen_string_literal: true
 
 module Gitlab
-  module Importers
+  module DatabaseImporters
     module CommonMetrics
       class PrometheusMetric < ApplicationRecord
         enum group: PrometheusMetricEnums.groups

lib/gitlab/importers/common_metrics/prometheus_metric_enums.rb → lib/gitlab/database_importers/common_metrics/prometheus_metric_enums.rb

 # frozen_string_literal: true
 
 module Gitlab
-  module Importers
+  module DatabaseImporters
     module CommonMetrics
       module PrometheusMetricEnums
         def self.groups
@@ -39,4 +39,4 @@ module Gitlab
   end
 end
 
-::Gitlab::Importers::CommonMetrics::PrometheusMetricEnums.prepend EE::Gitlab::Importers::CommonMetrics::PrometheusMetricEnums
+::Gitlab::DatabaseImporters::CommonMetrics::PrometheusMetricEnums.prepend EE::Gitlab::DatabaseImporters::CommonMetrics::PrometheusMetricEnums

spec/lib/gitlab/importers/common_metrics/importer_spec.rb → spec/lib/gitlab/database_importers/common_metrics/importer_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rails_helper'
 
-describe Gitlab::Importers::CommonMetrics::Importer do
+describe Gitlab::DatabaseImporters::CommonMetrics::Importer do
   subject { described_class.new }
 
   context "does import common_metrics.yml" do
@@ -87,7 +87,7 @@ describe Gitlab::Importers::CommonMetrics::Importer do
       let(:query_identifier) { }
 
       it 'raises exception' do
-        expect { subject.execute }.to raise_error(Gitlab::Importers::CommonMetrics::Importer::MissingQueryId)
+        expect { subject.execute }.to raise_error(Gitlab::DatabaseImporters::CommonMetrics::Importer::MissingQueryId)
       end
     end
 

spec/lib/gitlab/importers/common_metrics/prometheus_metric_spec.rb → spec/lib/gitlab/database_importers/common_metrics/prometheus_metric_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rails_helper'
 
-describe Gitlab::Importers::CommonMetrics::PrometheusMetric do
+describe Gitlab::DatabaseImporters::CommonMetrics::PrometheusMetric do
   let(:existing_group_titles) do
     ::PrometheusMetricEnums.group_details.each_with_object({}) do |(key, value), memo|
       memo[key] = value[:group_title]
@@ -14,6 +14,6 @@ describe Gitlab::Importers::CommonMetrics::PrometheusMetric do
   end
 
   it '.group_titles equals ::PrometheusMetric' do
-    expect(Gitlab::Importers::CommonMetrics::PrometheusMetricEnums.group_titles).to eq(existing_group_titles)
+    expect(Gitlab::DatabaseImporters::CommonMetrics::PrometheusMetricEnums.group_titles).to eq(existing_group_titles)
   end
 end