Commit 3655824d authored by David O'Regan's avatar David O'Regan Committed by Phil Hughes

Track usage of merge request file header buttons

parent 0e9211ac
...@@ -210,6 +210,9 @@ export default { ...@@ -210,6 +210,9 @@ export default {
:text="diffFile.file_path" :text="diffFile.file_path"
:gfm="gfmCopyText" :gfm="gfmCopyText"
css-class="btn-default btn-transparent btn-clipboard" css-class="btn-default btn-transparent btn-clipboard"
data-track-event="click_copy_file_button"
data-track-label="diff_copy_file_path_button"
data-track-property="diff_copy_file"
/> />
<small v-if="isModeChanged" ref="fileMode" class="mr-1"> <small v-if="isModeChanged" ref="fileMode" class="mr-1">
...@@ -233,6 +236,9 @@ export default { ...@@ -233,6 +236,9 @@ export default {
:class="{ active: diffHasExpandedDiscussions(diffFile) }" :class="{ active: diffHasExpandedDiscussions(diffFile) }"
class="js-btn-vue-toggle-comments btn" class="js-btn-vue-toggle-comments btn"
data-qa-selector="toggle_comments_button" data-qa-selector="toggle_comments_button"
data-track-event="click_toggle_comments_button"
data-track-label="diff_toggle_comments_button"
data-track-property="diff_toggle_comments"
type="button" type="button"
@click="toggleFileDiscussionWrappers(diffFile)" @click="toggleFileDiscussionWrappers(diffFile)"
> >
...@@ -245,6 +251,9 @@ export default { ...@@ -245,6 +251,9 @@ export default {
:can-current-user-fork="canCurrentUserFork" :can-current-user-fork="canCurrentUserFork"
:edit-path="diffFile.edit_path" :edit-path="diffFile.edit_path"
:can-modify-blob="diffFile.can_modify_blob" :can-modify-blob="diffFile.can_modify_blob"
data-track-event="click_toggle_edit_button"
data-track-label="diff_toggle_edit_button"
data-track-property="diff_toggle_edit"
@showForkMessage="showForkMessage" @showForkMessage="showForkMessage"
/> />
</template> </template>
...@@ -263,6 +272,9 @@ export default { ...@@ -263,6 +272,9 @@ export default {
v-gl-tooltip.hover v-gl-tooltip.hover
:title="expandDiffToFullFileTitle" :title="expandDiffToFullFileTitle"
class="expand-file" class="expand-file"
data-track-event="click_toggle_view_full_button"
data-track-label="diff_toggle_view_full_button"
data-track-property="diff_toggle_view_full"
@click="toggleFullDiff(diffFile.file_path)" @click="toggleFullDiff(diffFile.file_path)"
> >
<gl-loading-icon v-if="diffFile.isLoadingFullFile" color="dark" inline /> <gl-loading-icon v-if="diffFile.isLoadingFullFile" color="dark" inline />
...@@ -275,6 +287,9 @@ export default { ...@@ -275,6 +287,9 @@ export default {
:href="diffFile.view_path" :href="diffFile.view_path"
target="blank" target="blank"
class="view-file" class="view-file"
data-track-event="click_toggle_view_sha_button"
data-track-label="diff_toggle_view_sha_button"
data-track-property="diff_toggle_view_sha"
:title="viewFileButtonText" :title="viewFileButtonText"
> >
<icon name="doc-text" /> <icon name="doc-text" />
...@@ -288,6 +303,9 @@ export default { ...@@ -288,6 +303,9 @@ export default {
:title="`View on ${diffFile.formatted_external_url}`" :title="`View on ${diffFile.formatted_external_url}`"
target="_blank" target="_blank"
rel="noopener noreferrer" rel="noopener noreferrer"
data-track-event="click_toggle_external_button"
data-track-label="diff_toggle_external_button"
data-track-property="diff_toggle_external"
class="btn btn-file-option" class="btn btn-file-option"
> >
<icon name="external-link" /> <icon name="external-link" />
......
---
title: Track usage of merge request file header buttons
merge_request:
author: Oregand
type: other
import Vue from 'vue'; import Vue from 'vue';
import { createStore } from 'ee_else_ce/mr_notes/stores'; import { createStore } from 'ee_else_ce/mr_notes/stores';
import { createComponentWithStore } from 'spec/helpers/vue_mount_component_helper'; import { createComponentWithStore } from 'spec/helpers/vue_mount_component_helper';
import { mockTracking, triggerEvent } from 'spec/helpers/tracking_helper';
import DiffFileComponent from '~/diffs/components/diff_file.vue'; import DiffFileComponent from '~/diffs/components/diff_file.vue';
import { diffViewerModes, diffViewerErrors } from '~/ide/constants'; import { diffViewerModes, diffViewerErrors } from '~/ide/constants';
import diffFileMockDataReadable from '../mock_data/diff_file'; import diffFileMockDataReadable from '../mock_data/diff_file';
...@@ -8,12 +9,14 @@ import diffFileMockDataUnreadable from '../mock_data/diff_file_unreadable'; ...@@ -8,12 +9,14 @@ import diffFileMockDataUnreadable from '../mock_data/diff_file_unreadable';
describe('DiffFile', () => { describe('DiffFile', () => {
let vm; let vm;
let trackingSpy;
beforeEach(() => { beforeEach(() => {
vm = createComponentWithStore(Vue.extend(DiffFileComponent), createStore(), { vm = createComponentWithStore(Vue.extend(DiffFileComponent), createStore(), {
file: JSON.parse(JSON.stringify(diffFileMockDataReadable)), file: JSON.parse(JSON.stringify(diffFileMockDataReadable)),
canCurrentUserFork: false, canCurrentUserFork: false,
}).$mount(); }).$mount();
trackingSpy = mockTracking('_category_', vm.$el, spyOn);
}); });
afterEach(() => { afterEach(() => {
...@@ -30,6 +33,7 @@ describe('DiffFile', () => { ...@@ -30,6 +33,7 @@ describe('DiffFile', () => {
expect(el.querySelectorAll('.diff-content.hidden').length).toEqual(0); expect(el.querySelectorAll('.diff-content.hidden').length).toEqual(0);
expect(el.querySelector('.js-file-title')).toBeDefined(); expect(el.querySelector('.js-file-title')).toBeDefined();
expect(el.querySelector('.btn-clipboard')).toBeDefined();
expect(el.querySelector('.file-title-name').innerText.indexOf(file_path)).toBeGreaterThan(-1); expect(el.querySelector('.file-title-name').innerText.indexOf(file_path)).toBeGreaterThan(-1);
expect(el.querySelector('.js-syntax-highlight')).toBeDefined(); expect(el.querySelector('.js-syntax-highlight')).toBeDefined();
...@@ -39,6 +43,25 @@ describe('DiffFile', () => { ...@@ -39,6 +43,25 @@ describe('DiffFile', () => {
.then(() => { .then(() => {
expect(el.querySelectorAll('.line_content').length).toBe(5); expect(el.querySelectorAll('.line_content').length).toBe(5);
expect(el.querySelectorAll('.js-line-expansion-content').length).toBe(1); expect(el.querySelectorAll('.js-line-expansion-content').length).toBe(1);
triggerEvent('.btn-clipboard');
})
.then(done)
.catch(done.fail);
});
it('should track a click event on copy to clip board button', done => {
const el = vm.$el;
expect(el.querySelector('.btn-clipboard')).toBeDefined();
vm.file.renderIt = true;
vm.$nextTick()
.then(() => {
triggerEvent('.btn-clipboard');
expect(trackingSpy).toHaveBeenCalledWith('_category_', 'click_copy_file_button', {
label: 'diff_copy_file_path_button',
property: 'diff_copy_file',
});
}) })
.then(done) .then(done)
.catch(done.fail); .catch(done.fail);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment