Merge branch 'frozen_spec_helpers' into 'master'

Add frozen_string_literal to helper specs

See merge request gitlab-org/gitlab!17848

app/helpers/submodule_helper.rb

@@ -81,7 +81,7 @@ module SubmoduleHelper
   end
 
   def relative_self_links(relative_path, commit, project)
-    relative_path.rstrip!
+    relative_path = relative_path.rstrip
     absolute_project_path = "/" + project.full_path
 
     # Resolve `relative_path` to target path

spec/helpers/application_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe ApplicationHelper do

spec/helpers/auto_devops_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe AutoDevopsHelper do

spec/helpers/avatars_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe AvatarsHelper do

spec/helpers/award_emoji_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe AwardEmojiHelper do

spec/helpers/blame_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe BlameHelper do

spec/helpers/blob_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe BlobHelper do

spec/helpers/boards_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe BoardsHelper do

spec/helpers/broadcast_messages_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe BroadcastMessagesHelper do

spec/helpers/button_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe ButtonHelper do

spec/helpers/calendar_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe CalendarHelper do

spec/helpers/ci_status_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe CiStatusHelper do

spec/helpers/commits_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe CommitsHelper do

spec/helpers/components_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe ComponentsHelper do

spec/helpers/dashboard_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe DashboardHelper do

spec/helpers/defer_script_tag_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe DeferScriptTagHelper do

spec/helpers/emails_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe EmailsHelper do

spec/helpers/events_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe EventsHelper do

spec/helpers/explore_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe ExploreHelper do

spec/helpers/form_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe FormHelper do

spec/helpers/git_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe GitHelper do

spec/helpers/gitlab_routing_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe GitlabRoutingHelper do

spec/helpers/graph_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe GraphHelper do

spec/helpers/hooks_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe HooksHelper do

spec/helpers/icons_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe IconsHelper do

spec/helpers/import_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe ImportHelper do

spec/helpers/instance_configuration_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe InstanceConfigurationHelper do

spec/helpers/issues_helper_spec.rb

+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe IssuesHelper do

spec/helpers/labels_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe LabelsHelper do

spec/helpers/markup_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe MarkupHelper do
@@ -408,12 +410,12 @@ describe MarkupHelper do
 
       it 'preserves a link href when link text is truncated' do
         text = 'The quick brown fox jumped over the lazy dog' # 44 chars
-        input = "#{text}#{text}#{text} " # 133 chars
         link_url = 'http://example.com/foo/bar/baz' # 30 chars
-        input << link_url
-        object = create_object(input)
+        input = "#{text}#{text}#{text} #{link_url}" # 163 chars
         expected_link_text = 'http://example...</a>'
 
+        object = create_object(input)
+
         expect(first_line_in_markdown(object, attribute, 150, project: project)).to match(link_url)
         expect(first_line_in_markdown(object, attribute, 150, project: project)).to match(expected_link_text)
       end

spec/helpers/members_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe MembersHelper do

spec/helpers/milestones_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe MilestonesHelper do

spec/helpers/milestones_routing_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe MilestonesRoutingHelper do

spec/helpers/namespaces_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe NamespacesHelper do

spec/helpers/nav_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe NavHelper, :do_not_mock_admin_mode do

spec/helpers/notes_helper_spec.rb

+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe NotesHelper do

spec/helpers/notifications_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe NotificationsHelper do

spec/helpers/page_layout_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe PageLayoutHelper do

spec/helpers/pagination_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe PaginationHelper do

spec/helpers/preferences_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe PreferencesHelper do

spec/helpers/profiles_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe ProfilesHelper do

spec/helpers/rss_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe RssHelper do

spec/helpers/runners_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe RunnersHelper do

spec/helpers/search_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe SearchHelper do

spec/helpers/sidekiq_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe SidekiqHelper do

spec/helpers/snippets_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe SnippetsHelper do

spec/helpers/storage_helper_spec.rb

+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe StorageHelper do

spec/helpers/submodule_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe SubmoduleHelper do

spec/helpers/tab_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe TabHelper do

spec/helpers/time_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe TimeHelper do

spec/helpers/todos_helper_spec.rb

+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe TodosHelper do

spec/helpers/tree_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe TreeHelper do

spec/helpers/user_callouts_helper_spec.rb

+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe UserCalloutsHelper do

spec/helpers/users_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe UsersHelper do

spec/helpers/version_check_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe VersionCheckHelper do

spec/helpers/visibility_level_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe VisibilityLevelHelper do

spec/helpers/wiki_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe WikiHelper do