Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
3801dc0e
Commit
3801dc0e
authored
Mar 31, 2017
by
Ilya Vassilevsky
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Promote blameless culture by using "annotate" instead
User-facing changes (fast & easy win)
parent
5cb8ad6c
Changes
7
Hide whitespace changes
Inline
Side-by-side
Showing
7 changed files
with
10 additions
and
5 deletions
+10
-5
app/assets/stylesheets/framework/files.scss
app/assets/stylesheets/framework/files.scss
+1
-1
app/views/projects/blame/show.html.haml
app/views/projects/blame/show.html.haml
+1
-1
app/views/projects/blob/_breadcrumb.html.haml
app/views/projects/blob/_breadcrumb.html.haml
+1
-1
changelogs/unreleased/10378-promote-blameless-culture.yml
changelogs/unreleased/10378-promote-blameless-culture.yml
+4
-0
features/steps/project/source/browse_files.rb
features/steps/project/source/browse_files.rb
+1
-0
spec/features/projects/blobs/blob_line_permalink_updater_spec.rb
...atures/projects/blobs/blob_line_permalink_updater_spec.rb
+1
-1
spec/features/projects/files/browse_files_spec.rb
spec/features/projects/files/browse_files_spec.rb
+1
-1
No files found.
app/assets/stylesheets/framework/files.scss
View file @
3801dc0e
...
@@ -85,7 +85,7 @@
...
@@ -85,7 +85,7 @@
}
}
/**
/**
*
Blam
e file
*
Annotat
e file
*/
*/
&
.blame
{
&
.blame
{
table
{
table
{
...
...
app/views/projects/blame/show.html.haml
View file @
3801dc0e
-
@no_container
=
true
-
@no_container
=
true
-
page_title
"
Blam
e"
,
@blob
.
path
,
@ref
-
page_title
"
Annotat
e"
,
@blob
.
path
,
@ref
=
render
"projects/commits/head"
=
render
"projects/commits/head"
%div
{
class:
container_class
}
%div
{
class:
container_class
}
...
...
app/views/projects/blob/_breadcrumb.html.haml
View file @
3801dc0e
...
@@ -10,7 +10,7 @@
...
@@ -10,7 +10,7 @@
=
link_to
'Normal view'
,
namespace_project_blob_path
(
@project
.
namespace
,
@project
,
@id
),
=
link_to
'Normal view'
,
namespace_project_blob_path
(
@project
.
namespace
,
@project
,
@id
),
class:
'btn'
class:
'btn'
-
else
-
else
=
link_to
'
Blam
e'
,
namespace_project_blame_path
(
@project
.
namespace
,
@project
,
@id
),
=
link_to
'
Annotat
e'
,
namespace_project_blame_path
(
@project
.
namespace
,
@project
,
@id
),
class:
'btn js-blob-blame-link'
unless
blob
.
empty?
class:
'btn js-blob-blame-link'
unless
blob
.
empty?
=
link_to
'History'
,
namespace_project_commits_path
(
@project
.
namespace
,
@project
,
@id
),
=
link_to
'History'
,
namespace_project_commits_path
(
@project
.
namespace
,
@project
,
@id
),
...
...
changelogs/unreleased/10378-promote-blameless-culture.yml
0 → 100644
View file @
3801dc0e
---
title
:
Changed Blame to Annotate in the UI to promote blameless culture
merge_request
:
10378
author
:
Ilya Vassilevsky
features/steps/project/source/browse_files.rb
View file @
3801dc0e
...
@@ -372,6 +372,7 @@ class Spinach::Features::ProjectSourceBrowseFiles < Spinach::FeatureSteps
...
@@ -372,6 +372,7 @@ class Spinach::Features::ProjectSourceBrowseFiles < Spinach::FeatureSteps
expect
(
page
).
to
have_content
'Permalink'
expect
(
page
).
to
have_content
'Permalink'
expect
(
page
).
not_to
have_content
'Edit'
expect
(
page
).
not_to
have_content
'Edit'
expect
(
page
).
not_to
have_content
'Blame'
expect
(
page
).
not_to
have_content
'Blame'
expect
(
page
).
not_to
have_content
'Annotate'
expect
(
page
).
to
have_content
'Delete'
expect
(
page
).
to
have_content
'Delete'
expect
(
page
).
to
have_content
'Replace'
expect
(
page
).
to
have_content
'Replace'
end
end
...
...
spec/features/projects/blobs/blob_line_permalink_updater_spec.rb
View file @
3801dc0e
...
@@ -55,7 +55,7 @@ feature 'Blob button line permalinks (BlobLinePermalinkUpdater)', feature: true,
...
@@ -55,7 +55,7 @@ feature 'Blob button line permalinks (BlobLinePermalinkUpdater)', feature: true,
end
end
end
end
describe
'Click "
Blam
e" button'
do
describe
'Click "
Annotat
e" button'
do
it
'works with no initial line number fragment hash'
do
it
'works with no initial line number fragment hash'
do
visit_blob
visit_blob
...
...
spec/features/projects/files/browse_files_spec.rb
View file @
3801dc0e
...
@@ -12,7 +12,7 @@ feature 'user browses project', feature: true, js: true do
...
@@ -12,7 +12,7 @@ feature 'user browses project', feature: true, js: true do
scenario
"can see blame of '.gitignore'"
do
scenario
"can see blame of '.gitignore'"
do
click_link
".gitignore"
click_link
".gitignore"
click_link
'
Blam
e'
click_link
'
Annotat
e'
expect
(
page
).
to
have_content
"*.rb"
expect
(
page
).
to
have_content
"*.rb"
expect
(
page
).
to
have_content
"Dmitriy Zaporozhets"
expect
(
page
).
to
have_content
"Dmitriy Zaporozhets"
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment