Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
38abbafe
Commit
38abbafe
authored
Nov 27, 2017
by
Clement Ho
Committed by
Fatih Acet
Nov 27, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Disable autocomplete for epics
parent
522f4f13
Changes
7
Hide whitespace changes
Inline
Side-by-side
Showing
7 changed files
with
44 additions
and
3 deletions
+44
-3
app/assets/javascripts/issue_show/components/app.vue
app/assets/javascripts/issue_show/components/app.vue
+6
-0
app/assets/javascripts/issue_show/components/fields/description.vue
.../javascripts/issue_show/components/fields/description.vue
+8
-1
app/assets/javascripts/issue_show/components/form.vue
app/assets/javascripts/issue_show/components/form.vue
+8
-1
app/assets/javascripts/vue_shared/components/markdown/field.vue
...sets/javascripts/vue_shared/components/markdown/field.vue
+6
-1
changelogs/unreleased-ee/disable-autocomplete.yml
changelogs/unreleased-ee/disable-autocomplete.yml
+5
-0
ee/app/assets/javascripts/epics/epic_show/components/epic_show_app.vue
.../javascripts/epics/epic_show/components/epic_show_app.vue
+1
-0
spec/ee/spec/features/epics/update_epic_spec.rb
spec/ee/spec/features/epics/update_epic_spec.rb
+10
-0
No files found.
app/assets/javascripts/issue_show/components/app.vue
View file @
38abbafe
...
@@ -34,6 +34,11 @@ export default {
...
@@ -34,6 +34,11 @@ export default {
required
:
false
,
required
:
false
,
default
:
true
,
default
:
true
,
},
},
enableAutocomplete
:
{
type
:
Boolean
,
required
:
false
,
default
:
true
,
},
issuableRef
:
{
issuableRef
:
{
type
:
String
,
type
:
String
,
required
:
true
,
required
:
true
,
...
@@ -240,6 +245,7 @@ export default {
...
@@ -240,6 +245,7 @@ export default {
:project-namespace=
"projectNamespace"
:project-namespace=
"projectNamespace"
:show-delete-button=
"showDeleteButton"
:show-delete-button=
"showDeleteButton"
:can-attach-file=
"canAttachFile"
:can-attach-file=
"canAttachFile"
:enable-autocomplete=
"enableAutocomplete"
/>
/>
<div
v-else
>
<div
v-else
>
<title-component
<title-component
...
...
app/assets/javascripts/issue_show/components/fields/description.vue
View file @
38abbafe
...
@@ -22,6 +22,11 @@
...
@@ -22,6 +22,11 @@
required
:
false
,
required
:
false
,
default
:
true
,
default
:
true
,
},
},
enableAutocomplete
:
{
type
:
Boolean
,
required
:
false
,
default
:
true
,
},
},
},
components
:
{
components
:
{
markdownField
,
markdownField
,
...
@@ -42,7 +47,9 @@
...
@@ -42,7 +47,9 @@
<markdown-field
<markdown-field
:markdown-preview-path=
"markdownPreviewPath"
:markdown-preview-path=
"markdownPreviewPath"
:markdown-docs-path=
"markdownDocsPath"
:markdown-docs-path=
"markdownDocsPath"
:can-attach-file=
"canAttachFile"
>
:can-attach-file=
"canAttachFile"
:enable-autocomplete=
"enableAutocomplete"
>
<textarea
<textarea
id=
"issue-description"
id=
"issue-description"
class=
"note-textarea js-gfm-input js-autosize markdown-area"
class=
"note-textarea js-gfm-input js-autosize markdown-area"
...
...
app/assets/javascripts/issue_show/components/form.vue
View file @
38abbafe
...
@@ -46,6 +46,11 @@
...
@@ -46,6 +46,11 @@
required
:
false
,
required
:
false
,
default
:
true
,
default
:
true
,
},
},
enableAutocomplete
:
{
type
:
Boolean
,
required
:
false
,
default
:
true
,
},
},
},
components
:
{
components
:
{
lockedWarning
,
lockedWarning
,
...
@@ -89,7 +94,9 @@
...
@@ -89,7 +94,9 @@
:form-state=
"formState"
:form-state=
"formState"
:markdown-preview-path=
"markdownPreviewPath"
:markdown-preview-path=
"markdownPreviewPath"
:markdown-docs-path=
"markdownDocsPath"
:markdown-docs-path=
"markdownDocsPath"
:can-attach-file=
"canAttachFile"
/>
:can-attach-file=
"canAttachFile"
:enable-autocomplete=
"enableAutocomplete"
/>
<edit-actions
<edit-actions
:form-state=
"formState"
:form-state=
"formState"
:can-destroy=
"canDestroy"
:can-destroy=
"canDestroy"
...
...
app/assets/javascripts/vue_shared/components/markdown/field.vue
View file @
38abbafe
...
@@ -30,6 +30,11 @@
...
@@ -30,6 +30,11 @@
required
:
false
,
required
:
false
,
default
:
true
,
default
:
true
,
},
},
enableAutocomplete
:
{
type
:
Boolean
,
required
:
false
,
default
:
true
,
},
},
},
data
()
{
data
()
{
return
{
return
{
...
@@ -97,7 +102,7 @@
...
@@ -97,7 +102,7 @@
/*
/*
GLForm class handles all the toolbar buttons
GLForm class handles all the toolbar buttons
*/
*/
return
new
GLForm
(
$
(
this
.
$refs
[
'
gl-form
'
]),
t
ru
e
);
return
new
GLForm
(
$
(
this
.
$refs
[
'
gl-form
'
]),
t
his
.
enableAutocomplet
e
);
},
},
beforeDestroy
()
{
beforeDestroy
()
{
const
glForm
=
$
(
this
.
$refs
[
'
gl-form
'
]).
data
(
'
gl-form
'
);
const
glForm
=
$
(
this
.
$refs
[
'
gl-form
'
]).
data
(
'
gl-form
'
);
...
...
changelogs/unreleased-ee/disable-autocomplete.yml
0 → 100644
View file @
38abbafe
---
title
:
Disable autocomplete for epics
merge_request
:
author
:
type
:
fixed
ee/app/assets/javascripts/epics/epic_show/components/epic_show_app.vue
View file @
38abbafe
...
@@ -123,6 +123,7 @@
...
@@ -123,6 +123,7 @@
:show-inline-edit-button=
"true"
:show-inline-edit-button=
"true"
:show-delete-button=
"false"
:show-delete-button=
"false"
:can-attach-file=
"false"
:can-attach-file=
"false"
:enable-autocomplete=
"false"
/>
/>
</div>
</div>
<epic-sidebar
<epic-sidebar
...
...
spec/ee/spec/features/epics/update_epic_spec.rb
View file @
38abbafe
...
@@ -50,6 +50,16 @@ feature 'Update Epic', :js do
...
@@ -50,6 +50,16 @@ feature 'Update Epic', :js do
expect
(
page
).
not_to
have_selector
(
'.uploading-container .button-attach-file'
)
expect
(
page
).
not_to
have_selector
(
'.uploading-container .button-attach-file'
)
end
end
# Autocomplete is disabled for epics until #4084 is resolved
describe
'autocomplete disabled'
do
it
'does not open atwho container'
do
find
(
'.btn-edit'
).
click
find
(
'#issue-description'
).
native
.
send_keys
(
'@'
)
expect
(
page
).
not_to
have_selector
(
'.atwho-container'
)
end
end
end
end
context
'when user with owner access displays the epic'
do
context
'when user with owner access displays the epic'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment