Merge branch 'issue#325836-fix-empty-line-after-let-it-be-groups-controller' into 'master'

Fix EmptyLineAfterFinalLetItBe Rubocop offenses for groups controller

See merge request gitlab-org/gitlab!58174

.rubocop_manual_todo.yml

@@ -808,10 +808,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
     - ee/spec/workers/set_user_status_based_on_user_cap_setting_worker_spec.rb
     - spec/controllers/confirmations_controller_spec.rb
     - spec/controllers/dashboard/projects_controller_spec.rb
-    - spec/controllers/groups/dependency_proxy_auth_controller_spec.rb
-    - spec/controllers/groups/dependency_proxy_for_containers_controller_spec.rb
-    - spec/controllers/groups/registry/repositories_controller_spec.rb
-    - spec/controllers/groups/variables_controller_spec.rb
     - spec/controllers/invites_controller_spec.rb
     - spec/controllers/profiles/emails_controller_spec.rb
     - spec/controllers/projects/alerting/notifications_controller_spec.rb

changelogs/unreleased/issue-325836-fix-empty-line-after-let-it-be-groups-controller.yml

+---
+title: Fix EmptyLineAfterFinalLetItBe Rubocop offenses for groups controller
+merge_request: 58174
+author: Huzaifa Iftikhar @huzaifaiftikhar
+type: fixed

spec/controllers/groups/dependency_proxy_auth_controller_spec.rb

@@ -31,6 +31,7 @@ RSpec.describe Groups::DependencyProxyAuthController do
 
     context 'with valid JWT' do
       let_it_be(:user) { create(:user) }
+
       let(:jwt) { build_jwt(user) }
       let(:token_header) { "Bearer #{jwt.encoded}" }
 
@@ -65,6 +66,7 @@ RSpec.describe Groups::DependencyProxyAuthController do
 
       context 'expired token' do
         let_it_be(:user) { create(:user) }
+
         let(:jwt) { build_jwt(user, expire_time: Time.zone.now - 1.hour) }
         let(:token_header) { "Bearer #{jwt.encoded}" }
 

spec/controllers/groups/dependency_proxy_for_containers_controller_spec.rb

@@ -7,6 +7,7 @@ RSpec.describe Groups::DependencyProxyForContainersController do
   include DependencyProxyHelpers
 
   let_it_be(:user) { create(:user) }
+
   let(:group) { create(:group) }
   let(:token_response) { { status: :success, token: 'abcd1234' } }
   let(:jwt) { build_jwt(user) }
@@ -102,6 +103,7 @@ RSpec.describe Groups::DependencyProxyForContainersController do
 
   describe 'GET #manifest' do
     let_it_be(:manifest) { create(:dependency_proxy_manifest) }
+
     let(:pull_response) { { status: :success, manifest: manifest } }
 
     before do
@@ -182,6 +184,7 @@ RSpec.describe Groups::DependencyProxyForContainersController do
 
   describe 'GET #blob' do
     let_it_be(:blob) { create(:dependency_proxy_blob) }
+
     let(:blob_sha) { blob.file_name.sub('.gz', '') }
     let(:blob_response) { { status: :success, blob: blob } }
 

spec/controllers/groups/registry/repositories_controller_spec.rb

@@ -6,6 +6,7 @@ RSpec.describe Groups::Registry::RepositoriesController do
   let_it_be(:user)  { create(:user) }
   let_it_be(:guest) { create(:user) }
   let_it_be(:group, reload: true) { create(:group) }
+
   let(:additional_parameters) { {} }
 
   subject do

spec/controllers/groups/variables_controller_spec.rb

@@ -8,6 +8,7 @@ RSpec.describe Groups::VariablesController do
   let_it_be(:group) { create(:group) }
   let_it_be(:user) { create(:user) }
   let_it_be(:variable) { create(:ci_group_variable, group: group) }
+
   let(:access_level) { :owner }
 
   before do