Merge branch 'frozen-string-enable-app-models-more' into 'master'

Enable frozen string for app/models/**/*.rb

See merge request gitlab-org/gitlab-ce!21001

app/models/application_setting/term.rb

+# frozen_string_literal: true
+
 class ApplicationSetting
   class Term < ActiveRecord::Base
     include CacheMarkdownField

app/models/badges/group_badge.rb

+# frozen_string_literal: true
+
 class GroupBadge < Badge
   belongs_to :group
 

app/models/badges/project_badge.rb

+# frozen_string_literal: true
+
 class ProjectBadge < Badge
   belongs_to :project
 

app/models/blob_viewer/auxiliary.rb

+# frozen_string_literal: true
+
 module BlobViewer
   module Auxiliary
     extend ActiveSupport::Concern

app/models/blob_viewer/balsamiq.rb

+# frozen_string_literal: true
+
 module BlobViewer
   class Balsamiq < Base
     include Rich

app/models/blob_viewer/base.rb

+# frozen_string_literal: true
+
 module BlobViewer
   class Base
     PARTIAL_PATH_PREFIX = 'projects/blob/viewers'.freeze

app/models/blob_viewer/binary_stl.rb

+# frozen_string_literal: true
+
 module BlobViewer
   class BinarySTL < Base
     include Rich

app/models/blob_viewer/cartfile.rb

+# frozen_string_literal: true
+
 module BlobViewer
   class Cartfile < DependencyManager
     include Static

app/models/blob_viewer/changelog.rb

+# frozen_string_literal: true
+
 module BlobViewer
   class Changelog < Base
     include Auxiliary

app/models/blob_viewer/client_side.rb

+# frozen_string_literal: true
+
 module BlobViewer
   module ClientSide
     extend ActiveSupport::Concern

app/models/blob_viewer/composer_json.rb

+# frozen_string_literal: true
+
 module BlobViewer
   class ComposerJson < DependencyManager
     include ServerSide

app/models/blob_viewer/contributing.rb

+# frozen_string_literal: true
+
 module BlobViewer
   class Contributing < Base
     include Auxiliary

app/models/blob_viewer/dependency_manager.rb

+# frozen_string_literal: true
+
 module BlobViewer
   class DependencyManager < Base
     include Auxiliary

app/models/blob_viewer/download.rb

+# frozen_string_literal: true
+
 module BlobViewer
   class Download < Base
     include Simple

app/models/blob_viewer/empty.rb

+# frozen_string_literal: true
+
 module BlobViewer
   class Empty < Base
     include Simple

app/models/blob_viewer/gemfile.rb

+# frozen_string_literal: true
+
 module BlobViewer
   class Gemfile < DependencyManager
     include Static

app/models/blob_viewer/gemspec.rb

+# frozen_string_literal: true
+
 module BlobViewer
   class Gemspec < DependencyManager
     include ServerSide

app/models/blob_viewer/gitlab_ci_yml.rb

+# frozen_string_literal: true
+
 module BlobViewer
   class GitlabCiYml < Base
     include ServerSide

app/models/blob_viewer/godeps_json.rb

+# frozen_string_literal: true
+
 module BlobViewer
   class GodepsJson < DependencyManager
     include Static

app/models/blob_viewer/image.rb

+# frozen_string_literal: true
+
 module BlobViewer
   class Image < Base
     include Rich

app/models/blob_viewer/license.rb

+# frozen_string_literal: true
+
 module BlobViewer
   class License < Base
     include Auxiliary

app/models/blob_viewer/markup.rb

+# frozen_string_literal: true
+
 module BlobViewer
   class Markup < Base
     include Rich

app/models/blob_viewer/notebook.rb

+# frozen_string_literal: true
+
 module BlobViewer
   class Notebook < Base
     include Rich

app/models/blob_viewer/package_json.rb

+# frozen_string_literal: true
+
 module BlobViewer
   class PackageJson < DependencyManager
     include ServerSide

app/models/blob_viewer/pdf.rb

+# frozen_string_literal: true
+
 module BlobViewer
   class PDF < Base
     include Rich

app/models/blob_viewer/podfile.rb

+# frozen_string_literal: true
+
 module BlobViewer
   class Podfile < DependencyManager
     include Static

app/models/blob_viewer/podspec.rb

+# frozen_string_literal: true
+
 module BlobViewer
   class Podspec < DependencyManager
     include ServerSide

app/models/blob_viewer/podspec_json.rb

+# frozen_string_literal: true
+
 module BlobViewer
   class PodspecJson < Podspec
     self.file_types = %i(podspec_json)

app/models/blob_viewer/readme.rb

+# frozen_string_literal: true
+
 module BlobViewer
   class Readme < Base
     include Auxiliary

app/models/blob_viewer/requirements_txt.rb

+# frozen_string_literal: true
+
 module BlobViewer
   class RequirementsTxt < DependencyManager
     include Static

app/models/blob_viewer/rich.rb

+# frozen_string_literal: true
+
 module BlobViewer
   module Rich
     extend ActiveSupport::Concern

app/models/blob_viewer/route_map.rb

+# frozen_string_literal: true
+
 module BlobViewer
   class RouteMap < Base
     include ServerSide

app/models/blob_viewer/server_side.rb

+# frozen_string_literal: true
+
 module BlobViewer
   module ServerSide
     extend ActiveSupport::Concern

app/models/blob_viewer/simple.rb

+# frozen_string_literal: true
+
 module BlobViewer
   module Simple
     extend ActiveSupport::Concern

app/models/blob_viewer/sketch.rb

+# frozen_string_literal: true
+
 module BlobViewer
   class Sketch < Base
     include Rich

app/models/blob_viewer/static.rb

+# frozen_string_literal: true
+
 module BlobViewer
   module Static
     extend ActiveSupport::Concern

app/models/blob_viewer/svg.rb

+# frozen_string_literal: true
+
 module BlobViewer
   class SVG < Base
     include Rich

app/models/blob_viewer/text.rb

+# frozen_string_literal: true
+
 module BlobViewer
   class Text < Base
     include Simple

app/models/blob_viewer/text_stl.rb

+# frozen_string_literal: true
+
 module BlobViewer
   class TextSTL < BinarySTL
     self.binary = false

app/models/blob_viewer/video.rb

+# frozen_string_literal: true
+
 module BlobViewer
   class Video < Base
     include Rich

app/models/blob_viewer/yarn_lock.rb

+# frozen_string_literal: true
+
 module BlobViewer
   class YarnLock < DependencyManager
     include Static

app/models/ci/artifact_blob.rb

+# frozen_string_literal: true
+
 module Ci
   class ArtifactBlob
     include BlobLike

app/models/ci/build.rb

+# frozen_string_literal: true
+
 module Ci
   class Build < CommitStatus
     prepend ArtifactMigratable

app/models/ci/build_metadata.rb

+# frozen_string_literal: true
+
 module Ci
   # The purpose of this class is to store Build related data that can be disposed.
   # Data that should be persisted forever, should be stored with Ci::Build model.

app/models/ci/build_runner_session.rb

+# frozen_string_literal: true
+
 module Ci
   # The purpose of this class is to store Build related runner session.
   # Data will be removed after transitioning from running to any state.

app/models/ci/build_trace_chunk.rb

+# frozen_string_literal: true
+
 module Ci
   class BuildTraceChunk < ActiveRecord::Base
     include FastDestroyAll

app/models/ci/build_trace_chunks/database.rb

+# frozen_string_literal: true
+
 module Ci
   module BuildTraceChunks
     class Database

app/models/ci/build_trace_chunks/fog.rb

+# frozen_string_literal: true
+
 module Ci
   module BuildTraceChunks
     class Fog

app/models/ci/build_trace_chunks/redis.rb

+# frozen_string_literal: true
+
 module Ci
   module BuildTraceChunks
     class Redis

app/models/ci/build_trace_section.rb

+# frozen_string_literal: true
+
 module Ci
   class BuildTraceSection < ActiveRecord::Base
     extend Gitlab::Ci::Model

app/models/ci/build_trace_section_name.rb

+# frozen_string_literal: true
+
 module Ci
   class BuildTraceSectionName < ActiveRecord::Base
     extend Gitlab::Ci::Model

app/models/ci/group.rb

+# frozen_string_literal: true
+
 module Ci
   ##
   # This domain model is a representation of a group of jobs that are related

app/models/ci/group_variable.rb

+# frozen_string_literal: true
+
 module Ci
   class GroupVariable < ActiveRecord::Base
     extend Gitlab::Ci::Model

app/models/ci/job_artifact.rb

+# frozen_string_literal: true
+
 module Ci
   class JobArtifact < ActiveRecord::Base
     include AfterCommitQueue

app/models/ci/legacy_stage.rb

+# frozen_string_literal: true
+
 module Ci
   # Currently this is artificial object, constructed dynamically
   # We should migrate this object to actual database record in the future

app/models/ci/pipeline.rb

+# frozen_string_literal: true
+
 module Ci
   class Pipeline < ActiveRecord::Base
     extend Gitlab::Ci::Model

app/models/ci/pipeline_schedule.rb

+# frozen_string_literal: true
+
 module Ci
   class PipelineSchedule < ActiveRecord::Base
     extend Gitlab::Ci::Model

app/models/ci/pipeline_schedule_variable.rb

+# frozen_string_literal: true
+
 module Ci
   class PipelineScheduleVariable < ActiveRecord::Base
     extend Gitlab::Ci::Model

app/models/ci/pipeline_variable.rb

+# frozen_string_literal: true
+
 module Ci
   class PipelineVariable < ActiveRecord::Base
     extend Gitlab::Ci::Model

app/models/ci/runner.rb

+# frozen_string_literal: true
+
 module Ci
   class Runner < ActiveRecord::Base
     extend Gitlab::Ci::Model

app/models/ci/runner_namespace.rb

+# frozen_string_literal: true
+
 module Ci
   class RunnerNamespace < ActiveRecord::Base
     extend Gitlab::Ci::Model

app/models/ci/runner_project.rb

+# frozen_string_literal: true
+
 module Ci
   class RunnerProject < ActiveRecord::Base
     extend Gitlab::Ci::Model

app/models/ci/stage.rb

+# frozen_string_literal: true
+
 module Ci
   class Stage < ActiveRecord::Base
     extend Gitlab::Ci::Model

app/models/ci/trigger.rb

+# frozen_string_literal: true
+
 module Ci
   class Trigger < ActiveRecord::Base
     extend Gitlab::Ci::Model

app/models/ci/trigger_request.rb

+# frozen_string_literal: true
+
 module Ci
   class TriggerRequest < ActiveRecord::Base
     extend Gitlab::Ci::Model

app/models/ci/variable.rb

+# frozen_string_literal: true
+
 module Ci
   class Variable < ActiveRecord::Base
     extend Gitlab::Ci::Model

app/models/clusters/applications/helm.rb

+# frozen_string_literal: true
+
 module Clusters
   module Applications
     class Helm < ActiveRecord::Base

app/models/clusters/applications/ingress.rb

+# frozen_string_literal: true
+
 module Clusters
   module Applications
     class Ingress < ActiveRecord::Base

app/models/clusters/applications/jupyter.rb

+# frozen_string_literal: true
+
 module Clusters
   module Applications
     class Jupyter < ActiveRecord::Base

app/models/clusters/applications/prometheus.rb

+# frozen_string_literal: true
+
 module Clusters
   module Applications
     class Prometheus < ActiveRecord::Base

app/models/clusters/applications/runner.rb

+# frozen_string_literal: true
+
 module Clusters
   module Applications
     class Runner < ActiveRecord::Base

app/models/clusters/cluster.rb

+# frozen_string_literal: true
+
 module Clusters
   class Cluster < ActiveRecord::Base
     include Presentable

app/models/clusters/concerns/application_core.rb

+# frozen_string_literal: true
+
 module Clusters
   module Concerns
     module ApplicationCore

app/models/clusters/concerns/application_data.rb

+# frozen_string_literal: true
+
 module Clusters
   module Concerns
     module ApplicationData

app/models/clusters/concerns/application_status.rb

+# frozen_string_literal: true
+
 module Clusters
   module Concerns
     module ApplicationStatus

app/models/clusters/platforms/kubernetes.rb

+# frozen_string_literal: true
+
 module Clusters
   module Platforms
     class Kubernetes < ActiveRecord::Base

app/models/clusters/project.rb

+# frozen_string_literal: true
+
 module Clusters
   class Project < ActiveRecord::Base
     self.table_name = 'cluster_projects'

app/models/clusters/providers/gcp.rb

+# frozen_string_literal: true
+
 module Clusters
   module Providers
     class Gcp < ActiveRecord::Base

changelogs/unreleased/frozen-string-enable-app-models-more.yml

+---
+title: Enable frozen string for app/models/**/*.rb
+merge_request: 21001
+author: gfyoung
+type: performance