Commit 3a9007d2 authored by Kushal Pandya's avatar Kushal Pandya

Merge branch 'mw-cr-approvers-column-badge-tooltip' into 'master'

Code Review Analytics: Add badge tooltips for hidden approvers

See merge request gitlab-org/gitlab!25239
parents 612f82a1 c2fedfb3
......@@ -38,6 +38,7 @@ export default {
},
},
avatarSize: 24,
badgeTooltipMaxChars: 50,
};
</script>
......@@ -49,6 +50,8 @@ export default {
:avatars="approvers"
:max-visible="maxVisible"
:avatar-size="$options.avatarSize"
badge-tooltip-prop="name"
:badge-tooltip-max-chars="$options.badgeTooltipMaxChars"
>
<template #avatar="{ avatar }">
<gl-avatar-link v-gl-tooltip target="_blank" :href="avatar.web_url" :title="avatar.name">
......
......@@ -5,7 +5,8 @@ exports[`ApproversColumn component when a list with more than three approvers is
<gl-avatars-inline-stub
avatars="[object Object],[object Object],[object Object],[object Object]"
avatarsize="24"
badgetooltipprop=""
badgetooltipmaxchars="50"
badgetooltipprop="name"
collapsed="true"
maxvisible="2"
/>
......@@ -36,7 +37,8 @@ exports[`ApproversColumn component when a list with three approvers is passed ma
<gl-avatars-inline-stub
avatars="[object Object],[object Object],[object Object]"
avatarsize="24"
badgetooltipprop=""
badgetooltipmaxchars="50"
badgetooltipprop="name"
collapsed="true"
maxvisible="3"
/>
......@@ -48,7 +50,8 @@ exports[`ApproversColumn component when a list with two approvers is passed matc
<gl-avatars-inline-stub
avatars="[object Object],[object Object]"
avatarsize="24"
badgetooltipprop=""
badgetooltipmaxchars="50"
badgetooltipprop="name"
collapsed="true"
maxvisible="3"
/>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment