Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
3ad56a0b
Commit
3ad56a0b
authored
Jul 29, 2021
by
Mike Kozono
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Avoid unnecessary file creation
And remove unnecessary custom factory names.
parent
3c7b481a
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
3 additions
and
6 deletions
+3
-6
.gitlab/issue_templates/Geo Replicate a new Git repository type.md
...ssue_templates/Geo Replicate a new Git repository type.md
+1
-1
.gitlab/issue_templates/Geo Replicate a new blob type.md
.gitlab/issue_templates/Geo Replicate a new blob type.md
+1
-1
ee/spec/services/geo/registry_consistency_service_spec.rb
ee/spec/services/geo/registry_consistency_service_spec.rb
+1
-4
No files found.
.gitlab/issue_templates/Geo Replicate a new Git repository type.md
View file @
3ad56a0b
...
...
@@ -454,7 +454,7 @@ That's all of the required database changes.
```
-
[ ] Update
`REGISTRY_CLASSES`
in
`ee/app/workers/geo/secondary/registry_consistency_worker.rb`
.
-
[ ]
Update
`def model_class_factory_name`
in
`ee/spec/services/geo/registry_consistency_service_spec.rb`
.
-
[ ]
Add a custom factory name if needed in
`def model_class_factory_name`
in
`ee/spec/services/geo/registry_consistency_service_spec.rb`
.
-
[ ] Update
`it 'creates missing registries for each registry class'`
in
`ee/spec/workers/geo/secondary/registry_consistency_worker_spec.rb`
.
-
[ ] Add
`cool_widget_registry`
to
`ActiveSupport::Inflector.inflections`
in
`config/initializers_before_autoloader/000_inflections.rb`
.
-
[ ] Create
`ee/spec/factories/geo/cool_widget_registry.rb`
:
...
...
.gitlab/issue_templates/Geo Replicate a new blob type.md
View file @
3ad56a0b
...
...
@@ -421,7 +421,7 @@ That's all of the required database changes.
```
-
[ ] Update
`REGISTRY_CLASSES`
in
`ee/app/workers/geo/secondary/registry_consistency_worker.rb`
.
-
[ ]
Update
`def model_class_factory_name`
in
`ee/spec/services/geo/registry_consistency_service_spec.rb`
.
-
[ ]
Add a custom factory name if needed in
`def model_class_factory_name`
in
`ee/spec/services/geo/registry_consistency_service_spec.rb`
.
-
[ ] Update
`it 'creates missing registries for each registry class'`
in
`ee/spec/workers/geo/secondary/registry_consistency_worker_spec.rb`
.
-
[ ] Add
`cool_widget_registry`
to
`ActiveSupport::Inflector.inflections`
in
`config/initializers_before_autoloader/000_inflections.rb`
.
-
[ ] Create
`ee/spec/factories/geo/cool_widget_registry.rb`
:
...
...
ee/spec/services/geo/registry_consistency_service_spec.rb
View file @
3ad56a0b
...
...
@@ -19,10 +19,7 @@ RSpec.describe Geo::RegistryConsistencyService, :geo, :use_clean_rails_memory_st
{
Geo
::
DesignRegistry
=>
:project_with_design
,
Geo
::
MergeRequestDiffRegistry
=>
:external_merge_request_diff
,
Geo
::
PackageFileRegistry
=>
:package_file_with_file
,
Geo
::
SnippetRepositoryRegistry
=>
:snippet_repository
,
Geo
::
TerraformStateVersionRegistry
=>
:terraform_state_version
,
Geo
::
PipelineArtifactRegistry
=>
:ci_pipeline_artifact
Geo
::
PackageFileRegistry
=>
:package_file
}.
fetch
(
registry_class
,
default_factory_name
)
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment