Merge branch 'standardize-project-fabrication-on-qa-plan-tests' into 'master'

Standardize project fabrication on QA Plan tests

See merge request gitlab-org/gitlab!24474

qa/qa/specs/features/browser_ui/2_plan/email/trigger_email_notification_spec.rb

@@ -8,8 +8,8 @@ module QA
       end
 
       let(:project) do
-        Resource::Project.fabricate_via_api! do |resource|
-          resource.name = 'email-notification-test'
+        Resource::Project.fabricate_via_api! do |project|
+          project.name = 'email-notification-test'
         end
       end
 

qa/qa/specs/features/browser_ui/2_plan/issue/check_mentions_for_xss_spec.rb

@@ -21,8 +21,8 @@ module QA
 
         Flow::Login.sign_in
 
-        project = Resource::Project.fabricate_via_api! do |resource|
-          resource.name = 'xss-test-for-mentions-project'
+        project = Resource::Project.fabricate_via_api! do |project|
+          project.name = 'xss-test-for-mentions-project'
         end
 
         Flow::Project.add_member(project: project, username: user.username)

qa/qa/specs/features/browser_ui/2_plan/issue/mentions_spec.rb

@@ -8,9 +8,9 @@ module QA
 
         @user = Resource::User.fabricate_or_use(Runtime::Env.gitlab_qa_username_1, Runtime::Env.gitlab_qa_password_1)
 
-        project = Resource::Project.fabricate_via_api! do |resource|
-          resource.name = 'project-to-test-mention'
-          resource.visibility = 'private'
+        project = Resource::Project.fabricate_via_api! do |project|
+          project.name = 'project-to-test-mention'
+          project.visibility = 'private'
         end
 
         project.add_member(@user)

qa/qa/specs/features/ee/browser_ui/2_plan/issue_boards/project_issue_boards_spec.rb

@@ -63,8 +63,8 @@ module QA
         before do
           @user = Resource::User.fabricate_or_use(Runtime::Env.gitlab_qa_username_1, Runtime::Env.gitlab_qa_password_1)
 
-          project = Resource::Project.fabricate_via_api! do |resource|
-            resource.name = 'project-to-test-assignee-issue-board-list'
+          project = Resource::Project.fabricate_via_api! do |project|
+            project.name = 'project-to-test-assignee-issue-board-list'
           end
 
           project.add_member(@user)

qa/qa/specs/features/ee/browser_ui/2_plan/multiple_assignees_for_issues/four_assignees_spec.rb

@@ -11,8 +11,8 @@ module QA
         user_3 = Resource::User.fabricate_or_use(Runtime::Env.gitlab_qa_username_3, Runtime::Env.gitlab_qa_password_3)
         user_4 = Resource::User.fabricate_or_use(Runtime::Env.gitlab_qa_username_4, Runtime::Env.gitlab_qa_password_4)
 
-        project = Resource::Project.fabricate_via_api! do |resource|
-          resource.name = 'project-to-test-issue-with-multiple-assignees'
+        project = Resource::Project.fabricate_via_api! do |project|
+          project.name = 'project-to-test-issue-with-multiple-assignees'
         end
 
         project.add_member(user_1)

qa/qa/specs/features/ee/browser_ui/2_plan/multiple_assignees_for_issues/more_than_four_assignees_spec.rb

@@ -4,8 +4,8 @@ module QA
   context 'Plan', :reliable do
     describe 'Multiple assignees per issue' do
       let(:project) do
-        Resource::Project.fabricate_via_api! do |resource|
-          resource.name = 'project-to-test-issue-with-multiple-assignees'
+        Resource::Project.fabricate_via_api! do |project|
+          project.name = 'project-to-test-issue-with-multiple-assignees'
         end
       end