Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
3b531032
Commit
3b531032
authored
Apr 14, 2020
by
Nick Kipling
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Applying UX feedback
parent
d854f68b
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
17 additions
and
21 deletions
+17
-21
ee/app/assets/javascripts/packages/list/components/packages_list_row.vue
...avascripts/packages/list/components/packages_list_row.vue
+9
-15
ee/spec/frontend/packages/list/components/__snapshots__/packages_list_row_spec.js.snap
...t/components/__snapshots__/packages_list_row_spec.js.snap
+5
-3
locale/gitlab.pot
locale/gitlab.pot
+3
-3
No files found.
ee/app/assets/javascripts/packages/list/components/packages_list_row.vue
View file @
3b531032
...
...
@@ -2,7 +2,6 @@
import
PackageTags
from
'
../../shared/components/package_tags.vue
'
;
import
PublishMethod
from
'
./publish_method.vue
'
;
import
{
GlNewButton
,
GlIcon
,
GlLink
,
GlSprintf
,
GlTooltipDirective
}
from
'
@gitlab/ui
'
;
import
{
s__
}
from
'
~/locale
'
;
import
{
getPackageType
}
from
'
../../shared/utils
'
;
import
timeagoMixin
from
'
~/vue_shared/mixins/timeago
'
;
import
{
mapState
}
from
'
vuex
'
;
...
...
@@ -31,16 +30,12 @@ export default {
...
mapState
({
isGroupPage
:
state
=>
state
.
config
.
isGroupPage
,
}),
createdBy
()
{
if
(
this
.
packageEntity
.
pipeline
)
{
return
s__
(
'
PackageRegistry|%{version} published by %{author}
'
);
}
return
'
%{version}
'
;
},
packageType
()
{
return
getPackageType
(
this
.
packageEntity
.
package_type
);
},
hasPipeline
()
{
return
Boolean
(
this
.
packageEntity
.
pipeline
);
},
hasProjectLink
()
{
return
Boolean
(
this
.
packageEntity
.
project_path
);
},
...
...
@@ -68,14 +63,13 @@ export default {
</div>
<div
class=
"d-flex text-secondary text-truncate mt-md-2"
>
<gl-sprintf
:message=
"createdBy"
>
<template
#version
>
<gl-icon
name=
"eye"
class=
"text-secondary mr-1"
/>
{{
packageEntity
.
version
}}
</
template
>
<span>
{{
packageEntity
.
version
}}
</span>
<
template
#author
>
{{
packageEntity
.
pipeline
.
user
.
name
}}
</
template
>
</gl-sprintf>
<div
v-if=
"hasPipeline"
class=
"d-none d-md-inline-block ml-1"
>
<gl-sprintf
:message=
"s__('PackageRegistry|published by %
{author}')">
<template
#author
>
{{
packageEntity
.
pipeline
.
user
.
name
}}
</
template
>
</gl-sprintf>
</div>
<div
v-if=
"hasProjectLink"
class=
"d-flex align-items-center"
>
<gl-icon
name=
"review-list"
class=
"text-secondary ml-2 mr-1"
/>
...
...
ee/spec/frontend/packages/list/components/__snapshots__/packages_list_row_spec.js.snap
View file @
3b531032
...
...
@@ -24,9 +24,11 @@ exports[`packages_list_row renders 1`] = `
<div
class="d-flex text-secondary text-truncate mt-md-2"
>
<gl-sprintf-stub
message="%{version}"
/>
<span>
1.0.0
</span>
<!---->
<div
class="d-flex align-items-center"
...
...
locale/gitlab.pot
View file @
3b531032
...
...
@@ -14263,9 +14263,6 @@ msgstr ""
msgid "Package was removed"
msgstr ""
msgid "PackageRegistry|%{version} published by %{author}"
msgstr ""
msgid "PackageRegistry|Add Conan Remote"
msgstr ""
...
...
@@ -14404,6 +14401,9 @@ msgstr ""
msgid "PackageRegistry|npm"
msgstr ""
msgid "PackageRegistry|published by %{author}"
msgstr ""
msgid "PackageRegistry|yarn"
msgstr ""
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment