Merge branch 'issue#325836-fix-empty-line-after-let-it-be-metrics-module' into 'master'

Fix EmptyLineAfterFinalLetItBe Rubocop offenses for metrics module

See merge request gitlab-org/gitlab!58190

.rubocop_manual_todo.yml

@@ -696,8 +696,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
     - spec/finders/events_finder_spec.rb
     - spec/finders/group_descendants_finder_spec.rb
     - spec/finders/groups_finder_spec.rb
-    - spec/finders/metrics/dashboards/annotations_finder_spec.rb
-    - spec/finders/metrics/users_starred_dashboards_finder_spec.rb
     - spec/finders/packages/conan/package_file_finder_spec.rb
     - spec/finders/packages/go/module_finder_spec.rb
     - spec/finders/packages/group_packages_finder_spec.rb

changelogs/unreleased/issue-325836-fix-empty-line-after-let-it-be-metrics-module.yml

+---
+title: Fix EmptyLineAfterFinalLetItBe Rubocop offenses for metrics module
+merge_request: 58190
+author: Huzaifa Iftikhar @huzaifaiftikhar
+type: fixed

spec/finders/metrics/dashboards/annotations_finder_spec.rb

@@ -7,6 +7,7 @@ RSpec.describe Metrics::Dashboards::AnnotationsFinder do
     subject(:annotations) { described_class.new(dashboard: dashboard, params: params).execute }
 
     let_it_be(:current_user) { create(:user) }
+
     let(:path) { 'config/prometheus/common_metrics.yml' }
     let(:params) { {} }
     let(:environment) { create(:environment) }

spec/finders/metrics/users_starred_dashboards_finder_spec.rb

@@ -7,6 +7,7 @@ RSpec.describe Metrics::UsersStarredDashboardsFinder do
     subject(:starred_dashboards) { described_class.new(user: user, project: project, params: params).execute }
 
     let_it_be(:user) { create(:user) }
+
     let(:project) { create(:project) }
     let(:dashboard_path) { 'config/prometheus/common_metrics.yml' }
     let(:params) { {} }