Merge branch 'pl-rubocop-todo-redundant-file-extension-in-require' into 'master'

Resolves rubocop offense Style/RedundantFileExtensionInRequire

See merge request gitlab-org/gitlab!57963

.rubocop_todo.yml

@@ -876,11 +876,6 @@ Style/RedundantFetchBlock:
     - 'spec/lib/gitlab/null_request_store_spec.rb'
     - 'spec/lib/gitlab/safe_request_store_spec.rb'
 
-# Offense count: 26
-# Cop supports --auto-correct.
-Style/RedundantFileExtensionInRequire:
-  Enabled: false
-
 # Offense count: 206
 # Cop supports --auto-correct.
 Style/RedundantInterpolation:

changelogs/unreleased/pl-rubocop-todo-redundant-file-extension-in-require.yml

+---
+title: Resolves rubocop offense Style/RedundantFileExtensionInRequire
+merge_request: 57963
+author: Shubham Kumar (@imskr)
+type: fixed

ee/app/controllers/groups/saml_providers_controller.rb

 # frozen_string_literal: true
-require_relative '../concerns/saml_authorization.rb'
+require_relative '../concerns/saml_authorization'
 
 class Groups::SamlProvidersController < Groups::ApplicationController
   include SamlAuthorization

lib/tasks/tokens.rake

 # frozen_string_literal: true
 
-require_relative '../../app/models/concerns/token_authenticatable.rb'
-require_relative '../../app/models/concerns/token_authenticatable_strategies/base.rb'
-require_relative '../../app/models/concerns/token_authenticatable_strategies/insecure.rb'
-require_relative '../../app/models/concerns/token_authenticatable_strategies/digest.rb'
+require_relative '../../app/models/concerns/token_authenticatable'
+require_relative '../../app/models/concerns/token_authenticatable_strategies/base'
+require_relative '../../app/models/concerns/token_authenticatable_strategies/insecure'
+require_relative '../../app/models/concerns/token_authenticatable_strategies/digest'
 
 namespace :tokens do
   desc "Reset all GitLab incoming email tokens"

qa/qa/specs/features/browser_ui/8_monitor/all_monitor_core_features_spec.rb

 # frozen_string_literal: true
-require_relative 'cluster_with_prometheus.rb'
+require_relative 'cluster_with_prometheus'
 
 module QA
   RSpec.describe 'Monitor', :orchestrated, :kubernetes, :requires_admin, quarantine: { issue: 'https://gitlab.com/gitlab-org/gitlab/-/issues/241448', type: :investigating } do

qa/qa/specs/features/ee/browser_ui/8_monitor/all_monitor_features_spec.rb

 # frozen_string_literal: true
 require 'pathname'
-require_relative '../../../browser_ui/8_monitor/cluster_with_prometheus.rb'
+require_relative '../../../browser_ui/8_monitor/cluster_with_prometheus'
 
 module QA
   RSpec.describe 'Monitor', :orchestrated, :kubernetes, :requires_admin, quarantine: { issue: 'https://gitlab.com/gitlab-org/gitlab/-/issues/241448', type: :investigating } do

qa/qa/tools/revoke_all_personal_access_tokens.rb

 # frozen_string_literal: true
 
 require_relative '../../qa'
-require 'net/protocol.rb'
+require 'net/protocol'
 # This script revokes all personal access tokens with the name of 'api-test-token' on the host specified by GITLAB_ADDRESS
 # Required environment variables: GITLAB_USERNAME, GITLAB_PASSWORD and GITLAB_ADDRESS
 # Run `rake revoke_personal_access_tokens`

rubocop/cop/code_reuse/presenter.rb

 # frozen_string_literal: true
 
-require_relative '../../code_reuse_helpers.rb'
+require_relative '../../code_reuse_helpers'
 
 module RuboCop
   module Cop

rubocop/cop/code_reuse/serializer.rb

 # frozen_string_literal: true
 
-require_relative '../../code_reuse_helpers.rb'
+require_relative '../../code_reuse_helpers'
 
 module RuboCop
   module Cop

rubocop/cop/code_reuse/service_class.rb

 # frozen_string_literal: true
 
-require_relative '../../code_reuse_helpers.rb'
+require_relative '../../code_reuse_helpers'
 
 module RuboCop
   module Cop

rubocop/cop/code_reuse/worker.rb

 # frozen_string_literal: true
 
-require_relative '../../code_reuse_helpers.rb'
+require_relative '../../code_reuse_helpers'
 
 module RuboCop
   module Cop

rubocop/cop/scalability/idempotent_worker.rb

 # frozen_string_literal: true
 
-require_relative '../../code_reuse_helpers.rb'
+require_relative '../../code_reuse_helpers'
 
 module RuboCop
   module Cop

scripts/docs_screenshots.rb

@@ -5,7 +5,7 @@
 require 'png_quantizator'
 require 'open3'
 require 'parallel'
-require_relative '../tooling/lib/tooling/images.rb'
+require_relative '../tooling/lib/tooling/images'
 
 generator = ARGV[0]
 milestone = ARGV[1]

spec/initializers/6_validations_spec.rb

 # frozen_string_literal: true
 
 require 'spec_helper'
-require_relative '../../config/initializers/6_validations.rb'
+require_relative '../../config/initializers/6_validations'
 
 RSpec.describe '6_validations' do
   describe 'validate_storages_config' do

spec/initializers/mail_encoding_patch_spec.rb

@@ -3,7 +3,7 @@
 require 'fast_spec_helper'
 
 require 'mail'
-require_relative '../../config/initializers/mail_encoding_patch.rb'
+require_relative '../../config/initializers/mail_encoding_patch'
 
 RSpec.describe 'Mail quoted-printable transfer encoding patch and Unicode characters' do
   shared_examples 'email encoding' do |email|

spec/lib/gitlab/import_export/json/legacy_reader/file_spec.rb

 # frozen_string_literal: true
 
 require 'spec_helper'
-require_relative 'shared_example.rb'
+require_relative 'shared_example'
 
 RSpec.describe Gitlab::ImportExport::JSON::LegacyReader::File do
   it_behaves_like 'import/export json legacy reader' do

spec/lib/gitlab/import_export/json/legacy_reader/hash_spec.rb

 # frozen_string_literal: true
 
 require 'spec_helper'
-require_relative 'shared_example.rb'
+require_relative 'shared_example'
 
 RSpec.describe Gitlab::ImportExport::JSON::LegacyReader::Hash do
   it_behaves_like 'import/export json legacy reader' do

spec/rubocop/cop/performance/ar_count_each_spec.rb

 # frozen_string_literal: true
 
 require 'fast_spec_helper'
-require_relative '../../../../rubocop/cop/performance/ar_count_each.rb'
+require_relative '../../../../rubocop/cop/performance/ar_count_each'
 
 RSpec.describe RuboCop::Cop::Performance::ARCountEach do
   subject(:cop) { described_class.new }

spec/rubocop/cop/performance/ar_exists_and_present_blank_spec.rb

 # frozen_string_literal: true
 
 require 'fast_spec_helper'
-require_relative '../../../../rubocop/cop/performance/ar_exists_and_present_blank.rb'
+require_relative '../../../../rubocop/cop/performance/ar_exists_and_present_blank'
 
 RSpec.describe RuboCop::Cop::Performance::ARExistsAndPresentBlank do
   subject(:cop) { described_class.new }

spec/services/ci/pipeline_processing/atomic_processing_service_spec.rb

 # frozen_string_literal: true
 
 require 'spec_helper'
-require_relative 'shared_processing_service.rb'
-require_relative 'shared_processing_service_tests_with_yaml.rb'
+require_relative 'shared_processing_service'
+require_relative 'shared_processing_service_tests_with_yaml'
 
 RSpec.describe Ci::PipelineProcessing::AtomicProcessingService do
   it_behaves_like 'Pipeline Processing Service'

spec/services/issues/build_service_spec.rb

 # frozen_string_literal: true
 
-require 'spec_helper.rb'
+require 'spec_helper'
 
 RSpec.describe Issues::BuildService do
   let_it_be(:project) { create(:project, :repository) }

spec/services/issues/referenced_merge_requests_service_spec.rb

 # frozen_string_literal: true
 
-require 'spec_helper.rb'
+require 'spec_helper'
 
 RSpec.describe Issues::ReferencedMergeRequestsService do
   def create_referencing_mr(attributes = {})

spec/services/issues/resolve_discussions_spec.rb

 # frozen_string_literal: true
 
-require 'spec_helper.rb'
+require 'spec_helper'
 
 RSpec.describe Issues::ResolveDiscussions do
   let(:project) { create(:project, :repository) }