Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
3e1f672d
Commit
3e1f672d
authored
Feb 14, 2022
by
Doug Stull
Committed by
Andrew Fontaine
Feb 14, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove inviteeType from invite modal triggers
- no longer needed as the option was removed.
parent
eebbb1c7
Changes
9
Hide whitespace changes
Inline
Side-by-side
Showing
9 changed files
with
5 additions
and
17 deletions
+5
-17
app/assets/javascripts/groups/components/invite_members_banner.vue
...s/javascripts/groups/components/invite_members_banner.vue
+0
-1
app/assets/javascripts/invite_members/components/invite_members_trigger.vue
...ipts/invite_members/components/invite_members_trigger.vue
+1
-1
app/assets/javascripts/pages/projects/learn_gitlab/components/learn_gitlab.vue
...s/pages/projects/learn_gitlab/components/learn_gitlab.vue
+1
-1
app/assets/javascripts/pages/projects/learn_gitlab/components/learn_gitlab_section_link.vue
...cts/learn_gitlab/components/learn_gitlab_section_link.vue
+1
-5
spec/frontend/groups/components/invite_members_banner_spec.js
.../frontend/groups/components/invite_members_banner_spec.js
+0
-1
spec/frontend/invite_members/components/invite_members_modal_spec.js
...nd/invite_members/components/invite_members_modal_spec.js
+1
-1
spec/frontend/invite_members/components/invite_members_trigger_spec.js
.../invite_members/components/invite_members_trigger_spec.js
+0
-1
spec/frontend/pages/projects/learn_gitlab/components/learn_gitlab_section_link_spec.js
...learn_gitlab/components/learn_gitlab_section_link_spec.js
+1
-5
spec/frontend/pages/projects/learn_gitlab/components/learn_gitlab_spec.js
...ges/projects/learn_gitlab/components/learn_gitlab_spec.js
+0
-1
No files found.
app/assets/javascripts/groups/components/invite_members_banner.vue
View file @
3e1f672d
...
...
@@ -46,7 +46,6 @@ export default {
},
openModal
()
{
eventHub
.
$emit
(
'
openModal
'
,
{
inviteeType
:
'
members
'
,
source
:
this
.
$options
.
openModalSource
,
});
this
.
track
(
this
.
$options
.
buttonClickEvent
);
...
...
app/assets/javascripts/invite_members/components/invite_members_trigger.vue
View file @
3e1f672d
...
...
@@ -71,7 +71,7 @@ export default {
return
this
.
triggerElement
===
targetTriggerElement
;
},
openModal
()
{
eventHub
.
$emit
(
'
openModal
'
,
{
inviteeType
:
'
members
'
,
source
:
this
.
triggerSource
});
eventHub
.
$emit
(
'
openModal
'
,
{
source
:
this
.
triggerSource
});
},
},
TRIGGER_ELEMENT_BUTTON
,
...
...
app/assets/javascripts/pages/projects/learn_gitlab/components/learn_gitlab.vue
View file @
3e1f672d
...
...
@@ -72,7 +72,7 @@ export default {
return
value
;
},
openInviteMembersModal
(
mode
)
{
eventHub
.
$emit
(
'
openModal
'
,
{
mode
,
inviteeType
:
'
members
'
,
source
:
'
learn-gitlab
'
});
eventHub
.
$emit
(
'
openModal
'
,
{
mode
,
source
:
'
learn-gitlab
'
});
},
handleShowSuccessfulInvitationsAlert
()
{
this
.
showSuccessfulInvitationsAlert
=
true
;
...
...
app/assets/javascripts/pages/projects/learn_gitlab/components/learn_gitlab_section_link.vue
View file @
3e1f672d
...
...
@@ -37,11 +37,7 @@ export default {
},
methods
:
{
openModal
()
{
eventHub
.
$emit
(
'
openModal
'
,
{
inviteeType
:
'
members
'
,
source
:
'
learn_gitlab
'
,
tasksToBeDoneEnabled
:
true
,
});
eventHub
.
$emit
(
'
openModal
'
,
{
source
:
'
learn_gitlab
'
});
},
},
};
...
...
spec/frontend/groups/components/invite_members_banner_spec.js
View file @
3e1f672d
...
...
@@ -76,7 +76,6 @@ describe('InviteMembersBanner', () => {
it
(
'
calls openModal through the eventHub
'
,
()
=>
{
expect
(
eventHub
.
$emit
).
toHaveBeenCalledWith
(
'
openModal
'
,
{
inviteeType
:
'
members
'
,
source
:
'
invite_members_banner
'
,
});
});
...
...
spec/frontend/invite_members/components/invite_members_modal_spec.js
View file @
3e1f672d
...
...
@@ -694,7 +694,7 @@ describe('InviteMembersModal', () => {
});
it
(
'
tracks the view for learn_gitlab source
'
,
()
=>
{
eventHub
.
$emit
(
'
openModal
'
,
{
inviteeType
:
'
members
'
,
source
:
LEARN_GITLAB
});
eventHub
.
$emit
(
'
openModal
'
,
{
source
:
LEARN_GITLAB
});
expect
(
ExperimentTracking
).
toHaveBeenCalledWith
(
INVITE_MEMBERS_FOR_TASK
.
name
);
expect
(
ExperimentTracking
.
prototype
.
event
).
toHaveBeenCalledWith
(
LEARN_GITLAB
);
...
...
spec/frontend/invite_members/components/invite_members_trigger_spec.js
View file @
3e1f672d
...
...
@@ -71,7 +71,6 @@ describe.each(triggerItems)('with triggerElement as %s', (triggerItem) => {
findButton
().
vm
.
$emit
(
'
click
'
);
expect
(
spy
).
toHaveBeenCalledWith
(
'
openModal
'
,
{
inviteeType
:
'
members
'
,
source
:
triggerSource
,
});
});
...
...
spec/frontend/pages/projects/learn_gitlab/components/learn_gitlab_section_link_spec.js
View file @
3e1f672d
...
...
@@ -114,11 +114,7 @@ describe('Learn GitLab Section Link', () => {
it
(
'
calls the eventHub
'
,
()
=>
{
openInviteMembesrModalLink
().
vm
.
$emit
(
'
click
'
);
expect
(
eventHub
.
$emit
).
toHaveBeenCalledWith
(
'
openModal
'
,
{
inviteeType
:
'
members
'
,
source
:
'
learn_gitlab
'
,
tasksToBeDoneEnabled
:
true
,
});
expect
(
eventHub
.
$emit
).
toHaveBeenCalledWith
(
'
openModal
'
,
{
source
:
'
learn_gitlab
'
});
});
it
(
'
tracks the click
'
,
async
()
=>
{
...
...
spec/frontend/pages/projects/learn_gitlab/components/learn_gitlab_spec.js
View file @
3e1f672d
...
...
@@ -80,7 +80,6 @@ describe('Learn GitLab', () => {
expect
(
spy
).
toHaveBeenCalledWith
(
'
openModal
'
,
{
mode
:
'
celebrate
'
,
inviteeType
:
'
members
'
,
source
:
'
learn-gitlab
'
,
});
expect
(
cookieSpy
).
toHaveBeenCalledWith
(
INVITE_MODAL_OPEN_COOKIE
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment