NXD Make HTTP to be the default clone protocol

Both fetch and push are possible over https, which is selected by http if
gitlab was configured to use https in external url.

This way to reduce security vectors and possible ways to interact with gitlab
we use https only without ssh at all.

Conflicts:
	app/helpers/projects_helper.rb

app/helpers/projects_helper.rb

@@ -340,6 +340,8 @@ module ProjectsHelper
   end
 
   def default_url_to_repo(project = @project)
+    # always HTTP:
+    return project.http_url_to_repo
     case default_clone_protocol
     when 'ssh'
       project.ssh_url_to_repo
@@ -349,8 +351,11 @@ module ProjectsHelper
   end
 
   def default_clone_protocol
-    if allowed_protocols_present?
-      enabled_protocol
+    #if allowed_protocols_present?
+    #  enabled_protocol
+    # always HTTP:
+    if true     # !current_user || current_user.require_ssh_key?
+      "http"
     else
       extra_default_clone_protocol
     end

[Jérome Perrin]

@kirr @alain.takoudjou while looking at the admin settings area, I noticed that there's now an option to control which protocols are available:

I don't know if we wrote this patch because this option did not exist at the time or if there was something wrong for us with this option.

[Kirill Smelkov]

@jerome thanks for heads up. I wrote the patch because there was no such option at that time.

[Jérome Perrin]

Thanks @kirr next time we revisit this we can maybe drop the patch and just use the configuration, if it's really enough for us.

[Kirill Smelkov]

Good idea.

[Alain Takoudjou]

Thanks @kirr next time we revisit this we can maybe drop the patch and just use the configuration, if it's really enough for us.

Yes Jerome, I saw the options last week. I will be good to use it instead of patch, I'm testing it on clone instance.

[Alain Takoudjou]

Tested on https://softinst90376.host.vifib.net/. Enable Only HTTP(S) completely removed ssh option on interface. This allow to remove 3 patches: 02761a98 433d2b36 faafaa98

[Kirill Smelkov]

Good. @alain.takoudjou thanks for checking.

[Jérome Perrin]

Thanks @alain.takoudjou it looks ok on https://softinst90376.host.vifib.net/