Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
3ecfa112
Commit
3ecfa112
authored
Feb 24, 2018
by
James Edwards-Jones
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Can save GithubService with blank API URL
parent
2e12507c
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
24 additions
and
2 deletions
+24
-2
ee/spec/features/projects/services/user_activates_github_spec.rb
.../features/projects/services/user_activates_github_spec.rb
+24
-2
No files found.
ee/spec/features/projects/services/user_activates_github_spec.rb
View file @
3ecfa112
...
...
@@ -30,17 +30,39 @@ describe 'User activates GitHub Service' do
visit
project_settings_integrations_path
(
project
)
click_link
(
'GitHub'
)
fill_in_details
end
it
'activates service'
do
def
fill_in_details
check
(
'Active'
)
fill_in
"Token"
,
with:
"aaaaaaaaaa"
fill_in
"Api url"
,
with:
"https://api.github.com"
fill_in
"Owner"
,
with:
"h5bp"
fill_in
"Repository name"
,
with:
"html5-boilerplate"
end
it
'activates service'
do
click_button
(
'Save'
)
expect
(
page
).
to
have_content
(
'GitHub activated.'
)
end
it
'allows API URL to be set'
do
fill_in
"Api url"
,
with:
"https://api.github.com"
click_button
(
'Save'
)
expect
(
page
).
to
have_content
(
'GitHub activated.'
)
end
context
'with pipelines'
,
:js
do
let
(
:pipeline
)
{
create
(
:ci_pipeline
)
}
let
(
:project
)
{
create
(
:project
,
pipelines:
[
pipeline
])}
it
'tests service before save'
do
click_button
'Test settings and save changes'
wait_for_requests
expect
(
page
).
to
have_content
(
'GitHub activated.'
)
end
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment