Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
3f54ae10
Commit
3f54ae10
authored
Jun 28, 2017
by
Bob Van Landuyt
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Resolve conflicts concerning `Gitlab::LDAP::Access`
parent
4dcd2d56
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
11 additions
and
14 deletions
+11
-14
lib/gitlab/ldap/access.rb
lib/gitlab/ldap/access.rb
+0
-4
spec/lib/gitlab/ldap/access_spec.rb
spec/lib/gitlab/ldap/access_spec.rb
+11
-10
No files found.
lib/gitlab/ldap/access.rb
View file @
3f54ae10
...
@@ -19,12 +19,8 @@ module Gitlab
...
@@ -19,12 +19,8 @@ module Gitlab
# Whether user is allowed, or not, we should update
# Whether user is allowed, or not, we should update
# permissions to keep things clean
# permissions to keep things clean
if
access
.
allowed?
if
access
.
allowed?
<<<<<<<
HEAD
access
.
update_user
access
.
update_user
Users
::
UpdateService
.
new
(
user
,
last_credential_check_a:
Time
.
now
).
execute
=======
Users
::
UpdateService
.
new
(
user
,
last_credential_check_at:
Time
.
now
).
execute
Users
::
UpdateService
.
new
(
user
,
last_credential_check_at:
Time
.
now
).
execute
>>>>>>>
upstream
/
master
true
true
else
else
...
...
spec/lib/gitlab/ldap/access_spec.rb
View file @
3f54ae10
...
@@ -5,7 +5,17 @@ describe Gitlab::LDAP::Access, lib: true do
...
@@ -5,7 +5,17 @@ describe Gitlab::LDAP::Access, lib: true do
let
(
:access
)
{
Gitlab
::
LDAP
::
Access
.
new
user
}
let
(
:access
)
{
Gitlab
::
LDAP
::
Access
.
new
user
}
let
(
:user
)
{
create
(
:omniauth_user
)
}
let
(
:user
)
{
create
(
:omniauth_user
)
}
<<<<<<<
HEAD
describe
'.allowed?'
do
it
'updates the users `last_credential_check_at'
do
allow
(
access
).
to
receive
(
:update_user
)
expect
(
access
).
to
receive
(
:allowed?
)
{
true
}
expect
(
described_class
).
to
receive
(
:open
).
and_yield
(
access
)
expect
{
described_class
.
allowed?
(
user
)
}
.
to
change
{
user
.
last_credential_check_at
}
end
end
describe
'#find_ldap_user'
do
describe
'#find_ldap_user'
do
it
'finds a user by dn first'
do
it
'finds a user by dn first'
do
expect
(
Gitlab
::
LDAP
::
Person
).
to
receive
(
:find_by_dn
).
and_return
(
:ldap_user
)
expect
(
Gitlab
::
LDAP
::
Person
).
to
receive
(
:find_by_dn
).
and_return
(
:ldap_user
)
...
@@ -20,15 +30,6 @@ describe Gitlab::LDAP::Access, lib: true do
...
@@ -20,15 +30,6 @@ describe Gitlab::LDAP::Access, lib: true do
expect
(
Gitlab
::
LDAP
::
Person
).
to
receive
(
:find_by_email
)
expect
(
Gitlab
::
LDAP
::
Person
).
to
receive
(
:find_by_email
)
access
.
find_ldap_user
access
.
find_ldap_user
=======
describe
'.allowed?'
do
it
'updates the users `last_credential_check_at'
do
expect
(
access
).
to
receive
(
:allowed?
)
{
true
}
expect
(
described_class
).
to
receive
(
:open
).
and_yield
(
access
)
expect
{
described_class
.
allowed?
(
user
)
}
.
to
change
{
user
.
last_credential_check_at
}
>>>>>>>
upstream
/
master
end
end
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment