Allow runner_matchers callsite

This removes at least two specs from the spec allowlist, both of which
are tested to still pass. This callsite is causing cross-db queries 400
times in our CI

app/models/ci/runner.rb

@@ -208,16 +208,18 @@ module Ci
         Arel.sql("(#{arel_tag_names_array.to_sql})")
       ]
 
-      group(*unique_params).pluck('array_agg(ci_runners.id)', *unique_params).map do |values|
-        Gitlab::Ci::Matching::RunnerMatcher.new({
-          runner_ids: values[0],
-          runner_type: values[1],
-          public_projects_minutes_cost_factor: values[2],
-          private_projects_minutes_cost_factor: values[3],
-          run_untagged: values[4],
-          access_level: values[5],
-          tag_list: values[6]
-        })
+      ::Gitlab::Database.allow_cross_joins_across_databases(url: 'https://gitlab.com/gitlab-org/gitlab/-/issues/339621') do
+        group(*unique_params).pluck('array_agg(ci_runners.id)', *unique_params).map do |values|
+          Gitlab::Ci::Matching::RunnerMatcher.new({
+            runner_ids: values[0],
+            runner_type: values[1],
+            public_projects_minutes_cost_factor: values[2],
+            private_projects_minutes_cost_factor: values[3],
+            run_untagged: values[4],
+            access_level: values[5],
+            tag_list: values[6]
+          })
+        end
       end
     end
 

spec/support/database/cross-join-allowlist.yml

@@ -88,7 +88,6 @@
 - "./ee/spec/services/ci/minutes/refresh_cached_data_service_spec.rb"
 - "./ee/spec/services/ci/pipeline_creation/drop_not_runnable_builds_service_spec.rb"
 - "./ee/spec/services/ci/process_pipeline_service_spec.rb"
-- "./ee/spec/services/ci/retry_build_service_spec.rb"
 - "./ee/spec/services/ci/retry_pipeline_service_spec.rb"
 - "./ee/spec/services/ci/trigger_downstream_subscription_service_spec.rb"
 - "./ee/spec/services/clear_namespace_shared_runners_minutes_service_spec.rb"
@@ -335,7 +334,6 @@
 - "./spec/services/ci/pipeline_processing/shared_processing_service_tests_with_yaml.rb"
 - "./spec/services/ci/play_build_service_spec.rb"
 - "./spec/services/ci/register_job_service_spec.rb"
-- "./spec/services/ci/retry_build_service_spec.rb"
 - "./spec/services/ci/retry_pipeline_service_spec.rb"
 - "./spec/services/ci/update_build_queue_service_spec.rb"
 - "./spec/services/clusters/applications/prometheus_config_service_spec.rb"