Merge branch '239356-fix-Style/BisectedAttrAccessor' into 'master'

Fix Style/BisectedAttrAccessor offenses

See merge request gitlab-org/gitlab!83834

.rubocop_todo.yml

@@ -343,13 +343,6 @@ Style/AccessorGrouping:
 Style/BarePercentLiterals:
   Enabled: false
 
-# Offense count: 6
-# Cop supports --auto-correct.
-Style/BisectedAttrAccessor:
-  Exclude:
-    - 'lib/system_check/base_check.rb'
-    - 'qa/qa/resource/api_fabricator.rb'
-
 # Offense count: 42
 # Cop supports --auto-correct.
 Style/CaseLikeIf:

lib/system_check/base_check.rb

@@ -64,20 +64,14 @@ module SystemCheck
       call_or_return(@skip_reason) || 'skipped'
     end
 
-    # Define a reason why we skipped the SystemCheck (during runtime)
+    # Define or get a reason why we skipped the SystemCheck (during runtime)
     #
     # This is used when you need dynamic evaluation like when you have
     # multiple reasons why a check can fail
     #
     # @param [String] reason to be displayed
-    attr_writer :skip_reason
-
-    # Skip reason defined during runtime
-    #
-    # This value have precedence over the one defined in the subclass
-    #
-    # @return [String] the reason
-    attr_reader :skip_reason
+    # @return [String] reason to be displayed
+    attr_accessor :skip_reason
 
     # Does the check support automatically repair routine?
     #