Address reviewer feedback

- remove 'remember-me' class and checkbox class (not needed)
- Use gitlab-ui classes where possible for omniauth

app/assets/stylesheets/framework/forms.scss

@@ -196,14 +196,6 @@ label {
   }
 }
 
-@include media-breakpoint-down(xs) {
-  .remember-me {
-    .remember-me-checkbox {
-      margin-top: 0;
-    }
-  }
-}
-
 .input-icon-wrapper,
 .select-wrapper {
   position: relative;

app/assets/stylesheets/startup/startup-signin.scss

@@ -258,15 +258,6 @@ fieldset:disabled a.btn {
   align-items: center;
   justify-content: space-between;
 }
-.d-block {
-  display: block !important;
-}
-.d-flex {
-  display: flex !important;
-}
-.align-items-center {
-  align-items: center !important;
-}
 .fixed-top {
   position: fixed;
   top: 0;
@@ -764,6 +755,9 @@ svg {
 .gl-display-block {
   display: block;
 }
+.gl-align-items-center {
+  align-items: center;
+}
 .gl-flex-wrap {
   flex-wrap: wrap;
 }
@@ -787,6 +781,9 @@ svg {
     margin-top: 0;
   }
 }
+.gl-font-weight-bold {
+  font-weight: 600;
+}
 
 @import "startup/cloaking";
 @include cloak-startup-scss(none);

app/views/devise/sessions/_new_base.html.haml

@@ -6,10 +6,10 @@
     = f.label :password, class: 'label-bold'
     = f.password_field :password, class: 'form-control gl-form-input bottom', required: true, title: _('This field is required.'), data: { qa_selector: 'password_field' }
   - if devise_mapping.rememberable?
-    .remember-me
+    %div
       %label{ for: 'user_remember_me' }
-        = f.check_box :remember_me, class: 'remember-me-checkbox'
-        %span Remember me
+        = f.check_box :remember_me
+        %span= _('Remember me')
       .float-right
         - if unconfirmed_email?
           = link_to _('Resend confirmation email'), new_user_confirmation_path

app/views/devise/shared/_omniauth_box.html.haml

 - hide_remember_me = local_assigns.fetch(:hide_remember_me, false)
 
 .omniauth-container.gl-mt-5
-  %label.label-bold.d-block
+  %label.gl-font-weight-bold
     = _('Sign in with')
   - providers = enabled_button_based_providers
-  .d-flex.justify-content-between.flex-wrap
+  .gl-display-flex.gl-justify-content-between.gl-flex-wrap
     - providers.each do |provider|
       - has_icon = provider_has_icon?(provider)
       = button_to omniauth_authorize_path(:user, provider), id: "oauth-login-#{provider}", class: "btn gl-button btn-default gl-w-full js-oauth-login #{qa_class_for_provider(provider)}", form: { class: 'gl-w-full gl-mb-3' } do
@@ -13,8 +13,8 @@
         %span.gl-button-text
           = label_for_provider(provider)
   - unless hide_remember_me
-    %fieldset.remember-me
+    %fieldset
       %label
-        = check_box_tag :remember_me, nil, false, class: 'remember-me-checkbox'
+        = check_box_tag :remember_me, nil, false
         %span
           = _('Remember me')

app/views/devise/shared/_signup_omniauth_provider_list.haml

-%label.label-bold.d-block
+%label.gl-font-weight-bold
   = _("Create an account using:")
 .gl-display-flex.gl-justify-content-between.gl-flex-wrap
   - providers.each do |provider|

app/views/devise/shared/_signup_omniauth_providers.haml

-.omniauth-divider.d-flex.align-items-center.text-center
+.omniauth-divider.gl-display-flex.gl-align-items-center
   = _("or")
 = render 'devise/shared/signup_omniauth_provider_list', providers: enabled_button_based_providers

app/views/devise/shared/_signup_omniauth_providers_top.haml

 = render 'devise/shared/signup_omniauth_provider_list', providers: popular_enabled_button_based_providers
-.omniauth-divider.d-flex.align-items-center.text-center
+.omniauth-divider.gl-display-flex.gl-align-items-center
   = _("or")

ee/app/assets/stylesheets/startup/startup-signin.scss

@@ -258,15 +258,6 @@ fieldset:disabled a.btn {
   align-items: center;
   justify-content: space-between;
 }
-.d-block {
-  display: block !important;
-}
-.d-flex {
-  display: flex !important;
-}
-.align-items-center {
-  align-items: center !important;
-}
 .fixed-top {
   position: fixed;
   top: 0;
@@ -764,6 +755,9 @@ svg {
 .gl-display-block {
   display: block;
 }
+.gl-align-items-center {
+  align-items: center;
+}
 .gl-flex-wrap {
   flex-wrap: wrap;
 }
@@ -787,6 +781,9 @@ svg {
     margin-top: 0;
   }
 }
+.gl-font-weight-bold {
+  font-weight: 600;
+}
 
 @import "startup/cloaking";
 @include cloak-startup-scss(none);