Commit 42f81b36 authored by Olena Horal-Koretska's avatar Olena Horal-Koretska

Merge branch 'jswain_whats_new_styles' into 'master'

Whats New - minor styling changes

See merge request gitlab-org/gitlab!47115
parents cf97630e 09cfc063
...@@ -71,7 +71,7 @@ export default { ...@@ -71,7 +71,7 @@ export default {
@close="closeDrawer" @close="closeDrawer"
> >
<template #header> <template #header>
<h4 class="page-title gl-my-3">{{ __("What's new at GitLab") }}</h4> <h4 class="page-title gl-my-2">{{ __("What's new at GitLab") }}</h4>
</template> </template>
<gl-infinite-scroll <gl-infinite-scroll
v-if="features.length" v-if="features.length"
...@@ -81,16 +81,20 @@ export default { ...@@ -81,16 +81,20 @@ export default {
@bottomReached="bottomReached" @bottomReached="bottomReached"
> >
<template #items> <template #items>
<div v-for="feature in features" :key="feature.title" class="gl-mb-7 gl-px-5 gl-pt-5"> <div
v-for="feature in features"
:key="feature.title"
class="gl-pb-7 gl-pt-5 gl-px-5 gl-border-b-1 gl-border-b-solid gl-border-b-gray-100"
>
<gl-link <gl-link
:href="feature.url" :href="feature.url"
target="_blank" target="_blank"
data-testid="whats-new-title-link" class="whats-new-item-title-link"
data-track-event="click_whats_new_item" data-track-event="click_whats_new_item"
:data-track-label="feature.title" :data-track-label="feature.title"
:data-track-property="feature.url" :data-track-property="feature.url"
> >
<h5 class="gl-font-base">{{ feature.title }}</h5> <h5 class="gl-font-lg">{{ feature.title }}</h5>
</gl-link> </gl-link>
<div v-if="feature.packages" class="gl-mb-3"> <div v-if="feature.packages" class="gl-mb-3">
<gl-badge <gl-badge
......
...@@ -18,6 +18,14 @@ ...@@ -18,6 +18,14 @@
@include gl-font-weight-bold; @include gl-font-weight-bold;
} }
.whats-new-item-title-link {
&:hover,
&:focus,
&:active {
@include gl-text-gray-900;
}
}
.whats-new-item-image { .whats-new-item-image {
border-color: $gray-50; border-color: $gray-50;
} }
......
...@@ -107,7 +107,7 @@ describe('App', () => { ...@@ -107,7 +107,7 @@ describe('App', () => {
it('send an event when feature item is clicked', () => { it('send an event when feature item is clicked', () => {
trackingSpy = mockTracking('_category_', wrapper.element, jest.spyOn); trackingSpy = mockTracking('_category_', wrapper.element, jest.spyOn);
const link = wrapper.find('[data-testid="whats-new-title-link"]'); const link = wrapper.find('.whats-new-item-title-link');
triggerEvent(link.element); triggerEvent(link.element);
expect(trackingSpy.mock.calls[1]).toMatchObject([ expect(trackingSpy.mock.calls[1]).toMatchObject([
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment