Merge branch 'create-token--http-response' into 'master'

Create token response should be CREATED

See merge request gitlab-org/gitlab!28587

app/services/groups/deploy_tokens/create_service.rb

@@ -9,7 +9,7 @@ module Groups
         deploy_token = create_deploy_token_for(@group, params)
 
         if deploy_token.persisted?
-          success(deploy_token: deploy_token, http_status: :ok)
+          success(deploy_token: deploy_token, http_status: :created)
         else
           error(deploy_token.errors.full_messages.to_sentence, :bad_request)
         end

app/services/projects/deploy_tokens/create_service.rb

@@ -9,7 +9,7 @@ module Projects
         deploy_token = create_deploy_token_for(@project, params)
 
         if deploy_token.persisted?
-          success(deploy_token: deploy_token, http_status: :ok)
+          success(deploy_token: deploy_token, http_status: :created)
         else
           error(deploy_token.errors.full_messages.to_sentence, :bad_request)
         end

changelogs/unreleased/create-token--http-response.yml

+---
+title: Token creation uses HTTP status CREATED
+merge_request: 28587
+author:
+type: fixed

spec/controllers/groups/settings/ci_cd_controller_spec.rb

@@ -267,7 +267,7 @@ describe Groups::Settings::CiCdController do
         it 'creates the deploy token' do
           subject
 
-          expect(response).to have_gitlab_http_status(:ok)
+          expect(response).to have_gitlab_http_status(:created)
           expect(response).to match_response_schema('public_api/v4/deploy_token')
           expect(json_response).to match(expected_response)
         end

spec/controllers/projects/settings/ci_cd_controller_spec.rb

@@ -300,7 +300,7 @@ describe Projects::Settings::CiCdController do
         it 'creates the deploy token' do
           subject
 
-          expect(response).to have_gitlab_http_status(:ok)
+          expect(response).to have_gitlab_http_status(:created)
           expect(response).to match_response_schema('public_api/v4/deploy_token')
           expect(json_response).to match(expected_response)
         end