Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
4454470d
Commit
4454470d
authored
Nov 16, 2017
by
Clement Ho
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove duplicate delete button in epic
parent
455ffc96
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
20 additions
and
1 deletion
+20
-1
changelogs/unreleased-ee/remove-duplicate-delete-btn.yml
changelogs/unreleased-ee/remove-duplicate-delete-btn.yml
+5
-0
ee/app/assets/javascripts/epics/epic_show/components/epic_show_app.vue
.../javascripts/epics/epic_show/components/epic_show_app.vue
+1
-1
spec/ee/spec/features/epics/update_epic_spec.rb
spec/ee/spec/features/epics/update_epic_spec.rb
+14
-0
No files found.
changelogs/unreleased-ee/remove-duplicate-delete-btn.yml
0 → 100644
View file @
4454470d
---
title
:
Remove duplicate delete button in epic
merge_request
:
author
:
type
:
fixed
ee/app/assets/javascripts/epics/epic_show/components/epic_show_app.vue
View file @
4454470d
...
@@ -121,6 +121,7 @@
...
@@ -121,6 +121,7 @@
:project-path=
"projectPath"
:project-path=
"projectPath"
:project-namespace=
"projectNamespace"
:project-namespace=
"projectNamespace"
:show-inline-edit-button=
"true"
:show-inline-edit-button=
"true"
:show-delete-button=
"false"
/>
/>
</div>
</div>
<epic-sidebar
<epic-sidebar
...
@@ -135,7 +136,6 @@
...
@@ -135,7 +136,6 @@
:project-path=
"projectPath"
:project-path=
"projectPath"
:project-namespace=
"projectNamespace"
:project-namespace=
"projectNamespace"
:show-inline-edit-button=
"true"
:show-inline-edit-button=
"true"
:show-delete-button=
"false"
issuable-type=
"epic"
issuable-type=
"epic"
:editable=
"canUpdate"
:editable=
"canUpdate"
:initial-start-date=
"startDate"
:initial-start-date=
"startDate"
...
...
spec/ee/spec/features/epics/update_epic_spec.rb
View file @
4454470d
...
@@ -37,4 +37,18 @@ feature 'Update Epic', :js do
...
@@ -37,4 +37,18 @@ feature 'Update Epic', :js do
expect
(
find
(
'.issuable-details .description'
)).
to
have_content
(
'New epic description'
)
expect
(
find
(
'.issuable-details .description'
)).
to
have_content
(
'New epic description'
)
end
end
end
end
context
'when user with owner access displays the epic'
do
before
do
group
.
add_owner
(
user
)
visit
group_epic_path
(
group
,
epic
)
wait_for_requests
end
it
'does not show delete button inside the edit form'
do
find
(
'.btn-edit'
).
click
expect
(
page
).
not_to
have_selector
(
'.issuable-details .btn-danger'
)
end
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment